Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040276ModulesSAP Connector Mappingspublic2019-02-26 17:252019-03-13 16:23
Reporterumartirena 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040276: <KONDART> property on WP_PLU iDoc is not properly managed. It only works for the first pricelist
Description<KONDART> property on WP_PLU iDoc is not properly managed. It only works for the first pricelist
Steps To ReproduceInstall the following SAP Conector modules
 * org.openbravo.externaldata.integration
 * org.openbravo.service.external.integration
 * org.openbravo.service.integration.sapecc
 * org.openbravo.service.integration.sap.ecc.mappings

As System Administrator open "Entity Mapping" window and search by WP_PLU Entity. Integration direction: From External System to OB.
 * set Idoc Subfolfer: WP_PLU

Log in as Openbravo/openbravo in OB backoffice. Select "The White Valley Group Admin" role.

Open "Initialize Entity Synchronization" window
 * External Type: SAP ECC
 * Start Integration From Time: Yesterday
 * Click Done

Open "Commnunication with SAP ECC Server" window and create a record:
 * Commnunication Protocol: Debug
 * Path to iDoc Folder: /home/openbravo/sapidocs

Open "EDL Configuration" window and create a new record:
 * EDL Process: SAP ECC Object Import Process

Create Output record: Output type, debug

Add necessary SAP Codes:
 * Organization: T040
 * Product Category (sky) : Z01
 * Tax Category (IVA Normal ) : R3

Create /home/openbravo/sapidocs/WP_PLU folder in the file system
Place there the attached file WP_PLU00.xml

Open "Process Request" window and create a record:
 * Process: SAP ECC Import Synchronization Process
 * Timing: Run Immediately
 * Click on Schedule

Go to Price List window. Check that ZP00 Price List has been created:
 * Name: ZP00
 * SAP Code: PN10
 * A record has been created for PROD0 item in product price tab.

Place the attached file WP_PLU01.xml in /home/openbravo/sapidocs/WP_PLU

Open "Process Request" window and find the oreciously created record
Click on Schedule

Go to Price List window. Find ZP00 Price List
 * Check that a record has been created for PROD1 item in product price tab.

This is wrong. Item PROD1 should belong to ZP01 Price List, which has not been created, and wrongly has been added to ZP00.
Proposed SolutionCurrently the SAP Code of Price List created in WP_PLU is hardcoded to "PN10", which is wrong, it should be the same value set as name, the property <KONDART> of the iDoc.

The process, to find existing Price List, it should filter by this value, not "PN10"
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040367 scheduled psanjuan Wrong Price List SAP Code management when importing a Business Partner 
Attached Filesxml WP_PLU01.xml (2,254) 2019-02-26 17:25
https://issues.openbravo.com/file_download.php?file_id=12685&type=bug
xml WP_PLU00.xml (2,254) 2019-03-05 11:30
https://issues.openbravo.com/file_download.php?file_id=12705&type=bug
xml WP_PLU02.xml (2,253) 2019-03-13 11:10
https://issues.openbravo.com/file_download.php?file_id=12742&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-26 17:25umartirenaNew Issue
2019-02-26 17:25umartirenaAssigned To => platform
2019-02-26 17:25umartirenaResolution time => 1552950000
2019-02-26 17:25umartirenaFile Added: WP_PLU00.xml
2019-02-26 17:25umartirenaFile Added: WP_PLU01.xml
2019-02-26 17:36umartirenaIssue Monitored: umartirena
2019-02-27 11:00psanjuanAssigned Toplatform => Triage Finance
2019-02-27 11:00psanjuanCategorySAP Connector => SAP Connector Mappings
2019-02-27 12:08SandrahuguetAssigned ToTriage Finance => markmm82
2019-02-28 18:22markmm82Statusnew => scheduled
2019-03-03 16:52markmm82Note Added: 0110165
2019-03-05 10:32psanjuanFile Deleted: WP_PLU00.xml
2019-03-05 11:30psanjuanFile Added: WP_PLU00.xml
2019-03-05 12:37psanjuanNote Added: 0110229
2019-03-05 12:37psanjuanProposed Solution updated
2019-03-05 12:43psanjuanNote Edited: 0110229bug_revision_view_page.php?bugnote_id=0110229#r18390
2019-03-05 13:04psanjuanNote Edited: 0110229bug_revision_view_page.php?bugnote_id=0110229#r18391
2019-03-05 13:05psanjuanNote Edited: 0110229bug_revision_view_page.php?bugnote_id=0110229#r18392
2019-03-07 15:15psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18402#r18402
2019-03-07 15:16psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18403#r18403
2019-03-07 15:19psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18404#r18404
2019-03-07 15:34psanjuanNote Added: 0110286
2019-03-07 15:35psanjuanNote Edited: 0110286bug_revision_view_page.php?bugnote_id=0110286#r18406
2019-03-07 16:39SandrahuguetNote Added: 0110297
2019-03-07 16:40SandrahuguetStatusscheduled => resolved
2019-03-07 16:40SandrahuguetResolutionopen => fixed
2019-03-07 16:40SandrahuguetReview Assigned To => Sandrahuguet
2019-03-07 16:40SandrahuguetNote Added: 0110298
2019-03-07 16:40SandrahuguetStatusresolved => closed
2019-03-11 18:18hgbotCheckin
2019-03-11 18:18hgbotNote Added: 0110357
2019-03-12 17:23psanjuanNote Added: 0110390
2019-03-12 17:23psanjuanAssigned Tomarkmm82 => Sandrahuguet
2019-03-12 17:23psanjuanStatusclosed => new
2019-03-12 17:23psanjuanResolutionfixed => open
2019-03-13 01:57markmm82Assigned ToSandrahuguet => markmm82
2019-03-13 01:57markmm82Statusnew => scheduled
2019-03-13 02:14markmm82Relationship addedrelated to 0040367
2019-03-13 10:32psanjuanNote Added: 0110399
2019-03-13 11:06psanjuanNote Edited: 0110399bug_revision_view_page.php?bugnote_id=0110399#r18444
2019-03-13 11:10psanjuanFile Added: WP_PLU02.xml
2019-03-13 11:43psanjuanNote Added: 0110400
2019-03-13 16:22hgbotCheckin
2019-03-13 16:22hgbotNote Added: 0110415
2019-03-13 16:23SandrahuguetStatusscheduled => resolved
2019-03-13 16:23SandrahuguetResolutionopen => fixed
2019-03-13 16:23SandrahuguetNote Added: 0110416
2019-03-13 16:23SandrahuguetStatusresolved => closed
2019-03-14 09:46psanjuanNote Edited: 0110400bug_revision_view_page.php?bugnote_id=0110400#r18463

Notes
(0110165)
markmm82   
2019-03-03 16:52   
Test Plan:

Install the following SAP Conector modules
 * org.openbravo.externaldata.integration
 * org.openbravo.service.external.integration
 * org.openbravo.service.integration.sapecc
 * org.openbravo.service.integration.sap.ecc.mappings

As System Administrator open "Entity Mapping" window and search by WP_PLU Entity. Integration direction: From External System to OB.
 * set Idoc Subfolfer: WP_PLU

Log in as Openbravo/openbravo in OB backoffice. Select "The White Valley Group Admin" role.

Open "Initialize Entity Synchronization" window
 * External Type: SAP ECC
 * Start Integration From Time: Yesterday
 * Click Done

Open "Commnunication with SAP ECC Server" window and create a record:
 * Commnunication Protocol: Debug
 * Path to iDoc Folder: /home/openbravo/sapidocs

Open "EDL Configuration" window and create a new record:
 * EDL Process: BOB ID Based Export Process.

Create Output record: Output type, debug

Add necessary SAP Codes:
 * Organization: T040

Create /home/openbravo/sapidocs/WP_PLU folder in the file system
Place there the attached file WP_PLU00.xml

Open "Process Request" window and create a record:
 * Process: SAP ECC Import Synchronization Process
 * Timing: Run Immediately
 * Click on Schedule

Go to Price List window. Check that ZP00 Price List has been created:
 * Name: ZP00
 * SAP Code: ZP00
 * A record has been created for PROD0 item in product price tab.

Place the attached file WP_PLU01.xml in /home/openbravo/sapidocs/WP_PLU

Open "Process Request" window and find the previously created record
Click on Schedule

Go to Price List window. Find ZP01 Price List
 * Check that a record has been created for PROD1 item in product price tab.
(0110229)
psanjuan   
2019-03-05 12:37   
(edited on: 2019-03-05 13:05)
Issue reproduced.

Updated proposed solution:

The process to find and existing Price List, should filter by the "Name" of the price List (in our example ZP00, that is the value in the field KONDART) not by its SAP code, therefore in this case two price lists should have been created (ZP00 and ZP01)

Besides this, the SAP Code should not be harcoded to PN10 but to the value of the field KONDART.
(0110286)
psanjuan   
2019-03-07 15:34   
(edited on: 2019-03-07 15:35)
Fix attached reviewed & verified according to test plan above.
(0110297)
Sandrahuguet   
2019-03-07 16:39   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: 05ff9ca51342
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Thu Feb 28 23:46:11 2019 -0300
URL: https://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/05ff9ca51342 [^]

Fixes issue <KONDART> property on WP_PLU iDoc is not properly managed.
It only works for the first pricelist

---
M
src/org/openbravo/service/integration/sap/ecc/mappings/javamapper/ImportProductJavaPropertyMappingHandler.java
src/org/openbravo/service/integration/sap/ecc/mappings/util/MappingUtils.java
---
(0110298)
Sandrahuguet   
2019-03-07 16:40   
code review + testing Ok
(0110357)
hgbot   
2019-03-11 18:18   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: c457d409916b96eafc38d3f3cd357aae47eeb160
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Mon Mar 11 12:23:24 2019 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/c457d409916b96eafc38d3f3cd357aae47eeb160 [^]

Related to issue 40276: Fixed SAPStd160 test

---
M src-test/org/openbravo/service/integration/sap/ecc/mappings/outbound/SAPStd160.java
---
(0110390)
psanjuan   
2019-03-12 17:23   
Issue re-opened to improve it, therefore the process to find and existing Price List, should filter by the "SAP Code" of the price List (not the "Name") as it could happen in some scenarios that the name is later on changed, while the SAP Code remains the same.
(0110399)
psanjuan   
2019-03-13 10:32   
(edited on: 2019-03-13 11:06)
Test plan:

Delete the two products created by deleting first the assorment they are related to and their accounting.

In /home/openbravo/sapidocs/WP_PLU folder place the attached file WP_PLU00.xml

Open "Process Request" window and create a record:
 * Process: SAP ECC Import Synchronization Process
 * Timing: Run Immediately
 * Click on Schedule

Go to Product window. Check that product PR00 has been created related to price list ZP00

Go to Price List window. Check that ZP00 Price List has been created:
 * Name: ZP00. Change its name to "Test".
 * SAP Code: ZP00
 * A record has been created for PROD0 item in product price tab.

Place the attached file WP_PLU01.xml in /home/openbravo/sapidocs/WP_PLU

Open "Process Request" window and find the previously created record
Click on Schedule

Go to Product window. Check that product PR01 has been created related to price list ZP01

Go to Price List window. Check that ZP01 Price List has been created:
 * Name: ZP01. Change its name to "Nuevo Test".
 * SAP Code: ZP01
 * A record has been created for PROD1 item in product price tab.

Finally, place the attached file WP_PLU02.xml in /home/openbravo/sapidocs/WP_PLU

Open "Process Request" window and find the previously created record
Click on Schedule

Go to Product window. Check that last product, product PR02, has been created related to an existing price list ZP00 which name was changed.
(0110400)
psanjuan   
2019-03-13 11:43   
(edited on: 2019-03-14 09:46)
Test plan above verified. Fix can be code reviewed.
(0110415)
hgbot   
2019-03-13 16:22   
Repository: erp/pmods/org.openbravo.service.integration.sap.ecc.mappings
Changeset: f45578924d2bfc6d7e37ff7b4773ff46aa13d6f0
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Tue Mar 12 21:05:17 2019 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sap.ecc.mappings/rev/f45578924d2bfc6d7e37ff7b4773ff46aa13d6f0 [^]

Related to issue 40276: Filter by the "SAP Code" of the price List not by "Name"

To find an existing Price List, is filtering by the "SAP Code" of the price List
not by the "Name" as it could happen in some scenarios that the name is later on
changed, while the SAP Code remains the same.

---
M src-test/org/openbravo/service/integration/sap/ecc/mappings/outbound/SAPStd160.java
M src/org/openbravo/service/integration/sap/ecc/mappings/javamapper/ImportProductJavaPropertyMappingHandler.java
M src/org/openbravo/service/integration/sap/ecc/mappings/util/MappingUtils.java
---
(0110416)
Sandrahuguet   
2019-03-13 16:23   
Code review + testing OK