Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040266Retail ModulesTests Stabilizationpublic2019-02-25 12:302019-07-01 19:18
Reportergorka_gil 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040266: Make tests to wait for all mobile processes to finish in each action
DescriptionThe web pos has defined many process like addproduct, addpayment, completeReceipt, etc

The tests could make use of them so in each tap, wait for all processes to finish, before continue with the test.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0041214RR19Q1.2 closed gorka_gil Make tests to wait for all mobile processes to finish in each action 
related to defect 0040348 closed gorka_gil pi-mobile: wait for process to finish or till a new popup is opened 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-25 12:30gorka_gilNew Issue
2019-02-25 12:30gorka_gilAssigned To => gorka_gil
2019-02-25 12:30gorka_gilOBNetwork customer => No
2019-02-25 12:30gorka_gilTriggers an Emergency Pack => No
2019-02-25 12:30gorka_gilStatusnew => scheduled
2019-02-25 13:56gorka_gilReview Assigned To => migueldejuana
2019-02-25 16:13hgbotCheckin
2019-02-25 16:13hgbotNote Added: 0110070
2019-02-25 16:13hgbotStatusscheduled => resolved
2019-02-25 16:13hgbotResolutionopen => fixed
2019-02-25 16:13hgbotFixed in SCM revision => http://code.openbravo.com/tools/automation/pi-mobile/rev/b4f4b76885644345f8730fac4c9f6bd1dc424ca2 [^]
2019-02-25 16:13hgbotCheckin
2019-02-25 16:13hgbotNote Added: 0110071
2019-02-25 16:13hgbotCheckin
2019-02-25 16:13hgbotNote Added: 0110072
2019-02-26 11:49hgbotCheckin
2019-02-26 11:49hgbotNote Added: 0110082
2019-02-26 16:04hgbotCheckin
2019-02-26 16:04hgbotNote Added: 0110084
2019-02-26 16:44migueldejuanaNote Added: 0110085
2019-02-26 16:44migueldejuanaStatusresolved => new
2019-02-26 16:44migueldejuanaResolutionfixed => open
2019-02-26 18:14hgbotCheckin
2019-02-26 18:14hgbotNote Added: 0110092
2019-02-28 10:21gorka_gilStatusnew => scheduled
2019-02-28 10:21gorka_gilStatusscheduled => resolved
2019-02-28 10:21gorka_gilResolutionopen => fixed
2019-02-28 18:16migueldejuanaNote Added: 0110132
2019-02-28 18:17migueldejuanaNote Added: 0110133
2019-02-28 18:17migueldejuanaStatusresolved => closed
2019-03-01 18:37hgbotCheckin
2019-03-01 18:37hgbotNote Added: 0110159
2019-03-11 12:03gorka_gilRelationship addedrelated to 0040348
2019-03-27 16:12hgbotCheckin
2019-03-27 16:12hgbotNote Added: 0110700
2019-03-27 16:12hgbotCheckin
2019-03-27 16:12hgbotNote Added: 0110702
2019-07-01 19:17gorka_gilStatusclosed => new
2019-07-01 19:17gorka_gilResolutionfixed => open
2019-07-01 19:18gorka_gilStatusnew => scheduled
2019-07-01 19:18gorka_gilStatusscheduled => resolved
2019-07-01 19:18gorka_gilResolutionopen => fixed
2019-07-01 19:18gorka_gilStatusresolved => closed

Notes
(0110070)
hgbot   
2019-02-25 16:13   
Repository: tools/automation/pi-mobile
Changeset: b4f4b76885644345f8730fac4c9f6bd1dc424ca2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Feb 25 13:35:56 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b4f4b76885644345f8730fac4c9f6bd1dc424ca2 [^]

Fixes issue 40266: Added functionality to wait for the finish of mobile processes

After each tap the tests will wait for all processes to finish before continue

Remove the use of verifyThatTheLoginProcessHasStarted and verifyThatTheLoginProcessHasEnded
Since replaced with the wait for processes

Fixed the current method verifyAllProcessesFinished to use the new API.

---
M src-test/org/openbravo/test/mobile/core/utils/OBConstants.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/selenium/terminals/MobileCoreTerminalHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/utils/RetailUtils.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/terminals/WebPOSTerminalHelper.java
---
(0110071)
hgbot   
2019-02-25 16:13   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: dbc8014027ce08474558fcce1c8b1fb409d3bd7f
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Feb 25 12:54:06 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/dbc8014027ce08474558fcce1c8b1fb409d3bd7f [^]

Related to issue 40266: Add status to mobile processes

This helps to know if the process is in status running or
waiting for an user action.

Fixed method getProcessesInExec, it was not returning correctly
the processes in execution

Added also methods to pause and resume the processes and
functions to returns the current processes in each status.

---
M web/org.openbravo.mobile.core/source/utils/ob-processcontroller.js
---
(0110072)
hgbot   
2019-02-25 16:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ed89c2c2c4822b956704ad20ef27fc17c54c5de5
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Feb 25 16:10:01 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed89c2c2c4822b956704ad20ef27fc17c54c5de5 [^]

Related to issue 40266: Add paused status to processes that opens a popup that require user action

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0110082)
hgbot   
2019-02-26 11:49   
Repository: tools/automation/pi-mobile
Changeset: 5855061c449b6bb2c9a025033657e2b2451715e2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Feb 25 18:54:32 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5855061c449b6bb2c9a025033657e2b2451715e2 [^]

Related to issue 40266: add waitToFinishAllProcesses after write in a field

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
---
(0110084)
hgbot   
2019-02-26 16:04   
Repository: tools/automation/pi-mobile
Changeset: 2ba1b7513e0db0aaf11913a64cedc4cd1341fe90
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Feb 26 16:03:40 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2ba1b7513e0db0aaf11913a64cedc4cd1341fe90 [^]

Related to issue 40266: add tapNoWaitProcesses, for especial cases

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/intuitive/IntuitiveCommandsMobileCore.java
---
(0110085)
migueldejuana   
2019-02-26 16:44   
- No need to create a var with values, set directly vstring values like "waiting", "running":
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/dbc8014027ce08474558fcce1c8b1fb409d3bd7f#l1.15 [^]
(0110092)
hgbot   
2019-02-26 18:14   
Repository: tools/automation/pi-mobile
Changeset: 354f1a51416d2f5b8bcbd2a6aa2e53b0a0af4722
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Feb 26 18:13:06 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/354f1a51416d2f5b8bcbd2a6aa2e53b0a0af4722 [^]

Related to issue 40266: show running processes when a test fail because waitingForProcesses

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/javascript/MobileCoreAPI.java
---
(0110132)
migueldejuana   
2019-02-28 18:16   
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/479dedcf529c [^]
(0110133)
migueldejuana   
2019-02-28 18:17   
Tested and reviewed
(0110159)
hgbot   
2019-03-01 18:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7b277839e0521b775a5f6eb67b46769f98b4dc12
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Mar 01 18:37:09 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7b277839e0521b775a5f6eb67b46769f98b4dc12 [^]

Related to issue 40266: Added pause/resume of tapDoneButton process for aproval popup for underpayment

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0110700)
hgbot   
2019-03-27 16:12   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 22f1baee90be1c9bda4295d5361683780e709c17
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 14:24:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/22f1baee90be1c9bda4295d5361683780e709c17 [^]

Related to issue 40348. Backout of issue 40266. Remove retail process status feature

---
M web/org.openbravo.mobile.core/source/utils/ob-processcontroller.js
---
(0110702)
hgbot   
2019-03-27 16:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5de78866739b4a5dbe05bac59183d8d11c920f96
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Mar 26 14:33:43 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5de78866739b4a5dbe05bac59183d8d11c920f96 [^]

Related to issue 40348. Backout of issue 40266. Remove retail process status feature

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---