Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040262Retail ModulesWeb POSpublic2019-02-22 13:082019-04-26 11:29
anderaranguren 
rqueralta 
urgentmajoralways
closedfixed 
5
pi 
RR19Q3 
jorge-garcia
No
0040262: Preference "Do not allow Sales with return" does not work properly. The POS gets blocked after doing a Verified Return
If an order is returned with Verified Returns and tried adding a new line to the ticket a error message is being showed correctly.
But the POS gets blocked. Cannot click on delete button, paytotal button, cannot add more products correctly...
1. Go to Backoffice, Preference window
2. Add "Do not allow Sales with return" property, and set it to 'Y' for Vall Blanca User
3. Go to web POS terminal VBS-1
4. Add some products and click on return line --> it works fine.
5. Complete an order with Avalanche Transceiver
6. Go to the Verified Returns in the menu and select the last order
7. Return the line and try adding another product
8. The message is showing that you cannot add a positive line to the ticket --> well
9. But the POS gets blocked and you cannot keep working normally, you need a refresh
No tags attached.
has duplicate defect 0040546 closed rqueralta Tciket amount button in grey after try to add a positive line 
png POSerror.png (282,565) 2019-02-22 13:08
https://issues.openbravo.com/file_download.php?file_id=12679&type=bug
patch 40262_FinalPatch.patch (2,623) 2019-03-29 03:59
https://issues.openbravo.com/file_download.php?file_id=12806&type=bug
Issue History
2019-02-22 13:08anderarangurenNew Issue
2019-02-22 13:08anderarangurenAssigned To => Retail
2019-02-22 13:08anderarangurenFile Added: POSerror.png
2019-02-22 13:08anderarangurenResolution time => 1550185200
2019-02-22 13:08anderarangurenTriggers an Emergency Pack => No
2019-02-22 13:10PracticsIssue Monitored: Practics
2019-02-22 14:27anderarangurenResolution time1550185200 => 1552604400
2019-02-22 17:13rqueraltaAssigned ToRetail => rqueralta
2019-02-22 17:13rqueraltaStatusnew => scheduled
2019-03-19 19:42hgbotCheckin
2019-03-19 19:42hgbotNote Added: 0110500
2019-03-19 19:42hgbotStatusscheduled => resolved
2019-03-19 19:42hgbotResolutionopen => fixed
2019-03-19 19:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/495aa374009b7c2c61f1b4f07a44be6198fd2599 [^]
2019-03-22 17:01hgbotCheckin
2019-03-22 17:01hgbotNote Added: 0110593
2019-03-25 17:19hgbotCheckin
2019-03-25 17:19hgbotNote Added: 0110626
2019-03-25 17:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/495aa374009b7c2c61f1b4f07a44be6198fd2599 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9037c26d91c4707793b939a6282366f216931e66 [^]
2019-03-27 18:10hgbotCheckin
2019-03-27 18:10hgbotNote Added: 0110707
2019-03-27 18:22rqueraltaStatusresolved => new
2019-03-27 18:22rqueraltaResolutionfixed => open
2019-03-28 13:33rqueraltaStatusnew => scheduled
2019-03-28 18:30hgbotCheckin
2019-03-28 18:30hgbotNote Added: 0110902
2019-03-29 03:59rqueraltaFile Added: 40262_FinalPatch.patch
2019-04-05 14:39hgbotCheckin
2019-04-05 14:39hgbotNote Added: 0111002
2019-04-05 14:39hgbotStatusscheduled => resolved
2019-04-05 14:39hgbotResolutionopen => fixed
2019-04-05 14:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9037c26d91c4707793b939a6282366f216931e66 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cefa717496c6cb7c0fe884a24d05b2e4f9044fe [^]
2019-04-08 11:35jorge-garciaReview Assigned To => jorge-garcia
2019-04-08 15:15jorge-garciaNote Added: 0111024
2019-04-08 15:15jorge-garciaStatusresolved => new
2019-04-08 15:15jorge-garciaResolutionfixed => open
2019-04-09 12:34hgbotCheckin
2019-04-09 12:34hgbotNote Added: 0111040
2019-04-09 12:34hgbotStatusnew => resolved
2019-04-09 12:34hgbotResolutionopen => fixed
2019-04-09 12:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cefa717496c6cb7c0fe884a24d05b2e4f9044fe [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9c66254235c7c525ba5d201d009d6e763f8c7d53 [^]
2019-04-26 11:28jorge-garciaNote Added: 0111357
2019-04-26 11:29jorge-garciaNote Added: 0111359
2019-04-26 11:29jorge-garciaStatusresolved => closed
2019-04-26 11:29jorge-garciaFixed in Version => RR19Q3
2019-05-06 19:06marvintmRelationship addedhas duplicate 0040546

Notes
(0110500)
hgbot   
2019-03-19 19:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 495aa374009b7c2c61f1b4f07a44be6198fd2599
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 18 15:52:43 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/495aa374009b7c2c61f1b4f07a44be6198fd2599 [^]

Fixed issue 40262: Preference "Do not allow Sales with return" does not work
properly. The POS gets blocked after doing a Verified Return

- Removed addProcess into the receipt and finish 'addProduct' process controler,
to avoid the WEB Pos get blocked after doing a Verified Return

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110593)
hgbot   
2019-03-22 17:01   
Repository: tools/automation/pi-mobile
Changeset: 35c6bbc29db7d1e1cb277e948114765c581908c1
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Mar 19 15:32:52 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/35c6bbc29db7d1e1cb277e948114765c581908c1 [^]

Related to issue 40262: added automated test

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I40262_VerifyPOSNotBlockedAfterVerifiedReturn.java
---
(0110626)
hgbot   
2019-03-25 17:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9037c26d91c4707793b939a6282366f216931e66
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Mar 25 12:17:45 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9037c26d91c4707793b939a6282366f216931e66 [^]

Fixed issue 40262: Preference "Do not allow Sales with return" does not work
properly. The POS gets blocked after doing a Verified Return

- Seted addProcess var to "{}" instead "null"

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110707)
hgbot   
2019-03-27 18:10   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f7b0766874652bf1c0852bdcad30ebb1b12263f2
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Mar 27 12:27:31 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f7b0766874652bf1c0852bdcad30ebb1b12263f2 [^]

Related to issue 40348. Backout of issue 40262. ProcessController.getProcessesRunning no longer exists

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0110902)
hgbot   
2019-03-28 18:30   
Repository: tools/automation/pi-mobile
Changeset: bf607b62218ac138b6f7507d620666666f1e04a7
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Mar 28 18:30:36 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bf607b62218ac138b6f7507d620666666f1e04a7 [^]

Related to 40262: Disable test I40262_VerifyPOSNotBlockedAfterVerifiedReturn till issue 40262 is fixed

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I40262_VerifyPOSNotBlockedAfterVerifiedReturn.java
---
(0111002)
hgbot   
2019-04-05 14:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9cefa717496c6cb7c0fe884a24d05b2e4f9044fe
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Mar 28 14:11:46 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9cefa717496c6cb7c0fe884a24d05b2e4f9044fe [^]

Fixed issue 40262: Preference "Do not allow Sales with return" does not work
properly. The POS gets blocked after doing a Verified Return

- Seted addProcess to "{}" value and finish "addProduct" process controler to
avoid the WEB Pos get blocked after doing a Verified Return

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111024)
jorge-garcia   
2019-04-08 15:15   
Test id failing in try-retail.

Maybe it is a better solution to pass a cancelCallback instead of the xecution of the process in order to cancel the process of addproduct
(0111040)
hgbot   
2019-04-09 12:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9c66254235c7c525ba5d201d009d6e763f8c7d53
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Apr 08 12:55:32 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9c66254235c7c525ba5d201d009d6e763f8c7d53 [^]

Fixed issue 40262: Preference "Do not allow Sales with return" does not work
properly. The POS gets blocked after doing a Verified Return

- Added cancelCallback function instead use the execution of the process in
order to cancel the process of addproduct

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0111357)
jorge-garcia   
2019-04-26 11:28   
Wrong issue number.

This commit[1] should be included in this issue

[1]https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b51923823eec78e1ecc2d6da27df45a1749fee2 [^]
(0111359)
jorge-garcia   
2019-04-26 11:29   
Code reviewed and tested