Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040251Retail ModulesGift cards and gift voucherspublic2019-02-21 10:482019-03-01 09:48
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040251: Cancelled field is not set to Y when launching the Cancel Gift Card process in Gift Card Instance window
DescriptionCancelled field is not set to Y when launching the Cancel Gift Card process in Gift Card Instance window
Steps To ReproduceIn the backend:
   Configure the terminal to accept Credit Notes:
      http://wiki.openbravo.com/wiki/Retail:Gift_Cards/CreditNotes [^]

In the POS:
   Create a new ticket
   Add a line to it
   Return the line
   Pay the ticket with Credit Note payment method

In the backoffice:
   Go to Gift Card Instance window and select the record that has been created
   Launch the Cancel Gift Card process
   Check the Gift Card status is Changed to Closed but the Cancelled field remains as N
Proposed SolutionThe process is setting to true the column of the cancel button instead of the cancelled flag (CancelGiftCardProcessHandler.java)

terminal.setCancelGiftCard(true);
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040252 closed ranjith_qualiantech_com Cannot cancel a gift card instance if it does not include a payment 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-21 10:48ngarciaNew Issue
2019-02-21 10:48ngarciaAssigned To => Retail
2019-02-21 10:48ngarciaResolution time => 1552518000
2019-02-21 10:48ngarciaTriggers an Emergency Pack => No
2019-02-21 10:48ngarciaIssue Monitored: networkb
2019-02-21 10:55ngarciaProposed Solution updated
2019-02-21 11:06rafarodaIssue Monitored: rafaroda
2019-02-21 12:37rafarodaRelationship addedrelated to 0040252
2019-02-21 14:33ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-02-21 15:06hgbotCheckin
2019-02-21 15:06hgbotNote Added: 0109986
2019-02-21 15:06hgbotStatusnew => resolved
2019-02-21 15:06hgbotResolutionopen => fixed
2019-02-21 15:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/0d826884800fe2c5f68191b3f1eaf3e7b203522b [^]
2019-03-01 09:48marvintmReview Assigned To => marvintm
2019-03-01 09:48marvintmStatusresolved => closed
2019-03-01 09:48marvintmFixed in Version => RR19Q2

Notes
(0109986)
hgbot   
2019-02-21 15:06   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 0d826884800fe2c5f68191b3f1eaf3e7b203522b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 21 19:36:17 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/0d826884800fe2c5f68191b3f1eaf3e7b203522b [^]

Fixed issue 40251 : GiftCard Instance should be updated with cancelled status when cancelling in Backoffice

---
M src/org/openbravo/retail/giftcards/process/CancelGiftCardProcessHandler.java
---