Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040219Retail ModulesStoreServerpublic2019-02-15 12:072019-03-14 18:07
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040219: Simplify check on offline with sync errors or delta age, show delta age in mobile server
DescriptionThe current logic keeps track if when the store goes offline there are two cases:
- incoming errors
- age of the incoming batch is too old (expired)

This is done with two flags in the mobile server definition [1]. But there is also the check when going offline that neither of the two cases is allowed [2]. So offline is prevented in this case. So logically the flags are never set to true as the store does not offline in these cases.

Other change: would be good to show the delta age in the mobile server window.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java#l100 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java#l124 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java#l40 [^]
Steps To Reproducerun multi-server
create incoming error
stop central
store does not go offline and extra flags/checks are not needed
Proposed SolutionRemove the code here remove the flags from the table
https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java#l100 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java#l124 [^]
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0040287 closed mtaal API Change due to removal of internal/technical column in mobile server definition 
Attached Filesdiff 40219-mobile-core.diff (16,257) 2019-02-18 18:12
https://issues.openbravo.com/file_download.php?file_id=12669&type=bug
diff 40219-retail-sync.diff (9,309) 2019-02-18 18:12
https://issues.openbravo.com/file_download.php?file_id=12670&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-15 12:07mtaalNew Issue
2019-02-15 12:07mtaalAssigned To => mtaal
2019-02-15 12:07mtaalTriggers an Emergency Pack => No
2019-02-18 18:12mtaalFile Added: 40219-mobile-core.diff
2019-02-18 18:12mtaalFile Added: 40219-retail-sync.diff
2019-02-18 18:31mtaalReview Assigned To => AugustoMauch
2019-03-04 15:21hgbotCheckin
2019-03-04 15:21hgbotNote Added: 0110196
2019-03-04 15:25mtaalRelationship addedblocks 0040287
2019-03-04 15:32hgbotCheckin
2019-03-04 15:32hgbotNote Added: 0110200
2019-03-04 15:32hgbotStatusnew => resolved
2019-03-04 15:32hgbotResolutionopen => fixed
2019-03-04 15:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4bee8fab73a2788d5649955574c368628d1a6245 [^]
2019-03-11 17:01AugustoMauchNote Added: 0110356
2019-03-11 17:01AugustoMauchStatusresolved => new
2019-03-11 17:01AugustoMauchResolutionfixed => open
2019-03-11 20:56hgbotCheckin
2019-03-11 20:56hgbotNote Added: 0110359
2019-03-11 20:56hgbotStatusnew => resolved
2019-03-11 20:56hgbotResolutionopen => fixed
2019-03-11 20:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4bee8fab73a2788d5649955574c368628d1a6245 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/6852a2e09533deebb29983424bbf458ef01528f2 [^]
2019-03-14 18:07AugustoMauchNote Added: 0110447
2019-03-14 18:07AugustoMauchStatusresolved => closed

Notes
(0110196)
hgbot   
2019-03-04 15:21   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: a9c1492b139dd1580d1ce4cb145f29e62d6d77f4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 15:15:32 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/a9c1492b139dd1580d1ce4cb145f29e62d6d77f4 [^]

Related to issue 40219: Simplify check on offline with sync errors or delta age, show delta age in mobile server
Remove the two 'flag' columns and add a field to show delta age in mobile server window

---
M src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0110200)
hgbot   
2019-03-04 15:32   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 4bee8fab73a2788d5649955574c368628d1a6245
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 04 15:32:26 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4bee8fab73a2788d5649955574c368628d1a6245 [^]

Fixes issue 40219: Simplify check on offline with sync errors or delta age, show delta age in mobile server
Remove the usage of the incoming error and delta-sync-error flag columns in the mobile server definition.

---
M src-db/database/sourcedata/STRSYNC_EXCLUDEDCOL.xml
M src/org/openbravo/retail/storeserver/synchronization/RetailSynchronizationRequestHandler.java
M src/org/openbravo/retail/storeserver/synchronization/StoreServerTransitionToOfflineExternalHandler.java
M src/org/openbravo/retail/storeserver/synchronization/eventhandler/MobileServerEventHandler.java
---
(0110356)
AugustoMauch   
2019-03-11 17:01   
The clean in the js for the management of the INVALID_OFFLINE error is missing
(0110359)
hgbot   
2019-03-11 20:56   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 6852a2e09533deebb29983424bbf458ef01528f2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 11 20:56:52 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/6852a2e09533deebb29983424bbf458ef01528f2 [^]

Fixes issue 40219: Simplify check on offline with sync errors or delta age, show delta age in mobile server
Remove not needed jscript and messages

---
M src-db/database/sourcedata/AD_MESSAGE.xml
R web/org.openbravo.retail.storeserver.synchronization/js/responseCallbackHandler.js
---
(0110447)
AugustoMauch   
2019-03-14 18:07   
Code reviewed and verified