Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040218Retail ModulesWeb POSpublic2019-02-07 20:282019-02-18 13:41
lbressan 
ranjith_qualiantech_com 
immediatemajoralways
closedfixed 
5
 
RR18Q3.5RR18Q3.5 
marvintm
Production - QA Approved
2018-09-20
RR18Q4
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41997a1342f0#l3.7 [^]
No
0040218: Total button stays disabled when creating canceling PreOrderSave hook for quotations.
This only happen for quotations:
When there is a hook implemented for OBPOS_PreOrderSave, and this hook cancels the operation for some reason (via the cancellation property in arguments), the ticket total button stays disabled.
This also was working properly until release 18Q2.4.

It seems that the change to Process Controller is causing the issue, and the button is not receiving an event to be enabled properly.
This in 18Q2.4 was handled by the synchronizing and synchronized events in the OB.OBPOSPointOfSale.UI.ButtonTabPayment kind.
1. Log in to POS
2. Create a quotation via the menu
3. Add any product.
4. Open developer console
5. In console, create a hook that cancels the operation:
OB.UTIL.HookManager.registerHook('OBPOS_PreOrderSave', function(a,b){
  OB.UTIL.showError("error");
  a.cancellation = true;
  OB.UTIL.HookManager.callbackExecutor(a,b);
})
6. Click the total button.
7. The total button is now greyed out and can only be restored by switching to another ticket.
No tags attached.
blocks defect 0040173 closed ranjith_qualiantech_com Total button stays disabled when creating canceling PreOrderSave hook for quotations. 
Issue History
2019-02-15 11:50ranjith_qualiantech_comTypedefect => backport
2019-02-15 11:50ranjith_qualiantech_comTarget Version => RR18Q3.5
2019-02-18 09:09hgbotCheckin
2019-02-18 09:09hgbotNote Added: 0109889
2019-02-18 09:09hgbotStatusscheduled => resolved
2019-02-18 09:09hgbotResolutionopen => fixed
2019-02-18 09:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2554e0624310dc62913b3d45908a4b7e1181a1a5 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal/rev/561bd8004e2dda73e24af9baef8e415cbc192fda [^]
2019-02-18 13:41marvintmReview Assigned To => marvintm
2019-02-18 13:41marvintmStatusresolved => closed
2019-02-18 13:41marvintmFixed in Version => RR18Q3.5

Notes
(0109889)
hgbot   
2019-02-18 09:09   
Repository: retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal
Changeset: 561bd8004e2dda73e24af9baef8e415cbc192fda
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 18 13:39:15 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal/rev/561bd8004e2dda73e24af9baef8e415cbc192fda [^]

Fixed issue 40218 : Implemented ProcessController when closing quotations

* Refactored Quotation close callback
  1) If receipt callback is cancelled, then quotation should not be printed

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---