Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040189ModulesAdvanced Matching Algorithmpublic2019-02-13 10:082019-02-14 10:57
ReporterLeyre 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.module.invoicematchingalgorithm/rev/aecbf237ba4b [^]
Regression levelProduction - Confirmed Stable
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040189: Error in query when launching Match Statement
DescriptionError in query when launching Match Statement

Steps To Reproduce1. Apply module's dataset.

2. Go to a Financial Account and set Advanced Matching Algorithm as Matching Algorithm.

3. Create a new record in Bank statement, add a bank statement line with a business partner and process.

4. Create a new transaction in the same financial account: set the same amount but a different business partner and process it.

5. Launch the Match Statement process and select the option to launch the algorithm automatically.

** Check an error is shown in the log
Proposed SolutionIssue: https://issues.openbravo.com/view.php?id=38382 [^]

Changeset: https://code.openbravo.com/erp/pmods/org.openbravo.module.invoicematchingalgorithm/rev/aecbf237ba4be73c51ff7b0e0c4defc44f51080b [^]

It added a line:
+ whereClause.append(" = :amout");

Instead:
+ whereClause.append(" = :amount");
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0038382 closed caristu Openbravo ERP Deprecate usage of positional query parameters in OBQuery 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-13 10:08LeyreNew Issue
2019-02-13 10:08LeyreAssigned To => Triage Finance
2019-02-13 10:08LeyreResolution time => 1550444400
2019-02-13 10:13LeyreSummaryError in the field "amount" => Error in query when launching Match Statement
2019-02-13 10:13LeyreDescription Updatedbug_revision_view_page.php?rev_id=18308#r18308
2019-02-13 13:24SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-02-13 13:34SandrahuguetAssigned ToAtulOpenbravo => markmm82
2019-02-13 16:45LeyreResolution time1550444400 => 1551826800
2019-02-14 00:16markmm82Statusnew => acknowledged
2019-02-14 03:00markmm82Relationship addedcaused by 0038382
2019-02-14 03:01markmm82Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.module.invoicematchingalgorithm/rev/aecbf237ba4b [^]
2019-02-14 03:45markmm82Statusacknowledged => scheduled
2019-02-14 03:46markmm82Note Added: 0109815
2019-02-14 10:21SandrahuguetRegression level => Production - Confirmed Stable
2019-02-14 10:56hgbotCheckin
2019-02-14 10:56hgbotNote Added: 0109826
2019-02-14 10:56hgbotStatusscheduled => resolved
2019-02-14 10:56hgbotResolutionopen => fixed
2019-02-14 10:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicematchingalgorithm/rev/927330ab5ee4cb9e1bbc8ad949dbb573de04301e [^]
2019-02-14 10:57SandrahuguetReview Assigned To => Sandrahuguet
2019-02-14 10:57SandrahuguetNote Added: 0109827
2019-02-14 10:57SandrahuguetStatusresolved => closed

Notes
(0109815)
markmm82   
2019-02-14 03:46   
Test Plan:
1. Apply module's dataset.

2. Go to a Financial Account and set Advanced Matching Algorithm as Matching Algorithm.

3. Create a new record in Bank statement, add a bank statement line with a business partner and process.

4. Create a new transaction in the same financial account: set the same amount but a different business partner and process it.

5. Launch the Match Statement process and select the option to launch the algorithm automatically.
  Notice that transaction and bank statement ahve been matched automatically.
(0109826)
hgbot   
2019-02-14 10:56   
Repository: erp/pmods/org.openbravo.module.invoicematchingalgorithm
Changeset: 927330ab5ee4cb9e1bbc8ad949dbb573de04301e
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Wed Feb 13 23:46:32 2019 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicematchingalgorithm/rev/927330ab5ee4cb9e1bbc8ad949dbb573de04301e [^]

Fixes issue 40189: Error in query when launching Match Statement

The named parameter "amount" was incorrect defined

---
M src/org/openbravo/module/invoicematchingalgorithm/algorithm/InvoiceMatchingAlgorithm.java
---
(0109827)
Sandrahuguet   
2019-02-14 10:57   
Code review + testing OK