Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040187Openbravo ERPY. DBSourceManagerpublic2019-02-12 19:132019-03-28 14:56
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2019-02-01
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/dbsm-main/rev/3dc03f579c070c8b4fb62a9ca059bf632f02f513 [^]
Triggers an Emergency PackNo
Summary0040187: export.database gets stuck using old pool
Descriptionexport.database task gets stuck using old pool
Steps To Reproduce1) Go to Openbravo.properties and disable the usage of the TomcatPool:

db.externalPoolClassName=

2) Run ant export.database

Note that the task is never ending
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0039128 closed caristu ant compile.apply.module task gets stuck when updating from 2.50 to pi 
caused by defect 0040047 closed caristu Fix database export to avoid manually copying wstx-asl-3.0.2.jar inside Ant folder 
related to feature request 0040552 closed caristu upgrade hibernate to version 5.4 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-12 19:13caristuNew Issue
2019-02-12 19:13caristuAssigned To => caristu
2019-02-12 19:13caristuModules => Core
2019-02-12 19:13caristuTriggers an Emergency Pack => No
2019-02-12 19:14caristuRelationship addedcaused by 0040047
2019-02-12 19:20caristuRegression level => Pre packaging ( pi )
2019-02-12 19:20caristuRegression date => 2019-02-01
2019-02-12 19:20caristuRegression introduced in release => pi
2019-02-12 19:20caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/dbsm-main/rev/3dc03f579c070c8b4fb62a9ca059bf632f02f513 [^]
2019-02-12 19:20caristuRelationship addedrelated to 0039128
2019-02-13 16:38hgbotCheckin
2019-02-13 16:38hgbotNote Added: 0109808
2019-02-13 16:38hgbotStatusnew => resolved
2019-02-13 16:38hgbotResolutionopen => fixed
2019-02-13 16:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/8fd656b227b899296c6c3017dc3aa4efc1ded096 [^]
2019-02-13 16:39hgbotCheckin
2019-02-13 16:39hgbotNote Added: 0109809
2019-02-13 16:46caristuReview Assigned To => alostale
2019-02-15 11:05alostaleNote Added: 0109856
2019-02-15 11:05alostaleStatusresolved => closed
2019-02-15 11:05alostaleFixed in Version => 3.0PR19Q2
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110809
2019-04-09 17:57caristuRelationship addedrelated to 0040552

Notes
(0109808)
hgbot   
2019-02-13 16:38   
Repository: erp/devel/dbsm-main
Changeset: 8fd656b227b899296c6c3017dc3aa4efc1ded096
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 13 16:05:13 2019 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/8fd656b227b899296c6c3017dc3aa4efc1ded096 [^]

fixes issue 40187: export.database gets stuck using old pool

  When the Hibernate pool is used to handle the DB connections of the export.databas task, the JVM is not able to terminate the task because that pool uses a non-daemon thread to validate its status. This happens starting from the changes introduced to execute the export.database using a forked task[1].

  To fix this issue we force the stopping of the thread by explicitly closing the Hibernate pool.

  [1] https://code.openbravo.com/erp/devel/dbsm-main/rev/3dc03f579c070c8b4fb62a9ca059bf632f02f513 [^]

---
M src/org/openbravo/ddlutils/task/ExportDatabase.java
---
(0109809)
hgbot   
2019-02-13 16:39   
Repository: erp/devel/pi
Changeset: f4bdb985e3563e554c1bd4e0a367de97db7e0387
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Feb 13 16:38:42 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f4bdb985e3563e554c1bd4e0a367de97db7e0387 [^]

related to issue 40187: update DBSM jar

---
M src-db/database/lib/dbsourcemanager.jar
---
(0109856)
alostale   
2019-02-15 11:05   
reviewed + tested
(0110809)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test