Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040186Openbravo ERP03. Procurement managementpublic2019-02-12 18:062019-03-28 14:56
francisco 
markmm82 
highmajoralways
closedfixed 
5
 
3.0PR19Q2 
dmiguelez
Core
No
0040186: Pending Goods receipts with movement quantity=0
When a new purchase order line is created , if the order quantity has 3 decimals
there is a bug that in the window Pending Goods Receipts, when is process the order, the order remain in that window with the "Movement Quantity" 0.00.
1. In Purchase Order windows, create a line with "Order Quantity" with 3 decimals (3rd decimal minor than 5).
2. Book the order.
3. Go to Pending Goods Receipts windows and process the order
4. when refresh the window the order is still there, but with "Movement Quantity" 0.
5. If the 3rd decimal is mayor than 5. The order is still not completely delivered, but is not apparent in Pending Goods Receipts.
    * It can be seen from "Create Lines From" in Goods Receipt window.
No tags attached.
Issue History
2019-02-12 18:06franciscoNew Issue
2019-02-12 18:06franciscoAssigned To => Triage Finance
2019-02-12 18:06franciscoModules => Core
2019-02-12 18:06franciscoResolution time => 1551740400
2019-02-12 18:06franciscoTriggers an Emergency Pack => No
2019-03-05 12:41franciscoResolution time1551740400 => 1553554800
2019-03-05 12:41franciscoTypedesign defect => defect
2019-03-06 10:13SandrahuguetAssigned ToTriage Finance => markmm82
2019-03-13 02:28markmm82Statusnew => scheduled
2019-03-13 16:46markmm82Note Added: 0110419
2019-03-13 16:46markmm82Statusscheduled => feedback
2019-03-14 14:14markmm82Note Edited: 0110419bug_revision_view_page.php?bugnote_id=0110419#r18467
2019-03-19 17:30markmm82Note Deleted: 0110419
2019-03-19 17:52markmm82Note Added: 0110495
2019-03-19 17:53markmm82Statusfeedback => scheduled
2019-03-21 17:23hgbotCheckin
2019-03-21 17:23hgbotNote Added: 0110552
2019-03-21 17:23hgbotStatusscheduled => resolved
2019-03-21 17:23hgbotResolutionopen => fixed
2019-03-21 17:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/073b1b33016cc3c31afe0700422eb041dc1fdf5b [^]
2019-03-21 17:23hgbotCheckin
2019-03-21 17:23hgbotNote Added: 0110553
2019-03-21 17:23dmiguelezReview Assigned To => dmiguelez
2019-03-21 17:23dmiguelezNote Added: 0110554
2019-03-21 17:23dmiguelezStatusresolved => closed
2019-03-21 17:23dmiguelezFixed in Version => 3.0PR19Q2
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110879
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110880

Notes
(0110495)
markmm82   
2019-03-19 17:52   
Test Plan:
Verify you have defined the "qtyEdition" property to accept 3 decimals in the Format.xml configuration file.
  <Number name="qtyEdition" decimal="." grouping="," formatOutput="#0.###" formatInternal="#0.000" />
As System Admin:
  Check that Purchase Order - Ordered Quantity field/column is defined with a "Quantity" reference. Same for Goods Receipt - Movement Quantity field/column. This reference is implemented to read settings from the "qtyEdition" property.
  Notice that these fields are shown with 3 decimals of precision in both windows.

As Group Admin:
  Create a new Purchase Order:
    Organization: F&B España - Región Norte
    Business Partner: Refrescos Naturales, S.A.

  Add a new line with the following information:
    Product: Limonada 0,5L
    Ordered Quantity: 25.112
    Net Unit Price: 0.55

  Book it.

  Go to Goods Receipt Window and create a new header for the same organization and business partner.
  Execute the "Create Lines From" process.
  Select the previously created order.
  Notice that the line of the order is shown with the same quantity as it was created: 25.112 (without rounding it).
  Select the line and any storage bin.
  OK.
  Notice a new line is created to the Good Receipt with 25.112 as it movement quantity (without rounding it).
  DO NOT complete the document and remove the line from it.

  Go to Pending Goods Receipts process.
  Search by the Business Partner and Organization used in the created Purchase Order.
  Notice that the line of the created order is there.
  Notice it is showing the original ordered quantity without any other rounding: 25.112.
  Select the line, any reception adate and warehouse and Process.
  Notice the process ends successfully and a new Goods Receipt is created with a line with 25.112 as it movement quantity.

  Refresh the Pending Goods Receipts window and notice that the line of the previously created order is not there anymore.
(0110552)
hgbot   
2019-03-21 17:23   
Repository: erp/devel/pi
Changeset: 073b1b33016cc3c31afe0700422eb041dc1fdf5b
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Tue Mar 19 14:08:33 2019 -0300
URL: http://code.openbravo.com/erp/devel/pi/rev/073b1b33016cc3c31afe0700422eb041dc1fdf5b [^]

Fixes issue 40186: Pending Goods receipts with movement quantity=0

The fieldTotalQty and fieldQtyordered fields were incorrect defined to use "euroEdition"
instead of "qtyEdition".
Columns for Ordered Quantity and Movement Quantity of the lines of Purchase Order and Goods Receipt
windows are defined with a "Quantity" reference and it is implemented internally to
format the values using the "qtyEdition" setting.
To do more homogeneous the way the quantities are shown in the process and in the different
windows, all of them will be formatted by the same way: using settings of qtyEdition property.

---
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.xml
---
(0110553)
hgbot   
2019-03-21 17:23   
Repository: erp/devel/pi
Changeset: edd10a6633c63facc951664961b8f94b77b36195
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Mar 21 17:15:46 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/edd10a6633c63facc951664961b8f94b77b36195 [^]

Related to Issue 40186: Replaced euroEdition with qtyEdition for two
more quantity fields.

---
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.xml
---
(0110554)
dmiguelez   
2019-03-21 17:23   
Code Review + Testing Ok
(0110879)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110880)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test