0004018: ad_column_identifier don't work in c_location with locations without region selected

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0004018

Openbravo ERP

02. Master data management

public

2008-06-17 13:47

2008-12-12 17:51

Reporter

malsasua

Assigned To

cromero

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.35

Target Version

Fixed in Version

2.35MP10

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0004018: ad_column_identifier don't work in c_location with locations without region selected

Description

In this locations, function returns null.

The problem is in function ad_column_identifier_ref_sql because it return wrong sql.
The sql returned is :
SELECT COALESCE(TO_CHAR(T.Address1), ' ')||' - '||
       COALESCE(TO_CHAR(T.Address2), ' ')||' - '||
       COALESCE(TO_CHAR(T.Postal), ' ')||' - '||
       COALESCE(TO_CHAR(T.City), ' ')||' - '||
       (SELECT COALESCE(TO_CHAR(TT.Name), ' ')
        FROM C_Region TT
        WHERE TT.C_Region_ID=T.C_Region_ID) ||' - '||
      (SELECT (SELECT COALESCE(TO_CHAR(MAX(TTT.Name)), TO_CHAR(TT.Name))
               FROM C_Country_Trl TTT
               WHERE TTT.C_Country_ID=TT.C_Country_ID
               AND TTT.AD_LANGUAGE=L.AD_LANGUAGE)
      FROM C_Country TT
      WHERE TT.C_Country_ID=T.C_Country_ID) ||' - '||
      COALESCE(TO_CHAR(T.IsActive), ' ') AS COLUMN_IDENTIFIER
FROM (SELECT AD_LANGUAGE FROM AD_LANGUAGE WHERE AD_LANGUAGE='es_ES') L, C_Location T
WHERE C_Location_Id=:c_ID

A example of correct sql is:
SELECT TO_CHAR(COALESCE(TO_CHAR(T.Address1),''))||' - '|| TO_CHAR(COALESCE(TO_CHAR(T.Address2),''))||' - '|| TO_CHAR(COALESCE(TO_CHAR(T.Postal),''))||' - '|| TO_CHAR(COALESCE(TO_CHAR(T.City),''))||' - '||
CASE WHEN (SELECT COALESCE(TO_CHAR(TT.Name), ' ')
           FROM C_Region TT WHERE TT.C_Region_ID=T.C_Region_ID)
     IS NULL THEN
           ' '
     ELSE (SELECT COALESCE(TO_CHAR(TT.Name), ' ')
            FROM C_Region TT WHERE TT.C_Region_ID=T.C_Region_ID) END ||' - ' || (SELECT (SELECT COALESCE(TO_CHAR(MAX(TTT.Name)), TO_CHAR(TT.Name))
FROM C_Country_Trl TTT
WHERE TTT.C_Country_ID=TT.C_Country_ID
AND TTT.AD_LANGUAGE=L.AD_LANGUAGE)
FROM C_Country TT WHERE TT.C_Country_ID=T.C_Country_ID)
||' - '||TO_CHAR(COALESCE(TO_CHAR(T.IsActive),'')) AS COLUMN_IDENTIFIER
FROM (SELECT AD_LANGUAGE FROM AD_LANGUAGE WHERE AD_LANGUAGE=:c_language) L, C_Location T WHERE C_Location_ID=:c_ID

Steps To Reproduce

Proposed Solution

Additional Information