Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040174Retail ModulesWeb POSpublic2019-02-09 18:222019-04-02 17:33
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionpiFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040174: Upload data: product into discount, business partner set, import bp into bp set, set bp-set in discount, load in webpos
DescriptionSee page here:
http://wiki.openbravo.com/wiki/Projects/Upload_Data [^]
Steps To ReproduceSee description
Proposed SolutionSee Description.

Documentation added (in temporary location)
http://wiki.openbravo.com/wiki/Retail:Temp_Docs_Upload [^]
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 40174-erp-5.diff (314,530) 2019-03-05 12:10
https://issues.openbravo.com/file_download.php?file_id=12707&type=bug
png iconButton-import.png (599) 2019-03-05 12:10
https://issues.openbravo.com/file_download.php?file_id=12708&type=bug
png

diff 40174-retail-6.diff (17,409) 2019-03-05 21:59
https://issues.openbravo.com/file_download.php?file_id=12711&type=bug
diff 40174-sample-data-2.diff (21,917) 2019-03-06 09:04
https://issues.openbravo.com/file_download.php?file_id=12713&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-02-09 18:22mtaalNew Issue
2019-02-09 18:22mtaalAssigned To => mtaal
2019-02-09 18:22mtaalTriggers an Emergency Pack => No
2019-02-16 19:34mtaalFile Added: org.openbravo.module.uploaddata.zip
2019-02-16 19:34mtaalFile Added: bp-set.diff
2019-02-16 19:35mtaalSummaryCreate concept of business partner set, link to discount and support of import of business partners => Upload data: product into discount, business partner set, import bp into bp set, set bp-set in discount, load in webpos
2019-02-16 19:35mtaalDescription Updatedbug_revision_view_page.php?rev_id=18338#r18338
2019-02-24 21:09mtaalFile Deleted: org.openbravo.module.uploaddata.zip
2019-02-24 21:09mtaalFile Deleted: bp-set.diff
2019-02-24 21:09mtaalFile Added: 40174-pos-retail.diff
2019-02-24 21:09mtaalFile Added: 40174.diff
2019-02-24 21:10mtaalNote Added: 0110042
2019-03-04 16:38mtaalFile Deleted: 40174-pos-retail.diff
2019-03-04 16:38mtaalFile Deleted: 40174.diff
2019-03-04 16:41mtaalFile Added: 40174-retail-4.diff
2019-03-04 16:42mtaalFile Added: 40174-core-4.diff
2019-03-05 12:09mtaalFile Deleted: 40174-retail-4.diff
2019-03-05 12:09mtaalFile Deleted: 40174-core-4.diff
2019-03-05 12:10mtaalFile Added: 40174-retail-5.diff
2019-03-05 12:10mtaalFile Added: 40174-erp-5.diff
2019-03-05 12:10mtaalFile Added: iconButton-import.png
2019-03-05 12:15mtaalFile Added: 40174-sample-data.diff
2019-03-05 21:59mtaalFile Deleted: 40174-retail-5.diff
2019-03-05 21:59mtaalFile Deleted: 40174-sample-data.diff
2019-03-05 21:59mtaalFile Added: 40174-retail-6.diff
2019-03-05 21:59mtaalFile Added: 40174-sample-data-moffer.diff
2019-03-06 09:04mtaalFile Deleted: 40174-sample-data-moffer.diff
2019-03-06 09:04mtaalFile Added: 40174-sample-data-2.diff
2019-03-06 10:47mtaalNote Added: 0110250
2019-03-06 10:47mtaalProposed Solution updated
2019-03-08 22:55hgbotCheckin
2019-03-08 22:55hgbotNote Added: 0110328
2019-03-08 22:55hgbotStatusnew => resolved
2019-03-08 22:55hgbotResolutionopen => fixed
2019-03-08 22:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed816a12b6f14726eef1a741f2212322b4ffb622 [^]
2019-03-08 22:57hgbotCheckin
2019-03-08 22:57hgbotNote Added: 0110329
2019-03-11 08:53hgbotCheckin
2019-03-11 08:53hgbotNote Added: 0110334
2019-03-11 21:01mtaalReview Assigned To => jorge-garcia
2019-03-12 08:57hgbotCheckin
2019-03-12 08:57hgbotNote Added: 0110372
2019-03-12 21:12hgbotCheckin
2019-03-12 21:12hgbotNote Added: 0110393
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110861
2019-03-28 22:32hgbotCheckin
2019-03-28 22:32hgbotNote Added: 0110906
2019-03-28 22:34hgbotCheckin
2019-03-28 22:34hgbotNote Added: 0110907
2019-03-29 07:14hudsonbotCheckin
2019-03-29 07:14hudsonbotNote Added: 0110910
2019-03-29 10:56hgbotCheckin
2019-03-29 10:56hgbotNote Added: 0110920
2019-04-01 07:56hgbotCheckin
2019-04-01 07:56hgbotNote Added: 0110937
2019-04-02 17:33jorge-garciaNote Added: 0110968
2019-04-02 17:33jorge-garciaStatusresolved => closed
2019-04-02 17:33jorge-garciaFixed in Version => RR19Q2

Notes
(0110042)
mtaal   
2019-02-24 21:10   
Test scenarios
https://docs.google.com/spreadsheets/d/1AJEzj3A2k4OOVLRyA6gtfsM91yZ58sGQH7c_ZHnBhg4/edit?usp=sharing [^]
(0110250)
mtaal   
2019-03-06 10:47   
Documentation added (in temporary location)
http://wiki.openbravo.com/wiki/Retail:Temp_Docs_Upload [^]
(0110328)
hgbot   
2019-03-08 22:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ed816a12b6f14726eef1a741f2212322b4ffb622
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Mar 08 22:52:05 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed816a12b6f14726eef1a741f2212322b4ffb622 [^]

Fixes issue 40174: Upload data: product into discount, business partner set, import bp into bp set, set bp-set in discount, load in webpos
Load the bpset in webpos, also for discounts, use the bp-select definition in discounts

---
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/model/discounts.js
M web/org.openbravo.retail.posterminal/js/model/executor.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
A src/org/openbravo/retail/posterminal/master/BPSetLine.java
A src/org/openbravo/retail/posterminal/master/DiscountBusinessPartnerSet.java
A web/org.openbravo.retail.posterminal/js/model/bpartnerset.js
A web/org.openbravo.retail.posterminal/js/model/discountset.js
---
(0110329)
hgbot   
2019-03-08 22:57   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: c23cc88ff68cfb78646e402e39a69bf28b42b27a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Mar 08 22:56:57 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/c23cc88ff68cfb78646e402e39a69bf28b42b27a [^]

Related to issue 40174: Upload data: product into discount, business partner set, import bp into bp set, set bp-set in discount, load in webpos
Update of sample data for new bp-select column and window

---
M referencedata/sampledata/The_White_Valley_Group/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
---
(0110334)
hgbot   
2019-03-11 08:53   
Repository: erp/pmods/org.openbravo.retail.testsampledata
Changeset: 130b8b99878da913327322d4b79cb41f99aae8b8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 11 08:53:11 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata/rev/130b8b99878da913327322d4b79cb41f99aae8b8 [^]

Related to issue 40174: Upload data: product into discount, business partner set
Update sample data

---
M referencedata/sampledata/Retail_Test/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0110372)
hgbot   
2019-03-12 08:57   
Repository: erp/devel/pi
Changeset: bc6165498b86e07199c21e95097d2b173a464726
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Mar 12 08:56:48 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bc6165498b86e07199c21e95097d2b173a464726 [^]

Related to issue 40174: Upload data: product into discount, business partner set
Call to parse is not thread-safe, make method synchronized

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportBPSet.java
---
(0110393)
hgbot   
2019-03-12 21:12   
Repository: erp/pmods/org.openbravo.retail.testsampledata-orderpreparation
Changeset: 130b8b99878da913327322d4b79cb41f99aae8b8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Mar 11 08:53:11 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.testsampledata-orderpreparation/rev/130b8b99878da913327322d4b79cb41f99aae8b8 [^]

Related to issue 40174: Upload data: product into discount, business partner set
Update sample data

---
M referencedata/sampledata/Retail_Test/AD_WINDOW_ACCESS.xml
M referencedata/sampledata/Retail_Test/M_OFFER.xml
---
(0110861)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110906)
hgbot   
2019-03-28 22:32   
Repository: erp/devel/pi
Changeset: af7c14e31dffbddb82b302b06bfc95e12e393971
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Mar 28 22:31:55 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/af7c14e31dffbddb82b302b06bfc95e12e393971 [^]

Related to issue 40174: Upload data: product into discount, business partner set, import bp into bp set
Updated dataset to export client sample data, set hard limit to 50000 records when uploading

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ProcessUploadedFile.java
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
---
(0110907)
hgbot   
2019-03-28 22:34   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 51c643304ed772ce33ffccc6d36599f75f3b8118
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Mar 28 22:34:02 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/51c643304ed772ce33ffccc6d36599f75f3b8118 [^]

Related to issue 40174: Upload data: product into discount, business partner set, import bp into bp set
Added sampledata for automated test

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_BPARTNER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
A referencedata/sampledata/The_White_Valley_Group/C_BP_SET.xml
A referencedata/sampledata/The_White_Valley_Group/C_BP_SET_LINE.xml
A referencedata/sampledata/The_White_Valley_Group/M_OFFER_BP_SET.xml
---
(0110910)
hudsonbot   
2019-03-29 07:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0c1fd9800f2c [^]
Maturity status: Test
(0110920)
hgbot   
2019-03-29 10:56   
Repository: tools/automation/pi-mobile
Changeset: 4cb867ab7f6ae5e8c9ca089cb47f4ab9dd19f8d0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Mar 29 10:55:55 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4cb867ab7f6ae5e8c9ca089cb47f4ab9dd19f8d0 [^]

Related to issue 40174: Upload data: product into discount, business partner set, import bp into bp set
Testcase

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/BPSet_DiscountTest.java
---
(0110937)
hgbot   
2019-04-01 07:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e86f6e6583e3bb665ff6eade803e326470b7c36
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Apr 01 07:56:26 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e86f6e6583e3bb665ff6eade803e326470b7c36 [^]

Related to issue 40174: Upload data: product into discount, business partner set, import bp into bp set, set bp-set in discount, load in webpos
Solve failing test

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---
(0110968)
jorge-garcia   
2019-04-02 17:33   
Code reviewed and tested