0040173: Total button stays disabled when creating canceling PreOrderSave hook for quotations.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0040173

Retail Modules

Web POS

public

2019-02-07 20:28

2019-02-18 08:54

Reporter

lbressan

Assigned To

ranjith_qualiantech_com

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR19Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2018-09-20

Regression introduced in release

RR18Q4

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41997a1342f0#l3.7 [^]

Triggers an Emergency Pack

Summary

0040173: Total button stays disabled when creating canceling PreOrderSave hook for quotations.

Description

This only happen for quotations:
When there is a hook implemented for OBPOS_PreOrderSave, and this hook cancels the operation for some reason (via the cancellation property in arguments), the ticket total button stays disabled.
This also was working properly until release 18Q2.4.

It seems that the change to Process Controller is causing the issue, and the button is not receiving an event to be enabled properly.
This in 18Q2.4 was handled by the synchronizing and synchronized events in the OB.OBPOSPointOfSale.UI.ButtonTabPayment kind.

Steps To Reproduce

1. Log in to POS
2. Create a quotation via the menu
3. Add any product.
4. Open developer console
5. In console, create a hook that cancels the operation:
OB.UTIL.HookManager.registerHook('OBPOS_PreOrderSave', function(a,b){
  OB.UTIL.showError("error");
  a.cancellation = true;
  OB.UTIL.HookManager.callbackExecutor(a,b);
})
6. Click the total button.
7. The total button is now greyed out and can only be restored by switching to another ticket.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0040216	RR19Q1	closed	ranjith_qualiantech_com	Total button stays disabled when creating canceling PreOrderSave hook for quotations.
depends on	backport	0040217	RR18Q4.2	closed	ranjith_qualiantech_com	Total button stays disabled when creating canceling PreOrderSave hook for quotations.
depends on	backport	0040218	RR18Q3.5	closed	ranjith_qualiantech_com	Total button stays disabled when creating canceling PreOrderSave hook for quotations.