Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040173Retail ModulesWeb POSpublic2019-02-07 20:282019-02-18 08:54
lbressan 
ranjith_qualiantech_com 
immediatemajoralways
closedfixed 
5
 
RR19Q2 
marvintm
Production - QA Approved
2018-09-20
RR18Q4
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41997a1342f0#l3.7 [^]
No
0040173: Total button stays disabled when creating canceling PreOrderSave hook for quotations.
This only happen for quotations:
When there is a hook implemented for OBPOS_PreOrderSave, and this hook cancels the operation for some reason (via the cancellation property in arguments), the ticket total button stays disabled.
This also was working properly until release 18Q2.4.

It seems that the change to Process Controller is causing the issue, and the button is not receiving an event to be enabled properly.
This in 18Q2.4 was handled by the synchronizing and synchronized events in the OB.OBPOSPointOfSale.UI.ButtonTabPayment kind.
1. Log in to POS
2. Create a quotation via the menu
3. Add any product.
4. Open developer console
5. In console, create a hook that cancels the operation:
OB.UTIL.HookManager.registerHook('OBPOS_PreOrderSave', function(a,b){
  OB.UTIL.showError("error");
  a.cancellation = true;
  OB.UTIL.HookManager.callbackExecutor(a,b);
})
6. Click the total button.
7. The total button is now greyed out and can only be restored by switching to another ticket.
No tags attached.
depends on backport 0040216RR19Q1 closed ranjith_qualiantech_com Total button stays disabled when creating canceling PreOrderSave hook for quotations. 
depends on backport 0040217RR18Q4.2 closed ranjith_qualiantech_com Total button stays disabled when creating canceling PreOrderSave hook for quotations. 
depends on backport 0040218RR18Q3.5 closed ranjith_qualiantech_com Total button stays disabled when creating canceling PreOrderSave hook for quotations. 
png Screen Shot 2019-02-07 at 16.25.19.png (356,555) 2019-02-07 20:28
https://issues.openbravo.com/file_download.php?file_id=12641&type=bug
Issue History
2019-02-07 20:28lbressanNew Issue
2019-02-07 20:28lbressanAssigned To => Retail
2019-02-07 20:28lbressanFile Added: Screen Shot 2019-02-07 at 16.25.19.png
2019-02-07 20:28lbressanTriggers an Emergency Pack => No
2019-02-07 21:11PracticsIssue Monitored: Practics
2019-02-08 11:57ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-02-08 11:57ranjith_qualiantech_comStatusnew => scheduled
2019-02-11 06:40hgbotCheckin
2019-02-11 06:40hgbotNote Added: 0109659
2019-02-11 06:40hgbotStatusscheduled => resolved
2019-02-11 06:40hgbotResolutionopen => fixed
2019-02-11 06:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2554e0624310dc62913b3d45908a4b7e1181a1a5 [^]
2019-02-15 11:49ranjith_qualiantech_comNote Added: 0109861
2019-02-15 11:49ranjith_qualiantech_comStatusresolved => new
2019-02-15 11:49ranjith_qualiantech_comResolutionfixed => open
2019-02-15 11:50ranjith_qualiantech_comRegression level => Production - QA Approved
2019-02-15 11:50ranjith_qualiantech_comRegression date => 2018-09-20
2019-02-15 11:50ranjith_qualiantech_comRegression introduced in release => RR18Q4
2019-02-15 11:50ranjith_qualiantech_comRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/41997a1342f0#l3.7 [^]
2019-02-15 11:50ranjith_qualiantech_comStatusnew => scheduled
2019-02-15 11:51ranjith_qualiantech_comStatusscheduled => resolved
2019-02-15 11:51ranjith_qualiantech_comResolutionopen => fixed
2019-02-18 08:54marvintmReview Assigned To => marvintm
2019-02-18 08:54marvintmStatusresolved => closed
2019-02-18 08:54marvintmFixed in Version => RR19Q2

Notes
(0109659)
hgbot   
2019-02-11 06:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2554e0624310dc62913b3d45908a4b7e1181a1a5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 11 11:09:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2554e0624310dc62913b3d45908a4b7e1181a1a5 [^]

Fixed issue 40173 : Implemented ProcessController when closing quotations

* Refactored Quotation close callback
  1) If receipt callback is cancelled, then quotation should not be printed

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0109861)
ranjith_qualiantech_com   
2019-02-15 11:49   
Reopening to create backports