Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040169ModulesSeur Spain Integrationpublic2019-02-06 18:282019-03-05 17:22
Reporterfrancisco 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0040169: Error SEUR module
DescriptionIn src/org/openbravo/erputil/carrierintegration/seurspain/SeurIntegration.java

section (firstOrder.getPaymentMethod().isOBEUCIReimbursement()) {
        boxDef.put("claveReembolso", "R");
        boxDef.put("valorReembolso", getGoodsAmt());
      }
Client report that after speaking with SEUR claveReembolso should be "F" or "D" and not "R"
Steps To ReproduceIn src/org/openbravo/erputil/carrierintegration/seurspain/SeurIntegration.java

section (firstOrder.getPaymentMethod().isOBEUCIReimbursement()) {
        boxDef.put("claveReembolso", "R");
        boxDef.put("valorReembolso", getGoodsAmt());
      }
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-06 18:28franciscoNew Issue
2019-02-06 18:28franciscoAssigned To => Triage Finance
2019-02-06 18:28franciscoResolution time => 1551222000
2019-02-06 18:38PracticsIssue Monitored: Practics
2019-02-11 16:22franciscoTypedefect => design defect
2019-02-11 16:28franciscoTypedesign defect => defect
2019-02-11 16:47SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-02-15 15:54SandrahuguetAssigned ToAtulOpenbravo => markmm82
2019-02-19 04:29markmm82Statusnew => scheduled
2019-02-21 08:38SandrahuguetStatusscheduled => feedback
2019-03-01 13:47SandrahuguetStatusfeedback => new
2019-03-03 16:55markmm82Statusnew => scheduled
2019-03-05 17:03hgbotCheckin
2019-03-05 17:03hgbotNote Added: 0110234
2019-03-05 17:03hgbotStatusscheduled => resolved
2019-03-05 17:03hgbotResolutionopen => fixed
2019-03-05 17:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.erputil.carrierintegration.seurspain/rev/da04f141eca0a52f605280e3ca4c0849923e5aa2 [^]
2019-03-05 17:11SandrahuguetReview Assigned To => Sandrahuguet
2019-03-05 17:11SandrahuguetNote Added: 0110235
2019-03-05 17:11SandrahuguetStatusresolved => closed
2019-03-05 17:22SandrahuguetNote Added: 0110236

Notes
(0110234)
hgbot   
2019-03-05 17:03   
Repository: erp/pmods/org.openbravo.erputil.carrierintegration.seurspain
Changeset: da04f141eca0a52f605280e3ca4c0849923e5aa2
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Tue Mar 05 08:07:36 2019 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.erputil.carrierintegration.seurspain/rev/da04f141eca0a52f605280e3ca4c0849923e5aa2 [^]

Fixes issue 40169: Error SEUR module

Added support to the module to set the correct "claveReembolso" value according
who is assuming the costs of the reimurstement.

Was added a new "Reimbursement Costs By" column/field, displayed if the "Reimburstment"
flag is activated on the payment method. User can select if the reimbursement costs are
assumed by sender (F) or by the recipient (D).

Then the SeurIntegration process set as "claveReembolso" the "Reimbursement Costs By" of
the used payment method.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/erputil/carrierintegration/seurspain/SeurIntegration.java
A src-db/database/model/modifiedTables/FIN_PAYMENTMETHOD.xml
---
(0110235)
Sandrahuguet   
2019-03-05 17:11   
code review + testing OK
(0110236)
Sandrahuguet   
2019-03-05 17:22   
A contact with SEUR confirmed that the new valid values in claveRembolso are "F" or "D" depending on who assume the cost of reimbursement.

Now, the user can select if the reimbursement costs are assumed by sender (F) or by the recipient (D) using a new field "Reimbursement Costs By", displayed if the "Reimbursement" flag is activated on the payment method.