Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0040159Openbravo ERPA. Platformpublic2019-02-06 12:082019-03-28 14:56
alostale 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR19Q2 
caristu
Core
No
0040159: remove unused guice depencency
Openbravo declares a dependency on guice, this was used for Google sign in when it used OpenID implementation. This was removed long time ago, but the dependency was kept.
See deployed libs.
Remove it.

Additional checks:

* No module published in CR makes of this library use from sources
* Google Sign in external module continues working
No tags attached.
related to feature request 0029894 closed dbaz Old Google Sign In, OpenID based, should be removed from core 
Issue History
2019-02-06 12:08alostaleNew Issue
2019-02-06 12:08alostaleAssigned To => platform
2019-02-06 12:08alostaleModules => Core
2019-02-06 12:08alostaleTriggers an Emergency Pack => No
2019-02-06 12:08alostaleRelationship addedrelated to 0029894
2019-02-06 12:08alostaleAssigned Toplatform => alostale
2019-02-06 12:08alostaleReview Assigned To => caristu
2019-02-06 12:19hgbotCheckin
2019-02-06 12:19hgbotNote Added: 0109625
2019-02-06 12:19hgbotStatusnew => resolved
2019-02-06 12:19hgbotResolutionopen => fixed
2019-02-06 12:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9bc663af38969177f83ea4362cc1def1ebcca865 [^]
2019-02-15 14:53caristuNote Added: 0109878
2019-02-15 14:53caristuStatusresolved => closed
2019-02-15 14:53caristuFixed in Version => 3.0PR19Q2
2019-02-15 14:53caristuNote Edited: 0109878bug_revision_view_page.php?bugnote_id=0109878#r18336
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110799

Notes
(0109625)
hgbot   
2019-02-06 12:19   
Repository: erp/devel/pi
Changeset: 9bc663af38969177f83ea4362cc1def1ebcca865
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Feb 05 15:33:59 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9bc663af38969177f83ea4362cc1def1ebcca865 [^]

fixed issue 40159: removed unused guice depencency

---
M legal/Licensing.txt
R modules/org.openbravo.client.application/lib/runtime/guice-2.0.jar
---
(0109878)
caristu   
2019-02-15 14:53   
Code reviewed + tested: Google Sign module continues working.

(0110799)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test