Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040156Retail ModulesDiscount Matrix Managementpublic2019-01-23 11:572019-02-18 09:41
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3.5Fixed in Version 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerGold
Support ticket7653
Regression levelProduction - Confirmed Stable
Regression date2018-02-05
Regression introduced in releaseRR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e8a94369c01f [^]
Triggers an Emergency PackNo
Summary0040156: Receipt with discounts can not be completed
Descriptionwith the module Discount Matrix Management, if one line is added with a discretionary discount, it is not possible to complete the receipt. When click in total button is done, error is returned:
Uncaught dodivide(): Divide by 0
Steps To ReproducePOS:
. new receipt:
. add Avalanche Transceiver
. click discount button: add disc_fixed_5_euro
. click in total button

in cosole, error is returned:
Uncaught dodivide(): Divide by 0
Proposed SolutionAttached a possible fix
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0040007 closed ranjith_qualiantech_com Receipt with discounts can not be completed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-06 09:55jorge-garciaTypedefect => backport
2019-02-06 09:55jorge-garciaTarget Version => RR18Q3.5
2019-02-06 10:02jorge-garciaRegression date => 2018-02-05
2019-02-06 10:02jorge-garciaRegression introduced in release => RR18Q2
2019-02-06 10:02jorge-garciaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e8a94369c01f [^]
2019-02-12 15:02hgbotCheckin
2019-02-12 15:02hgbotNote Added: 0109728
2019-02-12 15:03hgbotCheckin
2019-02-12 15:03hgbotNote Added: 0109732
2019-02-12 15:03hgbotStatusscheduled => resolved
2019-02-12 15:03hgbotResolutionopen => fixed
2019-02-12 15:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/80f1109499f38e1f7d8a6123aead1ef6b126480c [^] => http://code.openbravo.com/retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal/rev/f870b242f2280db4aa0d7a3a8e9832afb39d3c4b [^]
2019-02-18 09:41jorge-garciaNote Added: 0109896
2019-02-18 09:41jorge-garciaStatusresolved => closed

Notes
(0109728)
hgbot   
2019-02-12 15:02   
Repository: retail/backports/3.0RR18Q3.5/org.openbravo.retail.discounts
Changeset: aca94fada24d004bffb46cfd24411a45b47f207e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 12 19:31:04 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.5/org.openbravo.retail.discounts/rev/aca94fada24d004bffb46cfd24411a45b47f207e [^]

Related to issue 40156 : New attribute lineQtyOffer is added to promotion

* For MultiDiscount support, qtyOffer has been set as 0.
  But qtyOffer has been used in few modules to calculate custom discount.
  So new attribute "lineQtyOffer" is added to promotion which holds the value of line qty

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0109732)
hgbot   
2019-02-12 15:03   
Repository: retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal
Changeset: f870b242f2280db4aa0d7a3a8e9832afb39d3c4b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 12 19:31:01 2019 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.5/org.openbravo.retail.posterminal/rev/f870b242f2280db4aa0d7a3a8e9832afb39d3c4b [^]

Fixed issue 40156 : New attribute lineQtyOffer is added to promotion

* For MultiDiscount support, qtyOffer has been set as 0.
  But qtyOffer has been used in few modules to calculate custom discount.
  So new attribute "lineQtyOffer" is added to promotion which holds the value of line qty
  When spliting the line, lineQtyOffer is updated based on obdiscQtyoffer

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0109896)
jorge-garcia   
2019-02-18 09:41   
Code reviewed and tested