Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040125Retail ModulesCash uppublic2019-02-04 16:492019-03-07 08:52
Reporterinaki_garcia 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS50OS VersioniOS 12.1.1 (16C50)
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040125: [RR19Q1] [iPad] [UX] The user tag and "Bring" button in the cashup step of "Review pending receipts" displace the close button
DescriptionWhen reviewing the pending open receipts when performing a cashup, the lines for the receipts that belong to another user of the same terminal present a layout issue:
the label of the user and the "Bring" move the close button "X" out of the pane, making it invisible at first glance. This is a major usability issue and can make the
cash up experience very unintuitive, as it is the case with the iPad where the scroll to make the button visible doesn't appear.
Steps To Reproduce0. Log in the Web POS as user "Openbravo"
1. Add a product to the ticket
2. Force a log out by sesion expiration by waiting for 1 hour
3. Click on the "Log in again" button on the "Online" popup that appears
4. Log back in the Web POS as user "vallblanca"
5. Click on the "Cash up" button from the dropdown menu

NOTICE that the "Review pending receipts" step appears with the visual error and the close button can only be shown by scrolling to the right, as depicted in the attached
screenshots. This also reveals the issue with the layout (padding of elements, etc.)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040202RR19Q1 closed javierRodriguez [RR19Q1] [iPad] [UX] The user tag and "Bring" button in the cashup step of "Review pending receipts" displace the close button 
Attached Filespng IMG-0030.PNG (129,823) 2019-02-04 16:51
https://issues.openbravo.com/file_download.php?file_id=12614&type=bug
png

png IMG-0031.PNG (130,138) 2019-02-04 16:51
https://issues.openbravo.com/file_download.php?file_id=12615&type=bug
png

png Smartphone_01.png (27,478) 2019-02-20 12:01
https://issues.openbravo.com/file_download.php?file_id=12674&type=bug
png

png Desktop.png (49,861) 2019-02-20 12:01
https://issues.openbravo.com/file_download.php?file_id=12675&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-02-04 16:49inaki_garciaNew Issue
2019-02-04 16:49inaki_garciaAssigned To => Retail
2019-02-04 16:49inaki_garciaOBNetwork customer => No
2019-02-04 16:49inaki_garciaTriggers an Emergency Pack => No
2019-02-04 16:49inaki_garciaCategoryWeb POS => Cash up
2019-02-04 16:51inaki_garciaFile Added: IMG-0030.PNG
2019-02-04 16:51inaki_garciaFile Added: IMG-0031.PNG
2019-02-04 17:44inaki_garciaOS5 => 50
2019-02-04 17:44inaki_garciaOS Version => iOS 12.1.1 (16C50)
2019-02-04 17:44inaki_garciaSummary[RR19Q1] [UX] The user tag and "Bring" button in the cashup step of "Review pending receipts" displace the close button => [RR19Q1] [iPad] [UX] The user tag and "Bring" button in the cashup step of "Review pending receipts" displace the close button
2019-02-14 15:59marvintmStatusnew => scheduled
2019-02-20 09:29javierRodriguezAssigned ToRetail => javierRodriguez
2019-02-20 12:01dbazFile Added: Smartphone_01.png
2019-02-20 12:01dbazFile Added: Desktop.png
2019-03-06 17:29hgbotCheckin
2019-03-06 17:29hgbotNote Added: 0110268
2019-03-06 17:29hgbotStatusscheduled => resolved
2019-03-06 17:29hgbotResolutionopen => fixed
2019-03-06 17:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1eb79cfcd128f6b7d03acac27c8a60c6831133fc [^]
2019-03-06 18:27hgbotCheckin
2019-03-06 18:27hgbotNote Added: 0110270
2019-03-07 08:38jorge-garciaReview Assigned To => jorge-garcia
2019-03-07 08:52jorge-garciaNote Added: 0110275
2019-03-07 08:52jorge-garciaStatusresolved => closed
2019-03-07 08:52jorge-garciaFixed in Version => RR19Q2

Notes
(0110268)
hgbot   
2019-03-06 17:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1eb79cfcd128f6b7d03acac27c8a60c6831133fc
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Wed Mar 06 11:41:40 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1eb79cfcd128f6b7d03acac27c8a60c6831133fc [^]

Fixed issue 40125: The user tag and "Bring" button in the cashup step of "Review pending receipts" displace the close button

Created 3 components to show all the ticket information
Created styles to that components

---
M web/org.openbravo.retail.posterminal/css/obpos-main.css
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
---
(0110270)
hgbot   
2019-03-06 18:27   
Repository: tools/automation/pi-mobile
Changeset: 34ef546f013973da894aa9e1510e06163937e90e
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Wed Mar 06 18:27:34 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/34ef546f013973da894aa9e1510e06163937e90e [^]

Related to issue 40125

Added two testId to testIdPack about session User in open ticket to bring in cashup
Changed test I39430 to check if the session user in open tickets is correct too

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I39430_VerifyAnotherUserOpenedTicketsInCashUp.java
---
(0110275)
jorge-garcia   
2019-03-07 08:52   
Code reviewed and tested