Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040113Retail ModulesWeb POSpublic2019-01-16 18:142019-03-05 17:43
Reporterasiermartirena 
Assigned Toasiermartirena 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q1Fixed in Version 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040113: The updatePending function is executed too much times
DescriptionThe updatePending function is executed too many times during a single flow, when it should be executed only once setting the final status.
In addition, the function is executed also when the tab (the 'payment' tab) which has the buttons that are being shown/hidden or enabled/disabled is not shown. This function should't be executed in that case.
Steps To ReproduceOpen the Web POS and set a break point in the updatePending function.
Create a ticket in the Web POS --> Check that the updatePending function is being executed even if the payment tab is not shown
Add a payment --> Check that the updatePending function is called many times, when should be called only once
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0039967 closed asiermartirena The updatePending function is executed too much times 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-04 09:17marvintmTypedesign defect => backport
2019-02-04 09:17marvintmTarget Version => RR19Q1
2019-02-15 13:08hgbotCheckin
2019-02-15 13:08hgbotNote Added: 0109869
2019-02-15 13:08hgbotStatusscheduled => resolved
2019-02-15 13:08hgbotResolutionopen => fixed
2019-02-15 13:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/03faa9514189498f020b85f699de2573fc1ddcfb [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/17d148dc3fc3a0c357741d1bec63a64c1caff49d [^]
2019-03-05 17:43jorge-garciaReview Assigned To => jorge-garcia
2019-03-05 17:43jorge-garciaNote Added: 0110241
2019-03-05 17:43jorge-garciaStatusresolved => closed

Notes
(0109869)
hgbot   
2019-02-15 13:08   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 17d148dc3fc3a0c357741d1bec63a64c1caff49d
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Feb 15 13:07:22 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/17d148dc3fc3a0c357741d1bec63a64c1caff49d [^]

Fixed issue 40113: The updatePending function is executed too much times

The updatePending is now called only when clicking in the payment tab, when changing the business partner (and the focus is in the payment tab), when the adjustPayment function is called (and the focus is in the payment tab and also the calculateReceipt process is not being executed) and after the calculateReceipt process has been finished (and the focus is in the payment tab).

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0110241)
jorge-garcia   
2019-03-05 17:43   
Code reviewed and tested