Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040110Retail ModulesWeb POSpublic2019-02-01 16:172019-02-06 17:06
Reporterlbressan 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040110: Web POS login fails when loggin in to a terminal with a payment method configured as Leave as Credit.
DescriptionLogin to Web POS is not possible when having a payment method that is configured as Leave as Credit, associated to the terminal.

This happens because these payment methods do not have a financial account when configured in the Terminals.

A null pointer exception is thrown in the InitialValidations class.
Steps To Reproduce1. In the Channel - Touchpoint Type window, Payment Method tab: Configure any payment method as "Leave as Credit".
2. In the Channel - Touchpoint window, Payment Type tab: For any Terminal (of the type that was edited earlier), add a Payment Type and select a Payment Method that is configured as "Leave as Credit".
3. Notice in grid view, that there is no Financial Account defined (this is correct).
4. Login to this Terminal defined in point 2.
5. This message is shown to the user: "Error loading Terminal Properties
Attempted to login using cache but there is not enough data in cache. Please check you internet connection and click reload to refresh the page. If the problem persists please contact your System Administrator."
6. A stack trace is printed on the openbravo.log with the message:
ERROR org.openbravo.retail.posterminal.term.Terminal - Terminal exception: nullStacktrace: [Ljava.lang.StackTraceElement;@6fcad76d
7. User cannot login
Proposed SolutionFix the null pointer in InitialValidations.java at line 149. A check should be made in case Financial Account is null.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-02-01 16:17lbressanNew Issue
2019-02-01 16:17lbressanAssigned To => Retail
2019-02-01 16:17lbressanResolution time => 1550185200
2019-02-01 16:17lbressanTriggers an Emergency Pack => No
2019-02-04 10:03ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-02-04 10:03ranjith_qualiantech_comStatusnew => scheduled
2019-02-05 09:04hgbotCheckin
2019-02-05 09:04hgbotNote Added: 0109566
2019-02-05 09:04hgbotStatusscheduled => resolved
2019-02-05 09:04hgbotResolutionopen => fixed
2019-02-05 09:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65e590558a3518b0bb2ea4032077fbbc0ef0eaff [^]
2019-02-06 16:43jorge-garciaReview Assigned To => jorge-garcia
2019-02-06 17:06jorge-garciaNote Added: 0109651
2019-02-06 17:06jorge-garciaStatusresolved => closed
2019-02-06 17:06jorge-garciaFixed in Version => RR19Q2

Notes
(0109566)
hgbot   
2019-02-05 09:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 65e590558a3518b0bb2ea4032077fbbc0ef0eaff
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 05 13:34:45 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/65e590558a3518b0bb2ea4032077fbbc0ef0eaff [^]

Fixed issue 40110 : Validation Payment Type Financial Account in Inital Validation

* For Leave As Credit Payment method, Financial Account will be empty in Payment Types
  Above Validation need to be checked in POS Initial Validations

---
M src/org/openbravo/retail/posterminal/InitialValidations.java
---
(0109651)
jorge-garcia   
2019-02-06 17:06   
Code reviewed and tested