Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040087Retail ModulesOmnichannelpublic2019-01-31 13:432019-03-14 12:36
Reporterplujan 
Assigned TojavierRodriguez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040087: [RR19Q1] [OMNI] Usability of the new "Pay Open Tickets" pop up should be improved
DescriptionThe terminal using prepayments now shows all the tickets, paid or not, in the list to pick the "open" tickets to pay.

Problem is, this blind selection of real open tickets among the list of already paid tickets is too prone to error. And, if the user includes in the list a single paid ticket, all the flow is cancelled and has to be restarted.

See steps below.
Steps To ReproduceScenario A (working as expected):
-Create 10 tickets with one line each and use the partial payment button to pay 50% of the total amount.
-Now go to the menu option "Pay Open Tickets" and select the 10 tickets created before.
-Note that, as expected, the 10 tickets are shown in a list to be paid.

Scenario B (failing):
-On top of the 10 tickets created in the previous scenario, create a new one, this one fully paid instead of partially.
-Now go to the menu option "Pay Open Tickets" and select the 11 tickets
-A message saying that the ticket is fully paid is shown, the process is cancelled and the user has to restart the flow.
Proposed SolutionGiven it is not possible to filter the results of the search, at least let the user continue after showing what issues will not be included. But the user should be able to pay the valid tickets that has selected.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040196RR19Q1 closed javierRodriguez [RR19Q1] [OMNI] Usability of the new "Pay Open Tickets" pop up should be improved 
related to defect 0040088 closed javierRodriguez [RR19Q1] [OMNI] An incorrect error message is shown after picking a paid ticket 
related to design defect 0047517 new Retail The screen Pay open tickets show paid tickets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-31 13:43plujanNew Issue
2019-01-31 13:43plujanAssigned To => Retail
2019-01-31 13:43plujanOBNetwork customer => No
2019-01-31 13:43plujanTriggers an Emergency Pack => No
2019-02-14 11:47hgbotCheckin
2019-02-14 11:47hgbotNote Added: 0109828
2019-02-14 11:47hgbotStatusnew => resolved
2019-02-14 11:47hgbotResolutionopen => fixed
2019-02-14 11:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5df3bb4b6b895bcd344a9690e90b316337332ef2 [^]
2019-02-14 12:00javierRodriguezRelationship addedrelated to 0040088
2019-02-14 12:10javierRodriguezStatusresolved => new
2019-02-14 12:10javierRodriguezResolutionfixed => open
2019-02-14 12:10javierRodriguezStatusnew => scheduled
2019-02-14 12:10javierRodriguezStatusscheduled => resolved
2019-02-14 12:10javierRodriguezResolutionopen => fixed
2019-02-14 16:43jorge-garciaAssigned ToRetail => javierRodriguez
2019-02-28 10:10jorge-garciaReview Assigned To => jorge-garcia
2019-02-28 12:33jorge-garciaNote Added: 0110117
2019-02-28 12:33jorge-garciaStatusresolved => closed
2019-02-28 12:33jorge-garciaFixed in Version => RR19Q2
2019-03-14 12:36hgbotCheckin
2019-03-14 12:36hgbotNote Added: 0110436
2021-10-21 08:43ranjith_qualiantech_comRelationship addedrelated to 0047517

Notes
(0109828)
hgbot   
2019-02-14 11:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5df3bb4b6b895bcd344a9690e90b316337332ef2
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Tue Feb 12 12:38:10 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5df3bb4b6b895bcd344a9690e90b316337332ef2 [^]

Fixed issue 40087: [RR19Q1] [OMNI] Usability of the new "Pay Open Tickets" pop up should be improved

Now, before do anything, we check all the orders that the client check in the popup.
An array is created with all the paid tickets that it has been found.

if all the selected orders are paid, An specific popup is shown just saying that at least
one of those orders must be a not-completly-paid order.

if anyone can be paid, we follow the pay open tickets flow with all of the ticket that we
can pay

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/js/components/modal-pay-open-tickets.js
---
(0110117)
jorge-garcia   
2019-02-28 12:33   
Code reviewed and tested
(0110436)
hgbot   
2019-03-14 12:36   
Repository: tools/automation/pi-mobile
Changeset: 12812a49a690d765f3665d3b25eae4e57c1fc545
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Mar 11 08:59:33 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/12812a49a690d765f3665d3b25eae4e57c1fc545 [^]

Related to issue 40087: added automated test

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I40087_VerifyNewPayOpenTicketsFlow.java
---