Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040079Openbravo ERPA. Platformpublic2019-01-31 09:432019-02-11 14:40
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040079: Cleanup in EntityPersistenceEventObserver classes (Platform modules)
DescriptionSome cleanup is required in classes extending EntityPersistenceEventObserver (see attached list):

- They can be declared as package protected, this allows us to extract them from the public API.

- Some of them define an unused "logger" protected field.

- Some other minor code improvements can be applied.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040067 closed caristu Cleanup in EntityPersistenceEventObserver classes 
Attached Filestxt observersByPackage.txt (8,169) 2019-01-31 09:49
https://issues.openbravo.com/file_download.php?file_id=12583&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-31 09:43caristuNew Issue
2019-01-31 09:43caristuAssigned To => caristu
2019-01-31 09:43caristuOBNetwork customer => No
2019-01-31 09:43caristuModules => Core
2019-01-31 09:43caristuTriggers an Emergency Pack => No
2019-01-31 09:43caristuIssue generated from0040067
2019-01-31 09:43caristuRelationship addedrelated to 0040067
2019-01-31 09:49caristuDescription Updatedbug_revision_view_page.php?rev_id=18236#r18236
2019-01-31 09:49caristuFile Added: observersByPackage.txt
2019-02-01 13:42hgbotCheckin
2019-02-01 13:42hgbotNote Added: 0109429
2019-02-01 13:42hgbotStatusnew => resolved
2019-02-01 13:42hgbotResolutionopen => fixed
2019-02-01 13:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.activiti/rev/c52a4584c25f87f20b7a964001f96ad528a3629d [^]
2019-02-01 13:45hgbotCheckin
2019-02-01 13:45hgbotNote Added: 0109430
2019-02-01 13:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/mods/org.openbravo.activiti/rev/c52a4584c25f87f20b7a964001f96ad528a3629d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/0bc31f5d196779c4d6a40279f0d2557876c85160 [^]
2019-02-01 13:48hgbotCheckin
2019-02-01 13:48hgbotNote Added: 0109431
2019-02-01 13:48hgbotCheckin
2019-02-01 13:48hgbotNote Added: 0109432
2019-02-01 13:49caristuNote Edited: 0109432bug_revision_view_page.php?bugnote_id=0109432#r18265
2019-02-01 13:50hgbotCheckin
2019-02-01 13:50hgbotNote Added: 0109433
2019-02-01 13:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/0bc31f5d196779c4d6a40279f0d2557876c85160 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/8d515b726404d1fed1d0cc67cf8071410068cc76 [^]
2019-02-01 13:54hgbotCheckin
2019-02-01 13:54hgbotNote Added: 0109434
2019-02-01 13:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/8d515b726404d1fed1d0cc67cf8071410068cc76 [^] => http://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/ba253945723d7930f5744d4294b1b7bea40e0df9 [^]
2019-02-01 13:55caristuReview Assigned To => alostale
2019-02-11 14:40alostaleNote Added: 0109673
2019-02-11 14:40alostaleStatusresolved => closed
2019-02-11 14:40alostaleFixed in Version => 3.0PR19Q2

Notes
(0109429)
hgbot   
2019-02-01 13:42   
Repository: erp/mods/org.openbravo.activiti
Changeset: c52a4584c25f87f20b7a964001f96ad528a3629d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:42:08 2019 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.activiti/rev/c52a4584c25f87f20b7a964001f96ad528a3629d [^]

fixes issue 40079: Cleanup in EntityPersistenceEventObserver classes

---
M src/org/openbravo/activiti/OBActivitiEntityEventDataSynchronizer.java
---
(0109430)
hgbot   
2019-02-01 13:45   
Repository: erp/pmods/org.openbravo.client.analytics
Changeset: 0bc31f5d196779c4d6a40279f0d2557876c85160
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:45:28 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/0bc31f5d196779c4d6a40279f0d2557876c85160 [^]

fixes issue 40079: Cleanup in EntityPersistenceEventObserver classes

---
M src/org/openbravo/client/analytics/event/CubeCacheQueryEventHandler.java
M src/org/openbravo/client/analytics/event/ProcessConfigurationEventHandler.java
M src/org/openbravo/client/analytics/mondrian/MondrianSchemaHandler.java
---
(0109431)
hgbot   
2019-02-01 13:48   
Repository: erp/pmods/org.openbravo.client.analytics
Changeset: 73bd846ef6bbd9f5ee244e58a44c73de22c161cd
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:47:59 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.client.analytics/rev/73bd846ef6bbd9f5ee244e58a44c73de22c161cd [^]

related to issue 40079: Update copyright year

---
M src/org/openbravo/client/analytics/mondrian/MondrianSchemaHandler.java
---
(0109432)
hgbot   
2019-02-01 13:48   
(edited on: 2019-02-01 13:49)
Repository: erp/pmods/org.openbravo.integration.google
Changeset: b5c738074bb636fe20f2e53d2e83d368abaa53cf
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:48:48 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.integration.google/rev/b5c738074bb636fe20f2e53d2e83d368abaa53cf [^]

fixes issue 40079: Cleanup in EntityPersistenceEventObserver classes

---
M src/org/openbravo/integration/google/common/GoogleConfigChangeHandler.java
M src/org/openbravo/integration/google/common/GoogleConfigHandler.java
---
(0109433)
hgbot   
2019-02-01 13:50   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: 8d515b726404d1fed1d0cc67cf8071410068cc76
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:50:00 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/8d515b726404d1fed1d0cc67cf8071410068cc76 [^]

fixes issue 40079: Cleanup in EntityPersistenceEventObserver classes

---
M src/org/openbravo/service/external/integration/handler/CheckEntityInEntityMappingEventHandler.java
M src/org/openbravo/service/external/integration/handler/CircularDependenciesDetector.java
M src/org/openbravo/service/external/integration/handler/PropertyMappingInstanceEventHandler.java
---
(0109434)
hgbot   
2019-02-01 13:54   
Repository: erp/mods/org.openbravo.client.application.examples
Changeset: ba253945723d7930f5744d4294b1b7bea40e0df9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 01 13:23:03 2019 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/ba253945723d7930f5744d4294b1b7bea40e0df9 [^]

fixes issue 40079: Cleanup in EntityPersistenceEventObserver classes

---
M src/org/openbravo/client/application/examples/GreetingEventHandler.java
---
(0109673)
alostale   
2019-02-11 14:40   
reviewed