Openbravo Issue Tracking System - Retail Modules
View Issue Details
0040056Retail ModulesWeb POSpublic2019-01-29 17:282019-03-01 14:44
Packaging and release
main [^]
0040056: Clicking "x" button in a receipt paying process throws a JS error
Clicking "x" button to remove a payment throws a JS error (check attached image).
It has been always reproducible in Windows 8 tablet and in the TILL. It has been reproduced in pi and RR19Q1.
It has been reproduced once in a non touchable device.
0-Log POS as vallblanca.
1-Add 1x "Avalanche transceiver" to the receipt.
2-Click Total Amount button.
3-Click "tick" button and click "x". DEFECT: A javascript error is thrown.
No tags attached.
blocks defect 0040054 closed gorka_gil Clicking "x" button in a receipt paying process throws a JS error 
Issue History
2019-01-29 18:55gorka_gilTypedefect => backport
2019-01-29 18:55gorka_gilTarget Version => RR19Q1
2019-02-01 12:03hgbotCheckin
2019-02-01 12:03hgbotNote Added: 0109426
2019-02-01 12:03hgbotStatusscheduled => resolved
2019-02-01 12:03hgbotResolutionopen => fixed
2019-02-01 12:03hgbotFixed in SCM revision => [^]
2019-03-01 14:44jorge-garciaReview Assigned To => jorge-garcia
2019-03-01 14:44jorge-garciaNote Added: 0110156
2019-03-01 14:44jorge-garciaStatusresolved => closed

2019-02-01 12:03   
Repository: retail/backports/3.0RR19Q1/
Changeset: 831a24be86db36663ff569967f88641c674ef29c
Author: Gorka Gil <gorka.gil <at>>
Date: Wed Jan 30 18:26:12 2019 +0100
URL: [^]

Fixes issue 40056: [terminal log] stop using the image file name for buttons without text

When a button don't have text, to get a name for use in the terminal log,
previously it tries to find if it has an image and use the image file name.

This is a bit fragile since could be a race condition in slow machines
that makes that when trying to get the html element it don't exist.

This method has a fallback way, that is extract the name from the id,
now this fallback method is the only one, that is more robust
and gives similar names.

M web/
2019-03-01 14:44   
Code reviewed and tested