Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040055Retail ModulesOmnichannelpublic2019-01-29 18:082019-02-27 17:12
Reporterplujan 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040055: [RR19Q1] [OMNI] Unnecessary quotes on message about overpayment
DescriptionWhen overpaying a partial delivery a pop up "Action Required" is shown.

One of the options has an unnecessary use of quotes: Return to customer as 'change'.

Given the previous choice is "Keep as a payment", why this one is not just "Return as change" ?
Steps To ReproduceIn an environment which has been configured to allow partial deliveries (*), login as valblanca user and:

Click in the 'Browse' tab.
Add the 'Insect repellent' product
Add the 'Avalanche transceiver' product
Click on the 'Avalanche transceiver' product line
Click on 'Delivery Modes' button in the right-panel
The 'Line Delivery Modes' pop up is opened
Select Delivery Mode 'Pickup in store'
Click 'Apply'
Check that the label 'Delivery Modes: Pickup in store' is added to the product line
Set product 'Avalanche transceiver' as Undeliverable:
'Username': Openbravo
'Password': openbravo
Click on the total amount button
The message '7.25EUR remaining to pay for delivery' is displayed
Add an amount of 10 in cash
The 'Action Required' pop up is opened.

Note the unnecessary quotes on 'change'. See attached screenshot.

(*) This issue's steps and previous steps to properly configure an environment can be found at https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testsuite&id=43553 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040207RR19Q1 closed ranjith_qualiantech_com [RR19Q1] [OMNI] Unnecessary quotes on message about overpayment 
Attached Filespng UnnecesaryQuotes.png (48,693) 2019-01-29 18:08
https://issues.openbravo.com/file_download.php?file_id=12565&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-01-29 18:08plujanNew Issue
2019-01-29 18:08plujanAssigned To => Retail
2019-01-29 18:08plujanFile Added: UnnecesaryQuotes.png
2019-01-29 18:08plujanTriggers an Emergency Pack => No
2019-01-29 18:10plujanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=18218#r18218
2019-01-30 13:58plujanCategoryWeb POS => Omnichannel
2019-02-14 16:00marvintmStatusnew => scheduled
2019-02-18 12:11ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-02-19 06:46hgbotCheckin
2019-02-19 06:46hgbotNote Added: 0109921
2019-02-19 06:46hgbotStatusscheduled => resolved
2019-02-19 06:46hgbotResolutionopen => fixed
2019-02-19 06:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45c7faf6d270841d6c5ca6c2e7532d236d7f9437 [^]
2019-02-27 17:11jorge-garciaReview Assigned To => jorge-garcia
2019-02-27 17:12jorge-garciaNote Added: 0110109
2019-02-27 17:12jorge-garciaStatusresolved => closed
2019-02-27 17:12jorge-garciaFixed in Version => RR19Q2

Notes
(0109921)
hgbot   
2019-02-19 06:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 45c7faf6d270841d6c5ca6c2e7532d236d7f9437
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 19 11:15:48 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/45c7faf6d270841d6c5ca6c2e7532d236d7f9437 [^]

Fixed issue 40055 : Updated ADMessage to show proper message when doing overypayment

* Removed quotes from ADMessage when doing overpayment

---
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0110109)
jorge-garcia   
2019-02-27 17:12   
Code reviewed and tested