Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040054Retail ModulesWeb POSpublic2019-01-29 17:282019-02-06 13:39
Reporterlorenzofidalgo 
Assigned Togorka_gil 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression levelPackaging and release
Regression date
Regression introduced in releasemain
Regression introduced by commithttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1392001fae5266678b988e6d34f0550a9da81209 [^]
Triggers an Emergency PackNo
Summary0040054: Clicking "x" button in a receipt paying process throws a JS error
DescriptionClicking "x" button to remove a payment throws a JS error (check attached image).
It has been always reproducible in Windows 8 tablet and in the TILL. It has been reproduced in pi and RR19Q1.
It has been reproduced once in a non touchable device.
Steps To Reproduce0-Log POS as vallblanca.
1-Add 1x "Avalanche transceiver" to the receipt.
2-Click Total Amount button.
3-Click "tick" button and click "x". DEFECT: A javascript error is thrown.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040056RR19Q1 closed gorka_gil Clicking "x" button in a receipt paying process throws a JS error 
caused by design defect 0039360 closed gorka_gil Terminal Log : Improve log client with cashier actions and processes start/end info 
Attached Filespng JSError.PNG (123,210) 2019-01-29 17:28
https://issues.openbravo.com/file_download.php?file_id=12563&type=bug
png

diff 40054-mobilecore-18q3.diff (1,796) 2019-02-01 12:10
https://issues.openbravo.com/file_download.php?file_id=12600&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-29 17:28lorenzofidalgoNew Issue
2019-01-29 17:28lorenzofidalgoAssigned To => Retail
2019-01-29 17:28lorenzofidalgoFile Added: JSError.PNG
2019-01-29 17:28lorenzofidalgoRegression level => Packaging and release
2019-01-29 17:28lorenzofidalgoRegression introduced in release => main
2019-01-29 17:28lorenzofidalgoTriggers an Emergency Pack => No
2019-01-29 17:34gorka_gilAssigned ToRetail => gorka_gil
2019-01-29 18:55gorka_gilRegression introduced by commit => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1392001fae5266678b988e6d34f0550a9da81209 [^]
2019-01-29 18:55gorka_gilRelationship addedcaused by 0039360
2019-01-29 18:55gorka_gilStatusnew => scheduled
2019-02-01 11:51hgbotCheckin
2019-02-01 11:51hgbotNote Added: 0109425
2019-02-01 11:51hgbotStatusscheduled => resolved
2019-02-01 11:51hgbotResolutionopen => fixed
2019-02-01 11:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/362aa306bbb8ffaf306de58d139d6072ec9d29f9 [^]
2019-02-01 12:10gorka_gilFile Added: 40054-mobilecore-18q3.diff
2019-02-06 10:42jorge-garciaReview Assigned To => jorge-garcia
2019-02-06 13:39jorge-garciaNote Added: 0109631
2019-02-06 13:39jorge-garciaStatusresolved => closed
2019-02-06 13:39jorge-garciaFixed in Version => RR19Q2

Notes
(0109425)
hgbot   
2019-02-01 11:51   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 362aa306bbb8ffaf306de58d139d6072ec9d29f9
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Jan 30 18:26:12 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/362aa306bbb8ffaf306de58d139d6072ec9d29f9 [^]

Fixes issue 40054: [terminal log] stop using the image file name for buttons without text

When a button don't have text, to get a name for use in the terminal log,
previously it tries to find if it has an image and use the image file name.

This is a bit fragile since could be a race condition in slow machines
that makes that when trying to get the html element it don't exist.

This method has a fallback way, that is extract the name from the id,
now this fallback method is the only one, that is more robust
and gives similar names.

---
M web/org.openbravo.mobile.core/source/utils/ob-terminal-log.js
---
(0109631)
jorge-garcia   
2019-02-06 13:39   
Code reviewed and tested