Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040049Openbravo ERP04. Warehouse managementpublic2019-01-29 11:572019-03-28 14:56
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket7780
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040049: Create Shipments from Orders is consuming Document Sequence although the shipment is not created because there is not stock
DescriptionCreate Shipments from Orders is consuming Document Sequence although the shipment is not created because there is not stock
Steps To ReproduceAs group admin role:
   Check there is not any storage bin that allows negative stock (Inventory Status should not have Overissue option selected)

   Create a new product and add a sales price list to it
   Create a sales order, add previously created product and book it
   Create a Goods Shipment header and check the provided document number (X)
   Go to Create Shipments from Orders window, select previously created sales order and process it. Check the following error is shown:
      Error:
         Order No. <>: No shipment could be created.
         Order line: 10 Insufficient stock: for product <>.
   Create a Goods Shipment header and check the provided document number is X+2 instead of X+1
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-29 11:57ngarciaNew Issue
2019-01-29 11:57ngarciaAssigned To => Triage Finance
2019-01-29 11:57ngarciaOBNetwork customer => OBPS
2019-01-29 11:57ngarciaModules => Core
2019-01-29 11:57ngarciaSupport ticket => 7780
2019-01-29 11:57ngarciaResolution time => 1550530800
2019-01-29 11:57ngarciaTriggers an Emergency Pack => No
2019-01-29 12:15SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-01-29 18:49AtulOpenbravoStatusnew => scheduled
2019-01-30 10:59AtulOpenbravoNote Added: 0109320
2019-02-14 15:51hgbotCheckin
2019-02-14 15:51hgbotNote Added: 0109838
2019-02-14 15:51hgbotStatusscheduled => resolved
2019-02-14 15:51hgbotResolutionopen => fixed
2019-02-14 15:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9103f1b1f506e9d3a396387f14b7cc5a9419a6f7 [^]
2019-02-14 15:56SandrahuguetReview Assigned To => Sandrahuguet
2019-02-14 15:56SandrahuguetNote Added: 0109839
2019-02-14 15:56SandrahuguetStatusresolved => closed
2019-02-14 15:56SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110816

Notes
(0109320)
AtulOpenbravo   
2019-01-30 10:59   
- Login as F&B International Group Admin.
- Check there is no storage bin that allows negative stock (Inventory Status should not have Overissue option selected)
- Create a new product and add a sales price list to it
- Create a sales order, add previously created product and book it
- Create a Goods Shipment header and check the provided document number (X)
- Go to Create Shipments from Orders window, select previously created sales
  order and process it. Check the following error is shown:
  Error:
         Order No. <>: No shipment could be created.
         Order line: 10 Insufficient stock: for product <>.

- Create a Goods Shipment header and check the provided document number is X+1 which is correct.

- Reactivate Sales Order and add a product having stock to it along with earlier product.
- Complete the order.
- Go to Create Shipments from Orders window, select previously created sales
  order and process it. Check the following warning is shown:
 
  Warning
  Order No. <> Shipment No. <>: Order partially delivered.
  Order line: 10 Insufficient stock: for product <>.

- Create a Goods Shipment header and check the provided document number is X+2 which is correct as in previous step partial Goods Shipment was created with document no X+1.
(0109838)
hgbot   
2019-02-14 15:51   
Repository: erp/devel/pi
Changeset: 9103f1b1f506e9d3a396387f14b7cc5a9419a6f7
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Jan 30 11:29:47 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9103f1b1f506e9d3a396387f14b7cc5a9419a6f7 [^]

Fixes Issue 0040049: Create Shipments from Orders is consuming
Document Sequence although the shipment is not created because
there is not stock

While creating shipment header, get document no but do not
increment the document sequence, before processing shipment
get document no and increment document sequence. So whenever
there is condition that shipment cannot be created, document
sequence is not incremented unless shipment is eligible for
processing.

---
M src-db/database/model/functions/M_INOUT_CREATE.xml
---
(0109839)
Sandrahuguet   
2019-02-14 15:56   
Code review + testing ok
(0110816)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test