Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039986Openbravo ERP07. Sales managementpublic2019-01-21 14:392019-03-28 14:55
Reporterjoniturralde93 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket7586
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039986: Invoice status in goods shipment is not correctly calculated in some circumstances
DescriptionWhen you create an invoice from a goods shipment, if that goods shipment has same possitive and negative line quantities, after completing the invoice, invoice status in shipment window keeps as 0%
Steps To Reproduce1. Create a sales order with two lines, one with quantity 1 and the other with quantity -1.
2. Delete the 10% basic discount, so only those two lines appear for the shipment.
3. Book the order.
4. Create a goods shipment and 'create lines from' that order, add the two lines.
5. Complete the goods shipment (you may need to change Storage Bin status to 'Undefined - Overissue' in order to complete the shipment).
6. Create a sales invoice and 'create lines from shipment', select both lines. Complete the invoice.
7. Go to the sales order and refresh it. Invoice status: 100%
8. Go to goods shipment and refresh it. Invoice status: 0%
Proposed SolutionPL C_GETINVOICESTATUSFROMSHIPMENT treatment on line positive/negative quantities is probably not correct.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-21 14:39joniturralde93New Issue
2019-01-21 14:39joniturralde93Assigned To => Triage Finance
2019-01-21 14:39joniturralde93OBNetwork customer => OBPS
2019-01-21 14:39joniturralde93Modules => Core
2019-01-21 14:39joniturralde93Support ticket => 7584
2019-01-21 14:39joniturralde93Resolution time => 1549839600
2019-01-21 14:39joniturralde93Triggers an Emergency Pack => No
2019-01-21 14:40joniturralde93Support ticket7584 => 7586
2019-01-21 14:41PracticsIssue Monitored: Practics
2019-01-21 16:00dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2019-01-24 11:40AtulOpenbravoStatusnew => scheduled
2019-01-24 11:40AtulOpenbravoNote Added: 0109155
2019-01-24 16:25hgbotCheckin
2019-01-24 16:25hgbotNote Added: 0109234
2019-01-24 16:25hgbotStatusscheduled => resolved
2019-01-24 16:25hgbotResolutionopen => fixed
2019-01-24 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9195e827f97ce09aee6f73fdc9f223bb0b1e4f6a [^]
2019-01-24 16:28SandrahuguetReview Assigned To => Sandrahuguet
2019-01-24 16:28SandrahuguetNote Added: 0109235
2019-01-24 16:28SandrahuguetStatusresolved => closed
2019-01-24 16:28SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110760

Notes
(0109155)
AtulOpenbravo   
2019-01-24 11:40   
1. Login as F&B International Group Admin
2. Create a sales order with two lines, one with quantity 10 and the other with quantity -10.
3. Delete records from basic discount tab, so only those two lines appear for the shipment.
4. Book the order.
5. Create a goods shipment and 'create lines from' that order, add the two lines.
6. Complete the goods shipment (you may need to change Storage Bin status to 'Undefined - Overissue' in order to complete the shipment).
7. Create a sales invoice and 'create lines from shipment', select both lines. Complete the invoice.
8. Go to the sales order and refresh it. Invoice status: 100%
9. Go to goods shipment and refresh it. Invoice status: 100%
(0109234)
hgbot   
2019-01-24 16:25   
Repository: erp/devel/pi
Changeset: 9195e827f97ce09aee6f73fdc9f223bb0b1e4f6a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Jan 24 16:07:24 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9195e827f97ce09aee6f73fdc9f223bb0b1e4f6a [^]

Fixes Issue 39986:Invoice status in goods shipment is not correctly
calculated in some circumstances

** When calculating invoice status sum of absolute value of quantities
should be considered to have proper invoice status values. If
quantities are combination of positive and negative values then simple
sum will produce wrong results.

---
M src-db/database/model/functions/C_GETINVOICESTATUSFROMSHIPMENT.xml
---
(0109235)
Sandrahuguet   
2019-01-24 16:28   
Code review + testing OK
(0110760)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test