Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039973ModulesAdvanced Warehouse Operationspublic2019-01-18 09:542019-02-04 10:10
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039973: Expected Quantity can be higher than ordered quantity if the purchase order is reactivated after creating the Receive task
DescriptionExpected Quantity can be higher than ordered quantity if the purchase order is reactivated after creating the Receive task
Steps To ReproduceAs group admin role:
   Create a purchase order for 'US West Coast' and 'US West Coast' warehouse
   Add 100 units of 'Ale Beer' product and book it
   Launch the Receive process and check a task is created with an Expected Quantity of 100
   Reactivate the purchase order
   Modify the ordered quantity to 25 and book it
   Check the task has an Expected Quantity of 100
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-18 09:54ngarciaNew Issue
2019-01-18 09:54ngarciaAssigned To => Triage Finance
2019-01-18 09:54ngarciaResolution time => 1549580400
2019-01-18 09:54ngarciaIssue Monitored: networkb
2019-01-18 12:54juabaezIssue Monitored: juabaez
2019-01-21 09:16dmiguelezAssigned ToTriage Finance => AtulOpenbravo
2019-01-28 15:14AtulOpenbravoStatusnew => scheduled
2019-01-28 15:14AtulOpenbravoNote Added: 0109276
2019-01-29 07:45AtulOpenbravoNote Edited: 0109276bug_revision_view_page.php?bugnote_id=0109276#r18211
2019-02-01 14:36hgbotCheckin
2019-02-01 14:36hgbotNote Added: 0109437
2019-02-01 14:36hgbotStatusscheduled => resolved
2019-02-01 14:36hgbotResolutionopen => fixed
2019-02-01 14:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1a42152290690fa38bbccdfbc3c84f46c5f91ef3 [^]
2019-02-01 14:37SandrahuguetReview Assigned To => Sandrahuguet
2019-02-01 14:37SandrahuguetNote Added: 0109438
2019-02-01 14:37SandrahuguetStatusresolved => closed
2019-02-04 10:10dmiguelezNote Added: 0109513
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0109276)
AtulOpenbravo   
2019-01-28 15:14   
(edited on: 2019-01-29 07:45)
- Login as AWO QA Admin role.
- Create a purchase order for 'US West Coast' and 'US West Coast' warehouse
   Add 100 units of 'Ale Beer' product and book it
- Launch the Receive process and check a task is created with an Expected
 Quantity of 100
- Reactivate the purchase order.
- Error message is shown that "Can not reactivate an Order with Tasks in status 'Available' or 'Reserved'"
- Navigate to Task created in previous step. Confirm it.
- Reactivate the Purchase Order.
- Purchase Order can be reactivated now.
(0109437)
hgbot   
2019-02-01 14:36   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 1a42152290690fa38bbccdfbc3c84f46c5f91ef3
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Jan 29 12:04:01 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/1a42152290690fa38bbccdfbc3c84f46c5f91ef3 [^]

Fixes Issue 0039973: Expected Quantity can be higher than ordered
quantity if the purchase order is reactivated after creating the
Receive task

** Renamed OBAWO_CLOSE_ORDER_EP as OBAWO_PROCESS_ORDER as it
included not only CLOSE docaction but also REACTIVATE docaction
to avoid reactivate order when there is orderlines linked with
tasks.

---
M src-db/database/sourcedata/AD_EP_PROCEDURES.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/functions/OBAWO_PROCESS_ORDER_EP.xml
R src-db/database/model/functions/OBAWO_CLOSE_ORDER_EP.xml
---
(0109438)
Sandrahuguet   
2019-02-01 14:37   
Code review + testing OK
(0109513)
dmiguelez   
2019-02-04 10:10   
The fix done is to prevent the reactivation of a Sales Order if there are pending Tasks.

Differently to the Close of a Sales Order, this behavior can not be changed with a preference. This is due to the fact that reactivation allows to modify the lines of the Order. In this case, it is mandatory to delete first the associated Tasks. If not, there can be inconsistencies.