Notes |
|
(0108979)
|
hgbot
|
2019-01-16 13:00
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e62ce91d8ee7a774f77a11478a05afe41d10c8cf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Jan 14 15:38:45 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e62ce91d8ee7a774f77a11478a05afe41d10c8cf [^]
Fixed issue 39956: Under specific circumstances (payment type/method), copy
terminal fails [financial account + leave as credit]
- Verifies if the financial account is null to avoid the event handler execution
---
M src/org/openbravo/retail/posterminal/event/AppPaymentEventHandler.java
---
|
|
|
|
The idea of the fix is good, but the implementation does not work. The changed code will crash with a NullPointerException when you define the payment method manually, because the condition which is being checked is incorrect. Instead of this:
if (appPayment.getFinancialAccount().getId() != null) {
It should be like this:
if (appPayment.getFinancialAccount() != null) {
The problem can be reproduced simply by creating a payment method in the touchpoint type with "leave as credit" checked, and then trying to create the corresponding payment method in the touchpoint window. |
|
|
(0109680)
|
hgbot
|
2019-02-11 19:39
|
|
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dc0800a966f1f6920cc5a6ba7de53b3de5e4fc78
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Feb 11 10:30:02 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dc0800a966f1f6920cc5a6ba7de53b3de5e4fc78 [^]
Fixed issue 39956: Under specific circumstances (payment type/method), copy
terminal fails [financial account + leave as credit]
- Fixed nullpointer caused by the previous solution
---
M src/org/openbravo/retail/posterminal/event/AppPaymentEventHandler.java
---
|
|