Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039950Retail ModulesWeb POSpublic2019-01-15 12:432019-02-04 09:16
Reporterasiermartirena 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039950: The callbacks of a calculateReceipt are executed with the calculateReceipt process set
DescriptionWhen the callbacks of a calculate receipt are executed, those executions are made with the process controller of the calculateReceipt set. The process should finish and them the callbacks should be called.

This also occurred for the calculatingReceipt property.

Those properties should be set before calling to the callbacks, copying the calculateReceiptCallbacks to a new array and unsetting it. In this way, if one of the callbacks executes the calculate receipt when all the callbacks haven't been executed, those new callbacks won't be set to the same array.
Steps To ReproduceAdd a line in the Web POS and debug the code.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040112RR19Q1 closed ranjith_qualiantech_com The callbacks of a calculateReceipt are executed with the calculateReceipt process set 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-15 12:43asiermartirenaNew Issue
2019-01-15 12:43asiermartirenaAssigned To => Retail
2019-01-15 12:43asiermartirenaOBNetwork customer => No
2019-01-15 12:43asiermartirenaTriggers an Emergency Pack => No
2019-01-15 12:44marvintmOBNetwork customerNo => Gold
2019-01-15 12:44marvintmResolution time => 1548889200
2019-01-17 07:10ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-01-17 07:10ranjith_qualiantech_comStatusnew => scheduled
2019-01-22 12:47hgbotCheckin
2019-01-22 12:47hgbotNote Added: 0109069
2019-01-22 12:47hgbotStatusscheduled => resolved
2019-01-22 12:47hgbotResolutionopen => fixed
2019-01-22 12:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b3f7f6a25264cd7ac5580f0195fc82c4767f13d [^]
2019-01-22 15:40marvintmNote Added: 0109081
2019-01-22 15:40marvintmStatusresolved => new
2019-01-22 15:40marvintmResolutionfixed => open
2019-01-24 10:23ranjith_qualiantech_comStatusnew => scheduled
2019-01-28 06:53hgbotCheckin
2019-01-28 06:53hgbotNote Added: 0109264
2019-01-28 06:53hgbotStatusscheduled => resolved
2019-01-28 06:53hgbotResolutionopen => fixed
2019-01-28 06:53hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b3f7f6a25264cd7ac5580f0195fc82c4767f13d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a36d470afb3d679175071bb3ef645bd2771a7b0 [^]
2019-02-04 09:16marvintmStatusresolved => new
2019-02-04 09:16marvintmResolutionfixed => open
2019-02-04 09:16marvintmStatusnew => scheduled
2019-02-04 09:16marvintmStatusscheduled => resolved
2019-02-04 09:16marvintmFixed in Version => RR19Q2
2019-02-04 09:16marvintmResolutionopen => fixed
2019-02-04 09:16marvintmReview Assigned To => marvintm
2019-02-04 09:16marvintmStatusresolved => closed

Notes
(0109069)
hgbot   
2019-01-22 12:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3b3f7f6a25264cd7ac5580f0195fc82c4767f13d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 22 17:16:13 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3b3f7f6a25264cd7ac5580f0195fc82c4767f13d [^]

Fixed issue 39950 : Changes in calculateReceipt callback functions

* If calculateReceipt X is presents inside callback of calculateReceipt Y and calculateReceipt X callback has same,
  then each calculateReceipt callback must be executed

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0109081)
marvintm   
2019-01-22 15:40   
A different fix must be done
(0109264)
hgbot   
2019-01-28 06:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6a36d470afb3d679175071bb3ef645bd2771a7b0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jan 28 11:22:59 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6a36d470afb3d679175071bb3ef645bd2771a7b0 [^]

Fixed issue 39950 : Changes in calculateReceipt callback functions

* If calculateReceipt is presents inside callback of calculateReceipt, callback should be called when the calculateReceipt process is completed

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---