Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039925Retail ModulesWeb POSpublic2019-01-11 09:372019-03-26 16:50
Reporterjorgewederago 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039925: Prepayment UI is being triggered even if we do not have the configuration active
DescriptionIt is possible to arrive to an inconsistent state with prepayments even if the the POS Terminal type is not configured to use prepayments.
Steps To ReproduceFor this steps it is needed to have retail coupons installed.
-Backend
*Configure a coupon to use in the transaction
-Front End
*Add a product
*Add the coupon
*Press total and go to the payments tab
*Open the console in developers tools
*Remove the coupon from OB.MobileApp.model.receipt.get('coupons')
*Execute a OB.MobileApp.model.receipt.calculateReceipt()
*The UI will be a mix of the standard one and the one from PrePayments
Proposed SolutionTake into account the value of OB.MobileApp.model.get('terminal').terminalType.calculateprepayments in this piece of code:

      if (!receiptHasPrepaymentAmount) {
        this.$.prepaymentsbuttons.hide();
        this.$.exactbutton.show();
      } else {
        this.$.prepaymentsbuttons.show();
        this.$.exactbutton.hide();
      }
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0040461RR19Q1.1 closed rqueralta Prepayment UI is being triggered even if we do not have the configuration active 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-11 09:37jorgewederagoNew Issue
2019-01-11 09:37jorgewederagoAssigned To => Retail
2019-01-11 09:37jorgewederagoOBNetwork customer => No
2019-01-11 09:37jorgewederagoResolution time => 1548975600
2019-01-11 09:37jorgewederagoTriggers an Emergency Pack => No
2019-01-12 15:28rqueraltaAssigned ToRetail => rqueralta
2019-01-12 15:28rqueraltaStatusnew => scheduled
2019-01-28 12:59marvintmOBNetwork customerNo => OBPS
2019-02-08 18:42hgbotCheckin
2019-02-08 18:42hgbotNote Added: 0109656
2019-02-08 18:42hgbotStatusscheduled => resolved
2019-02-08 18:42hgbotResolutionopen => fixed
2019-02-08 18:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/523fa8902cfacbf67745d96a4bffbbaf3aeaa8f1 [^]
2019-02-11 11:09marvintmReview Assigned To => marvintm
2019-02-11 11:09marvintmStatusresolved => closed
2019-02-11 11:09marvintmFixed in Version => RR19Q2
2019-03-26 16:50marvintmStatusclosed => new
2019-03-26 16:50marvintmResolutionfixed => open
2019-03-26 16:50marvintmFixed in VersionRR19Q2 =>
2019-03-26 16:50marvintmStatusnew => scheduled
2019-03-26 16:50marvintmStatusscheduled => resolved
2019-03-26 16:50marvintmFixed in Version => RR19Q2
2019-03-26 16:50marvintmResolutionopen => fixed
2019-03-26 16:50marvintmStatusresolved => closed

Notes
(0109656)
hgbot   
2019-02-08 18:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 523fa8902cfacbf67745d96a4bffbbaf3aeaa8f1
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Feb 07 11:42:08 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/523fa8902cfacbf67745d96a4bffbbaf3aeaa8f1 [^]

Fixed issue 39925: Prepayment UI is being triggered even if we do not have the
configuration active

- Taked into account the value of property:
  OB.MobileApp.model.get('terminal').terminalType.calculateprepayments

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---