Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039923Retail ModulesGift cards and gift voucherspublic2017-05-09 11:332019-01-10 18:57
plujan 
rqueralta 
normalminorhave not tried
resolvedfixed 
5
main 
RR19Q1 
guilleaer
No
0039923: [RR17Q2] On session restart is possible to create a Gift Card with NULL identifier
When purchasing a new Gift Card, there are some mandatory values to fill in the pop up that is shown.
However, if the session restarts before filling the fields, the pop up can be ignored and the Card can be created with the identifier as null.
1. In an environment with Gift Cards configured, purchase a Card by adding it to a ticket.
2. A pop up window is shown, with several field to fill in. Leave all the fields blank. Note that it is not possible to continue with the ticket payment if ID is left blank (i.e. closing the window will remove the card from the ticket)
3. Restart the session (i.e. an automatic refresh is triggered or F5 key is pressed)
4. When the main screen is back, note that the Card is still in the ticket (as expected) but now you can pay the ticket. As a result, the ID is null and the Card cannot be used later (since it cannot be retrieved)
An extra validation on the payment in case any mandatory field is missing.
No tags attached.
blocks defect 0035957 closed rqueralta [RR17Q2] On session restart is possible to create a Gift Card with NULL identifier 
Issue History
2019-01-10 18:52gorka_gilTypedefect => backport
2019-01-10 18:52gorka_gilTarget Version => RR19Q1
2019-01-10 18:57hgbotCheckin
2019-01-10 18:57hgbotNote Added: 0108913
2019-01-10 18:57hgbotStatusscheduled => resolved
2019-01-10 18:57hgbotResolutionopen => fixed
2019-01-10 18:57hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/48d02ee91c5bd3994c5a55af0ea7e9ff99efdc14 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/06cd122bddfa7442c17522c219134e342d000c3b [^]
2019-01-10 18:57hgbotCheckin
2019-01-10 18:57hgbotNote Added: 0108914
2019-01-10 18:57hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/06cd122bddfa7442c17522c219134e342d000c3b [^] => http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/13922bc4832b898bdd310075dcd788eae466638b [^]

Notes
(0108913)
hgbot   
2019-01-10 18:57   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 06cd122bddfa7442c17522c219134e342d000c3b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Dec 27 13:48:05 2018 -0500
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/06cd122bddfa7442c17522c219134e342d000c3b [^]

Fixed issue 39923: [RR17Q2] On session restart is possible to create a Gift Card
with NULL identifier

- Removed lines without mandatory filds filled

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0108914)
hgbot   
2019-01-10 18:57   
Repository: retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal
Changeset: 13922bc4832b898bdd310075dcd788eae466638b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Jan 04 07:53:35 2019 -0500
URL: http://code.openbravo.com/retail/backports/3.0RR19Q1/org.openbravo.retail.posterminal/rev/13922bc4832b898bdd310075dcd788eae466638b [^]

Fixed issue 39923: [RR17Q2] On session restart is possible to create a Gift Card
with NULL identifier

- Removed lines without mandatory filds filled

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---