Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039919Openbravo ERPA. Platformpublic2019-01-10 16:332019-03-28 14:55
Reporterfrancisco 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039919: A change of Password leaves a session as Active in BackOffice
DescriptionWhen a user changes his password in the login window because it had expired, an active session is created and never terminated.

It can be seen from the screenshot attached.

The only way to close it is killing the process manually
Steps To Reproduce1. Set "Days To Password Expiration" = 1 in 'Client' window
2. Login with a user different from Openbravo and logout
3. Login to BackOffice with Openbravo user and check in 'Session' window that the previous session is not active (This is OK)
4. After one day, when the password expires, the user is requested to change the password. Proceed to change the password
5. Login as Openbravo user and check the "active sessions" in the 'Session' window. There are two sessions active for the user that just changed the password.(Should be just one).
6. Logout as the previous user different from Openbravo.
7. Check again with Openbravo user the "active sessions". There is still one session open for the user who has changed his/her password.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031796 closed jonibc Extend functionality with the option to define a day limit for the password to be changed 
Attached Filespng Selection_099.png (21,962) 2019-01-10 16:33
https://issues.openbravo.com/file_download.php?file_id=12500&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-01-10 16:33franciscoNew Issue
2019-01-10 16:33franciscoAssigned To => platform
2019-01-10 16:33franciscoFile Added: Selection_099.png
2019-01-10 16:33franciscoModules => Core
2019-01-10 16:33franciscoTriggers an Emergency Pack => No
2019-01-10 16:44JONHMResolution time => 1517353200
2019-01-10 17:01eugeniIssue Monitored: eugeni
2019-01-11 09:50alostaleResolution time1517353200 => 1548889200
2019-01-11 09:50alostaleSummaryA change of Password leave a session as Active in BackOffice => A change of Password leaves a session as Active in BackOffice
2019-01-11 09:50alostaleDescription Updatedbug_revision_view_page.php?rev_id=18112#r18112
2019-01-11 09:50alostaleReview Assigned To => caristu
2019-01-11 09:51alostaleAssigned Toplatform => alostale
2019-01-11 10:04hgbotCheckin
2019-01-11 10:04hgbotNote Added: 0108921
2019-01-11 10:04hgbotStatusnew => resolved
2019-01-11 10:04hgbotResolutionopen => fixed
2019-01-11 10:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9a417375877cb68a766ffba5303f7639f8254f29 [^]
2019-01-11 10:06alostaleRelationship addedrelated to 0031796
2019-01-11 13:25caristuNote Added: 0108927
2019-01-11 13:25caristuStatusresolved => closed
2019-01-11 13:25caristuFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110719

Notes
(0108921)
hgbot   
2019-01-11 10:04   
Repository: erp/devel/pi
Changeset: 9a417375877cb68a766ffba5303f7639f8254f29
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Jan 11 09:54:50 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9a417375877cb68a766ffba5303f7639f8254f29 [^]

fixed bug 39919: session leaked after password reset from login window

  When password was detected to be expired in login process a new active session
  was created, after resetting the password, this session was leaked and a new
  one was created.

  Now login process creates an inactive failed session when password is expired.

---
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
---
(0108927)
caristu   
2019-01-11 13:25   
Code reviewed + tested OK.
(0110719)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test