Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039895Openbravo ERP09. Financial managementpublic2019-01-09 13:282019-03-28 14:55
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039895: Simple G/L Journal line can be removed although it has related payment. Payment can be deleted although the journal is processed
DescriptionSimple G/L Journal line can be removed although it has related payment. Payment can be deleted although the journal is processed

The right flow should be:
1. Reactivate the G/L Journal
2. Reactivate and delete the payment
3. Delete the G/L Journal line
Steps To ReproduceAs group admin role:
   Create a Simple G/L Journal:
      Organization: F&B US East Coast
      General Ledger: F&B International Group US/A/US Dollar
   Add a line to it:
      Account: 1110 - Checking Account
      Debit: 100
      Open Items: Y
      Select Financial Account, Payment Method, G/L Item and Payment Date
   Add another line to it:
      Account: 1120 - Funds In-Transfer
      Credit: 100
      Open Items: N
   Complete it

   Navigate to the payment
   Check you can reactivate and delete it and you should not

   Create a new Simple G/L Journal:
      Organization: F&B US East Coast
      General Ledger: F&B International Group US/A/US Dollar
   Add a line to it:
      Account: 1110 - Checking Account
      Debit: 100
      Open Items: Y
      Select Financial Account, Payment Method, G/L Item and Payment Date
   Add another line to it:
      Account: 1120 - Funds In-Transfer
      Credit: 100
      Open Items: N
   Complete it
   Reactivate it
   Check a warning is shown. This is correct
   Try to edit the amount in the line related with the payment
   Check an error is shown. This is also correct
   Check you can delete the line related with the payment and you should not
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0039889 closed AtulOpenbravo Openbravo ERP Cannot process a Simple G/L Journal with Open Items option selected on a line 
related to defect 00302603.0PR15Q4 closed AtulOpenbravo Openbravo ERP It is not possible to Reactivate a GL Journal with any line defined as "open items" 
causes defect 0042506 closed AtulOpenbravo Modules Error when processing a remittance if a G/L journal was previously processed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-09 13:28ngarciaNew Issue
2019-01-09 13:28ngarciaAssigned To => Triage Finance
2019-01-09 13:28ngarciaModules => Core
2019-01-09 13:28ngarciaResolution time => 1548802800
2019-01-09 13:28ngarciaTriggers an Emergency Pack => No
2019-01-09 13:29ngarciaRelationship addeddepends on 0039889
2019-01-09 14:35SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2019-01-09 15:11ngarciaRelationship addedrelated to 0030260
2019-01-09 15:27rafarodaIssue Monitored: rafaroda
2019-01-10 18:26AtulOpenbravoStatusnew => scheduled
2019-01-11 13:58AtulOpenbravoNote Added: 0108928
2019-01-11 13:59AtulOpenbravoNote Edited: 0108928bug_revision_view_page.php?bugnote_id=0108928#r18116
2019-01-14 13:41hgbotCheckin
2019-01-14 13:41hgbotNote Added: 0108943
2019-01-14 13:41hgbotStatusscheduled => resolved
2019-01-14 13:41hgbotResolutionopen => fixed
2019-01-14 13:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5aff6a4a578c5ce62109e8f0a04f5a17773ba182 [^]
2019-01-14 13:42SandrahuguetReview Assigned To => Sandrahuguet
2019-01-14 13:42SandrahuguetNote Added: 0108944
2019-01-14 13:42SandrahuguetStatusresolved => closed
2019-01-14 13:42SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110722
2019-12-30 17:34AtulOpenbravoRelationship addedblocks 0042506
2019-12-30 17:34AtulOpenbravoRelationship replacedcauses 0042506

Notes
(0108928)
AtulOpenbravo   
2019-01-11 13:58   
(edited on: 2019-01-11 13:59)
- Login as International Group admin role
- Create a Simple G/L Journal:
      Organization: F&B US East Coast
      General Ledger: F&B International Group US/A/US Dollar
- Add a line to it:
      Account: 1110 - Checking Account
      Debit: 100
      Open Items: Y
      Select Financial Account, Payment Method, G/L Item and Payment Date
- Add another line to it:
      Account: 1120 - Funds In-Transfer
      Credit: 100
      Open Items: N
- Complete it
- Navigate to the payment created in previous step
- Check you cannot use any of the action: reactivate / reactivate and delete it for the payment.
- Error message is shown as
  "To reactivate the payment, Unpost and unprocess G/L Journal of the G/L Journal Line in which payment is linked."
- Navigate to G/L Journal, - Reactivate it
- Check a warning is shown. This is correct
- Try to delete the G/L Journal Line that has previous payment linked to it.
- Error is shown as "If you want to delete G/L Journal Line, you must first reactivate and delete its related payment."
- Navigate to the payment created in previous step
- Check you can use any of the action: reactivate / reactivate and delete it for the payment and payment could be deleted.
- Now again navigating to G/L Journal Line, try to delete it, line could be deleted now.
(0108943)
hgbot   
2019-01-14 13:41   
Repository: erp/devel/pi
Changeset: 5aff6a4a578c5ce62109e8f0a04f5a17773ba182
Author: atul.gaware <at> openbravo.com <atul.gaware <at> openbravo.com>
Date: Fri Jan 11 18:18:40 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5aff6a4a578c5ce62109e8f0a04f5a17773ba182 [^]

Fixes Issue 39895: Simple G/L Journal line can be removed although
it has related payment. Payment can be deleted although the journal
is processed

** Before deleting gj journal line check is done for linked payment
if payment is linked error message is shown else line can be deleted.
** Before reactivating payment check is whether it is linked with gl
journal line having processed flag = yes in its header gl journal.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_PMT_CHECK_TRG.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/model/triggers/GL_JL_CHK_RESTRICTIONS_TRG.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
---
(0108944)
Sandrahuguet   
2019-01-14 13:42   
Code review + testing OK
(0110722)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test