Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039888Openbravo ERP09. Financial managementpublic2019-01-09 10:482019-03-28 14:56
Reporterdmiguelez 
Assigned Todmiguelez 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039888: Wrong Cost Adjustment created when Reactivating a Landed Cost
DescriptionWhen a Landed Cost is reactivated, the Cost Adjustment created is not correct.
Steps To ReproduceWith the fix for the issue 39822 applied, follow the steps of the test plan till the end. https://issues.openbravo.com/view.php?id=39822 [^]

Go to Landed Cost window and select the last Landed Cost Document created.
Click on reactivate.

Go to Product window and select the product named Final Product.
Go to Transactions Tab and order them by transaction process date.
The first Production Transaction has a Total Cost of 59.830.120, this is wrong
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 39888_proposed_solution.diff (2,150) 2019-01-09 10:52
https://issues.openbravo.com/file_download.php?file_id=12493&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-09 10:48dmiguelezNew Issue
2019-01-09 10:48dmiguelezAssigned To => Triage Finance
2019-01-09 10:48dmiguelezModules => Core
2019-01-09 10:48dmiguelezTriggers an Emergency Pack => No
2019-01-09 10:51dmiguelezNote Added: 0108864
2019-01-09 10:52dmiguelezFile Added: 39888_proposed_solution.diff
2019-01-09 11:10ngarciaIssue Monitored: ngarcia
2019-01-10 09:51jfrancesIssue Monitored: jfrances
2019-01-15 08:32hgbotCheckin
2019-01-15 08:32hgbotNote Added: 0108958
2019-01-15 08:32hgbotStatusnew => resolved
2019-01-15 08:32hgbotResolutionopen => fixed
2019-01-15 08:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a913d96060c70bef008d450bef6aaa18fbdbbd3d [^]
2019-01-15 09:07SandrahuguetAssigned ToTriage Finance => dmiguelez
2019-01-15 11:29SandrahuguetReview Assigned To => Sandrahuguet
2019-01-15 11:29SandrahuguetStatusresolved => closed
2019-01-15 11:29SandrahuguetFixed in Version => 3.0PR19Q2
2019-03-05 12:45hgbotCheckin
2019-03-05 12:45hgbotNote Added: 0110230
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110726
2019-03-28 14:56hudsonbotCheckin
2019-03-28 14:56hudsonbotNote Added: 0110846

Notes
(0108864)
dmiguelez   
2019-01-09 10:51   
Test Plan:

With the fix for the issue 39822 applied, follow the steps of the test plan till the end. https://issues.openbravo.com/view.php?id=39822 [^] [^]

Go to Landed Cost window and select the last Landed Cost Document created.
Click on reactivate.

Go to Product window and select the product named Final Product.
Go to Transactions Tab and order them by transaction process date.
The first Production Transaction has a Total Cost of -109.880 and the other two 120

Go to Landed Cost window and select the first Landed Cost Document created.
Click on reactivate.

Go to Product window and select the product named Final Product.
Go to Transactions Tab and order them by transaction process date.
The first Production Transaction has a Total Cost of -9980 and the other two 20
(0108958)
hgbot   
2019-01-15 08:32   
Repository: erp/devel/pi
Changeset: a913d96060c70bef008d450bef6aaa18fbdbbd3d
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Jan 14 09:40:46 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a913d96060c70bef008d450bef6aaa18fbdbbd3d [^]

Fixes Issue 39888. When canceling a cost adjustment:

* Keep the Negative Stock Correction and Backdated Transactions
  flags with the same values as the original record
* When retrieving the lines of the Adjustment, retrieve also the lines
  from Adjusments in Voided Status

---
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CancelCostAdjustment.java
---
(0110230)
hgbot   
2019-03-05 12:45   
Repository: erp/devel/pi
Changeset: 2f46504e585b3d1b92232837aaa13b52e660ad8c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Feb 19 15:35:08 2019 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/2f46504e585b3d1b92232837aaa13b52e660ad8c [^]

Related To Issue 39888: Added junit test

---
M src-test/src/org/openbravo/test/costing/TestCosting.java
M src-test/src/org/openbravo/test/costing/assertclass/ProductTransactionAssert.java
M src-test/src/org/openbravo/test/costing/utils/TestCostingConstants.java
M src-test/src/org/openbravo/test/costing/utils/TestCostingUtils.java
A src-test/src/org/openbravo/test/costing/TestIssue39888.java
---
(0110726)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110846)
hudsonbot   
2019-03-28 14:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test