Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039885Openbravo ERP00. Application dictionarypublic2019-01-08 18:572019-03-28 14:55
Reporteregoitz 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-03-01
Regression introduced in release3.0PR18Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/6d6a3a710fd21bbc60de46c5778b212c64ec300c [^]
Triggers an Emergency PackNo
Summary0039885: The link to a concrete document of Openbravo is not followed if there is not session on the browser
DescriptionWhen using the link to navigate to a concrete document it works properly when you are logged in Openbravo.
If there is not a session you are requested to do the login and after the login
you are not redirected to the document.

It was working in previous releases.
Steps To Reproduce-Access to Openbravo
-go to sales order window
-clear the filter and open order in form view
-click on the toolbar button to get the link
-Copy the link
-Logout
-Use the link on a browser
-The login is required
*then you are not redirected to the document specified on the link.

Example:
https://livebuilds.openbravo.com/erp_pi_pgsql/?tabId=186&recordId=05C426107193402BBD8379EF92A63E96 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00399043.0PR19Q1 closed caristu The link to a concrete document of Openbravo is not followed if there is not session on the browser 
depends on backport 00399053.0PR18Q4.2 closed caristu The link to a concrete document of Openbravo is not followed if there is not session on the browser 
depends on backport 00399063.0PR18Q3.5 closed caristu The link to a concrete document of Openbravo is not followed if there is not session on the browser 
caused by defect 0038079 closed alostale row created in ad_session opening openbravo base url 
related to defect 0039938 closed caristu It is not needed to keep the URL target query string in session 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-01-08 18:57egoitzNew Issue
2019-01-08 18:57egoitzAssigned To => platform
2019-01-08 18:57egoitzModules => Core
2019-01-08 18:57egoitzResolution time => 1548630000
2019-01-08 18:57egoitzRegression level => Production - Confirmed Stable
2019-01-08 18:57egoitzTriggers an Emergency Pack => No
2019-01-09 08:05alostalePriorityhigh => immediate
2019-01-09 11:00caristuAssigned Toplatform => caristu
2019-01-09 17:53caristuRelationship addedcaused by 0038079
2019-01-09 17:53caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/6d6a3a710fd21bbc60de46c5778b212c64ec300c [^]
2019-01-09 17:54caristuRegression date => 2018-03-01
2019-01-09 17:54caristuRegression introduced in release => 3.0PR18Q2
2019-01-09 18:01caristuStatusnew => scheduled
2019-01-14 11:01hgbotCheckin
2019-01-14 11:01hgbotNote Added: 0108936
2019-01-14 11:01hgbotStatusscheduled => resolved
2019-01-14 11:01hgbotResolutionopen => fixed
2019-01-14 11:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c885bc2fceca9a874c7b75e9efb7d27f2483aed [^]
2019-01-14 11:02caristuNote Added: 0108937
2019-01-14 11:05caristuReview Assigned To => alostale
2019-01-14 11:15caristuRelationship addedrelated to 0039938
2019-01-14 13:23hgbotCheckin
2019-01-14 13:23hgbotNote Added: 0108939
2019-01-14 16:07caristuNote Deleted: 0108937
2019-01-14 16:07caristuNote Added: 0108952
2019-01-14 16:07caristuNote Edited: 0108952bug_revision_view_page.php?bugnote_id=0108952#r18122
2019-01-16 09:39hgbotCheckin
2019-01-16 09:39hgbotNote Added: 0108970
2019-01-18 09:15alostaleNote Added: 0109000
2019-01-18 09:15alostaleStatusresolved => closed
2019-01-18 09:15alostaleFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110720
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110721
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110730

Notes
(0108936)
hgbot   
2019-01-14 11:01   
Repository: erp/devel/pi
Changeset: 0c885bc2fceca9a874c7b75e9efb7d27f2483aed
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 14 10:37:29 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c885bc2fceca9a874c7b75e9efb7d27f2483aed [^]

fixes bug 39885: link to a document isn't followed properly after login

  Before[1] the URL query string used to specify the link to a concrete document was being stored in session. After that changeset the code to save that value in session was no longer being executed, so it was not possible to recover the document link information.

  To solve this problem now we keep the query string with the link information in the URL, and we retrieve it from there when needed.


  [1] https://code.openbravo.com/erp/devel/pi/rev/6d6a3a710fd21bbc60de46c5778b212c64ec300c [^]

---
M src/index.jsp
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/erpCommon/security/Login.html
M web/js/login.js
M web/js/utils.js
---
(0108939)
hgbot   
2019-01-14 13:23   
Repository: erp/devel/pi
Changeset: 76e291866ae6346fa03caa10937df42bf20a3490
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jan 14 13:23:02 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/76e291866ae6346fa03caa10937df42bf20a3490 [^]

related to issue 39885: make it work also when redirecting to Menu.html

  This flow happens when some kind of license restriction is detected during the login process

---
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/erpCommon/security/Menu.java
---
(0108952)
caristu   
2019-01-14 16:07   
TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-11123 [^]
(0108970)
hgbot   
2019-01-16 09:39   
Repository: erp/devel/pi
Changeset: 3277f851fae894cdde4f678a9591510cc71ff571
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Jan 16 09:37:56 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3277f851fae894cdde4f678a9591510cc71ff571 [^]

related to issue 39885: add test case

---
M src-test/src/org/openbravo/test/AllWebserviceTests.java
A src-test/src/org/openbravo/test/datasource/OpenRecordAfterLogin.java
---
(0109000)
alostale   
2019-01-18 09:15   
Reviewed + tested
(0110720)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110721)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110730)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test