Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039878Openbravo ERPA. Platformpublic2019-01-08 09:142019-03-28 14:55
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039878: Import Entry can be created defining Client and Organization
DescriptionCurrently, Import Entries can be created using the createImportEntry() method in ImportEntryManager. However, these implementations assume the client,organization and role from the current OBContext. It'd be preferable to have and option to manually set those values.
Steps To ReproduceSee above.
Proposed SolutionInstead of creating more implementations of createImportEntry() with even more parameters, a Builder pattern with a fluent API can be made to create and validate the newly created ImportEntry.
Additional Information
TagsNo tags attached.
Relationships
causes defect 0041033 closed caristu ImportEntryPreProcessors with qualifiers are not executed 
Attached Filespatch 39878.patch (26,837) 2019-01-09 18:14
https://issues.openbravo.com/file_download.php?file_id=12495&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-08 09:14jarmendarizNew Issue
2019-01-08 09:14jarmendarizAssigned To => jarmendariz
2019-01-08 09:14jarmendarizOBNetwork customer => No
2019-01-08 09:14jarmendarizModules => Core
2019-01-08 09:14jarmendarizTriggers an Emergency Pack => No
2019-01-08 09:14jarmendarizStatusnew => scheduled
2019-01-09 18:14jarmendarizFile Added: 39878.patch
2019-01-09 18:15jarmendarizReview Assigned To => AugustoMauch
2019-01-17 17:34hgbotCheckin
2019-01-17 17:34hgbotNote Added: 0108997
2019-01-17 17:34hgbotStatusscheduled => resolved
2019-01-17 17:34hgbotResolutionopen => fixed
2019-01-17 17:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^]
2019-01-18 13:02hgbotCheckin
2019-01-18 13:02hgbotNote Added: 0109016
2019-01-18 13:18jarmendarizNote Added: 0109017
2019-01-18 13:27hgbotCheckin
2019-01-18 13:27hgbotNote Added: 0109018
2019-01-18 13:35hgbotCheckin
2019-01-18 13:35hgbotNote Added: 0109019
2019-01-21 11:00hgbotCheckin
2019-01-21 11:00hgbotNote Added: 0109036
2019-01-22 11:47hgbotCheckin
2019-01-22 11:47hgbotNote Added: 0109065
2019-01-22 12:31AugustoMauchNote Added: 0109068
2019-01-22 12:31AugustoMauchStatusresolved => closed
2019-01-22 12:31AugustoMauchFixed in Version => 3.0PR19Q2
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110735
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110739
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110740
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110741
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110745
2019-03-28 14:55hudsonbotCheckin
2019-03-28 14:55hudsonbotNote Added: 0110751
2019-06-05 16:47caristuRelationship addedcauses 0041033

Notes
(0108997)
hgbot   
2019-01-17 17:34   
Repository: erp/devel/pi
Changeset: 90c48060859cc70935add00e77e8065dedb197cc
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Jan 08 11:59:12 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/90c48060859cc70935add00e77e8065dedb197cc [^]

Fixed issue 39878: Import entry can be created defining Client and Organization.

Created a Builder class with fluent API to create new Import entries that
validates and creates the new object. If commit and close is set to true,
ImportEntryManager will be notified about the new entry created.

---
M src-test/src/org/openbravo/test/AllAntTaskTests.java
M src/org/openbravo/service/importprocess/ImportEntryManager.java
A src-test/src/org/openbravo/test/system/ImportEntryBuilderTest.java
A src/org/openbravo/service/importprocess/ImportEntryAlreadyExistsException.java
A src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109016)
hgbot   
2019-01-18 13:02   
Repository: erp/devel/pi
Changeset: a1b397f50ae2ecc191ffc2e7be54c9eedf1f4197
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jan 18 12:56:43 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a1b397f50ae2ecc191ffc2e7be54c9eedf1f4197 [^]

Related to issue 39878: Adding public method documentation to ImportEntryBuilder

---
M src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109017)
jarmendariz   
2019-01-18 13:18   
Adding ImportEntryBuilder in wiki: http://wiki.openbravo.com/wiki/How_to_use_Import_Entry_to_distribute_changes#First_Step:_Create_Import_Entry_Record [^]
(0109018)
hgbot   
2019-01-18 13:27   
Repository: erp/devel/pi
Changeset: 644986ebb25042d7fbe96bc5459a2696ef00bdab
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jan 18 13:27:38 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/644986ebb25042d7fbe96bc5459a2696ef00bdab [^]

Related to issue 39878: Improving ImportEntryBuilder.setProperty documentation

---
M src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109019)
hgbot   
2019-01-18 13:35   
Repository: erp/devel/pi
Changeset: cf58c9985234a5455286f2d973760c8a3ad2b71e
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Jan 18 13:35:08 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cf58c9985234a5455286f2d973760c8a3ad2b71e [^]

Related to issue 39878: Changing documentation of exception thrown in validation

---
M src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109036)
hgbot   
2019-01-21 11:00   
Repository: erp/devel/pi
Changeset: 9f730ec444e7c9021361c621eb6fe398c3f931f7
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Mon Jan 21 10:59:28 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9f730ec444e7c9021361c621eb6fe398c3f931f7 [^]

Related to issue 39878: Small improvements.

---
M src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109065)
hgbot   
2019-01-22 11:47   
Repository: erp/devel/pi
Changeset: 36b484865d50a55797f2b512cddd369d9bfaf56c
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Jan 22 11:46:43 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/36b484865d50a55797f2b512cddd369d9bfaf56c [^]

Related to issue 39878: Renamed method to make it more descriptive

---
M src/org/openbravo/service/importprocess/ImportEntryBuilder.java
---
(0109068)
AugustoMauch   
2019-01-22 12:31   
Code reviewed and verified
(0110735)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110739)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110740)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110741)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110745)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test
(0110751)
hudsonbot   
2019-03-28 14:55   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b2fbc1588df4 [^]
Maturity status: Test