Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039865Openbravo ERPB. User interfacepublic2019-01-02 13:142019-05-31 09:35
Reporterplujan 
Assigned ToAugustoMauch 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target Version3.0PR19Q3Fixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039865: [19Q1] [KS] It is possible to create an empty record from an empty record
DescriptionWhile editing a record, pressing Tab in the last field or hitting Down key on any field should create a new blank record. However, performing the same action on a new blank record has no sense.
Steps To Reproduce1. As System Admin, open "Unit of measure" window
2. Filter the grid to get just one record
3. Using the pencil icon, edit the record
4. While editing a field, press Down key or use Tab key to move out of the record. As expected, a new record is shown.
5. Press Down or Tab key again, note another blank record is created. See attached screenshot.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041016 closed caristu creating new record in grid, empty record generated if clicking line while retrieving defaults 
related to defect 0041020 acknowledged Triage Platform Base inconsistent state creating new record in form while editing in grid an incomplete record 
Attached Filespng Tabbing_GridMode.png (37,302) 2019-01-02 13:14
https://issues.openbravo.com/file_download.php?file_id=12483&type=bug
png

? issue39865.export (3,099) 2019-05-22 19:25
https://issues.openbravo.com/file_download.php?file_id=12976&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-02 13:14plujanNew Issue
2019-01-02 13:14plujanAssigned To => platform
2019-01-02 13:14plujanFile Added: Tabbing_GridMode.png
2019-01-02 13:14plujanModules => Core
2019-01-02 13:14plujanTriggers an Emergency Pack => No
2019-04-17 09:49alostalePrioritynormal => urgent
2019-04-17 09:49alostaleTarget Version => 3.0PR19Q3
2019-05-20 10:46egoitzNote Added: 0111785
2019-05-20 11:58AugustoMauchAssigned Toplatform => AugustoMauch
2019-05-22 19:25AugustoMauchFile Added: issue39865.export
2019-05-27 09:31hgbotCheckin
2019-05-27 09:31hgbotNote Added: 0112155
2019-05-27 09:31hgbotStatusnew => resolved
2019-05-27 09:31hgbotResolutionopen => fixed
2019-05-27 09:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67bed13f91cad8d1bb1b32625cc566945b87ebf4 [^]
2019-05-27 13:54hudsonbotCheckin
2019-05-27 13:54hudsonbotNote Added: 0112176
2019-05-27 22:26egoitzIssue Monitored: egoitz
2019-05-31 09:35alostaleReview Assigned To => alostale
2019-05-31 09:35alostaleNote Added: 0112289
2019-05-31 09:35alostaleStatusresolved => closed
2019-05-31 09:35alostaleFixed in Version => 3.0PR19Q3
2019-06-04 09:48egoitzRelationship addedrelated to 0041016
2019-06-04 11:15alostaleRelationship addedrelated to 0041020

Notes
(0111785)
egoitz   
2019-05-20 10:46   
Hi,

The issue is also reproducible using the toolbar button to add a new line ingrid view. To reproduce:

-Create a header
-Go to child tab
-Click onthe new line in grid tool bar button
-Without apply changes, click again on the same tool bar button.


Could Both arrow key and button should be disabled if mandatory fields are not filled?
(0112155)
hgbot   
2019-05-27 09:31   
Repository: erp/devel/pi
Changeset: 67bed13f91cad8d1bb1b32625cc566945b87ebf4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed May 22 19:21:34 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/67bed13f91cad8d1bb1b32625cc566945b87ebf4 [^]

Fixes issue 39865: Do not create line if mandatory fields of current are empty

In the view grid, if in a new line there are mandatory fields not filled in, it should not be
possible to create a new line.

To prevent that, the updateState function of the new line toolbar button has been updated, and
the doCellEditEnd function of ob-view-grid also takes it into account.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0112176)
hudsonbot   
2019-05-27 13:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/bdad8ace6f89 [^]
Maturity status: Test
(0112289)
alostale   
2019-05-31 09:35   
reviewed + tested