Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039864Retail ModulesWeb POSpublic2019-01-01 14:252020-07-10 04:14
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket16719
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039864: Taxes are recalculated in Verified Returns receipts and it should not be done
DescriptionWhen one return receipt is created using verified return, the taxes are recalculated for this line, but it should not be done
Steps To ReproducePOS:
. create new receipt docNo: B1
. add line L1: tax selected Entregas IVA 21% is applied
. complete B1

BO:
. create new tax Entregas IVA 44% for IVA Normal Tax Category, with valid from 01-01-2019

POS:
. refresh browser
. Verified Return: select B1
. select line L1
L1 is added to current receipt with tax Entregas IVA 44% -> it is wrong, the correct tax should be Entregas IVA 21%

(see screnshots attached)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0036530 closed jorge-garcia When opening a old ticket it is loaded with new taxes instead of the original ones 
depends on backport 0044558RR20Q3 closed ranjith_qualiantech_com Taxes are recalculated in Verified Returns receipts and it should not be done 
has duplicate design defect 0038415 closed Retail When returning old ticket it is loaded with new taxes instead of the original ones 
related to defect 0044530 closed ranjith_qualiantech_com "Cannot calculate receipt taxes" error raised due to timezone conversion 
Attached Filespng BO_taxes.png (52,456) 2019-01-01 14:27
https://issues.openbravo.com/file_download.php?file_id=12480&type=bug
png

png POS.png (122,068) 2019-01-01 14:27
https://issues.openbravo.com/file_download.php?file_id=12481&type=bug
png

diff patch39864.diff (949) 2019-01-01 18:07
https://issues.openbravo.com/file_download.php?file_id=12482&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-01-01 14:25malsasuaNew Issue
2019-01-01 14:25malsasuaAssigned To => Retail
2019-01-01 14:25malsasuaOBNetwork customer => Gold
2019-01-01 14:25malsasuaSupport ticket => 7209
2019-01-01 14:25malsasuaResolution time => 1546383600
2019-01-01 14:25malsasuaTriggers an Emergency Pack => No
2019-01-01 14:27malsasuaFile Added: BO_taxes.png
2019-01-01 14:27malsasuaFile Added: POS.png
2019-01-01 15:15malsasuaRelationship addedrelated to 0036530
2019-01-01 18:07malsasuaFile Added: patch39864.diff
2019-01-18 13:33marvintmResolution time1546383600 =>
2020-06-29 16:11ngarciaRelationship addedrelated to 0038415
2020-06-29 16:21ngarciaRelationship deletedrelated to 0038415
2020-06-29 16:22ngarciaRelationship addedduplicate of 0038415
2020-06-29 16:27LeyreSupport ticket7209 => 16719
2020-06-29 16:27LeyreResolution time => 1594591200
2020-06-29 16:27LeyreTypedesign defect => defect
2020-06-30 10:47marvintmNote Added: 0121156
2020-07-01 15:56ngarciaRelationship replacedhas duplicate 0038415
2020-07-05 18:01ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2020-07-06 08:09marvintmStatusnew => scheduled
2020-07-09 11:40hgbotMerge Request Status => open
2020-07-09 11:40hgbotNote Added: 0121351
2020-07-09 15:33hgbotMerge Request Statusopen => approved
2020-07-09 15:34hgbotResolutionopen => fixed
2020-07-09 15:34hgbotStatusscheduled => closed
2020-07-09 15:34hgbotNote Added: 0121375
2020-07-09 15:34hgbotNote Added: 0121376
2020-07-10 04:14hgbotNote Added: 0121381
2020-07-10 07:46ranjith_qualiantech_comNote Deleted: 0121381
2020-07-20 07:00ranjith_qualiantech_comRelationship addedrelated to 0044530

Notes
(0121156)
marvintm   
2020-06-30 10:47   
This was working before, and was broken with the project of the new tax engine for IndexedDB.
(0121351)
hgbot   
2020-07-09 11:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/29 [^]
(0121375)
hgbot   
2020-07-09 15:34   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: a10db1ada10474ba38b8601e8e6a1658bbc58d23
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-09T13:14:57+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a10db1ada10474ba38b8601e8e6a1658bbc58d23 [^]

Fixed issue-39864: Line tax should be added based on ValidFromDate for Order and Verified returns

---
M web/org.openbravo.retail.posterminal/app/model/business-logic/taxes-engine/engine/tax-engine.js
M web/org.openbravo.retail.posterminal/js/taxesengine/pos/pos-taxes.js
---
(0121376)
hgbot   
2020-07-09 15:34   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/29 [^]