Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039863Openbravo ERP09. Financial managementpublic2018-12-31 17:292022-02-07 17:20
ReporterJONHM 
Assigned Tomarkmm82 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket36801
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039863: AverageAlgorithm class can be improved by showing the product.getSearchKey() on the OBException
DescriptionThe OBException of getOutgoingTransactionCost() method of AverageAlgorithm class can be improved by showing the product.getSearchKey().
In case of variants or generic products is difficult to tell which product is throwing the exception in case of errors.
Steps To ReproduceIn case of variants or generic products is difficult to tell which product is throwing the exception in case of errors.
Proposed SolutionShow the product.getSearchKey() into the OBException:
https://code.openbravo.com/erp/devel/pi/file/tip/src/org/openbravo/costing/AverageAlgorithm.java#l85 [^]

Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff costes.diff (5,034) 2022-01-24 11:51
https://issues.openbravo.com/file_download.php?file_id=16538&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-12-31 17:29JONHMNew Issue
2018-12-31 17:29JONHMAssigned To => Triage Finance
2018-12-31 17:29JONHMOBNetwork customer => OBPS
2018-12-31 17:29JONHMModules => Core
2018-12-31 17:29JONHMTriggers an Emergency Pack => No
2019-09-13 06:56markmm82Assigned ToTriage Finance => markmm82
2019-09-13 06:56markmm82Statusnew => scheduled
2019-09-26 03:17markmm82Note Added: 0114791
2022-01-24 11:51dromeroSupport ticket => 36801
2022-01-24 11:51dromeroProposed Solution updated
2022-01-24 11:51dromeroNote Added: 0134507
2022-01-24 11:51dromeroFile Added: costes.diff
2022-02-01 15:10hgbotMerge Request Status => open
2022-02-01 15:10hgbotNote Added: 0134717
2022-02-07 16:41hgbotMerge Request Statusopen => approved
2022-02-07 17:20hgbotResolutionopen => fixed
2022-02-07 17:20hgbotStatusscheduled => closed
2022-02-07 17:20hgbotFixed in Version => PR22Q2
2022-02-07 17:20hgbotNote Added: 0134811
2022-02-07 17:20hgbotNote Added: 0134812

Notes
(0114791)
markmm82   
2019-09-26 03:17   
Notice new exception include the product name and the product search key in the format:
Product: <Product Name> (<Product Search Key>)
(0134507)
dromero   
2022-01-24 11:51   
Attached patch for solution
(0134717)
hgbot   
2022-02-01 15:10   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/519 [^]
(0134811)
hgbot   
2022-02-07 17:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: c119be731f17076d443d024b62a87645b98d2040
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 07-02-2022 16:18:36
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c119be731f17076d443d024b62a87645b98d2040 [^]

Fixed ISSUE-39863: Costing exceptions now show product identifier

This is especially useful when working with variants or generic products.

Patch provided by CSU

---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostingAlgorithm.java
M src/org/openbravo/costing/CostingUtils.java
---
(0134812)
hgbot   
2022-02-07 17:20   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/519 [^]