Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039826Retail ModulesWeb POSpublic2018-12-18 09:252018-12-19 17:52
Reporterguillermogil 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039826: Console error while opening the menu
DescriptionConsole error while opening the menu.
There is an Scope error:
TypeError: Cannot read property 'apply' of undefined
at Object.enyo.kind.inherited (https://butcopy-central.services.openbravo.com/openbravo/web/org.openbravo.mobile.core/build/enyo.js:410:28 [^])
at Object.<anonymous> (https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e60549b20b8_WebPOS.js:1012:694 [^])
at callbackFunc (https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e60549b20b8_WebPOS.js:2641:109 [^])
at request (https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e60549b20b8_WebPOS.js:2642:19 [^])
at https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e60549b20b8_WebPOS.js:2644:328 [^]
at https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e60549b20b8_WebPOS.js:2641:399 [^]
at G.d.callbackExecutor (https://butcopy-central.services.openbravo.com/openbravo/web/js/gen/ee7b671de59995bf4e632e6054 [^]


Review ob-menu.js
    show: function(args) {
        var arg = arguments;
        OB.UTIL.Approval.requestApproval(OB.MobileApp.view.$.containerWindow.getRoot().model, 'OBMOBC_approval.openMenu', enyo.bind(this, function(approved, supervisor, approvalType) {
            var me = this;
            if (approved) {
                if (this.autoDismiss) {
                    this.autoDismiss = false;
                    this.inherited(arg);
                    setTimeout(function() {
                        me.autoDismiss = true;
                    }, 100);
                } else {
                    this.inherited(arguments);
                }
            } else {
                this.inherited(arg);
                this.hide();
            }
        }));
    },

this.inherited(arguments); is wrong
Steps To ReproduceRandom while opening the menu
Proposed SolutionChange
this.inherited(arguments);
to:
this.inherited(arg);
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-18 09:25guillermogilNew Issue
2018-12-18 09:25guillermogilAssigned To => Retail
2018-12-18 09:25guillermogilOBNetwork customer => Gold
2018-12-18 09:25guillermogilResolution time => 1546210800
2018-12-18 09:25guillermogilTriggers an Emergency Pack => No
2018-12-18 12:04ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-12-18 12:05ranjith_qualiantech_comStatusnew => scheduled
2018-12-19 11:36hgbotCheckin
2018-12-19 11:36hgbotNote Added: 0108671
2018-12-19 11:36hgbotStatusscheduled => resolved
2018-12-19 11:36hgbotResolutionopen => fixed
2018-12-19 11:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4db1bbadb19a8d82023c9974d1f36d0933ce89c2 [^]
2018-12-19 17:52marvintmReview Assigned To => marvintm
2018-12-19 17:52marvintmStatusresolved => closed
2018-12-19 17:52marvintmFixed in Version => RR19Q1

Notes
(0108671)
hgbot   
2018-12-19 11:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4db1bbadb19a8d82023c9974d1f36d0933ce89c2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Dec 19 16:06:25 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4db1bbadb19a8d82023c9974d1f36d0933ce89c2 [^]

Fixed issue 39826 : Modified Toolbar Menu show method inherited param

* inherited param arguments is replaced with correct param 'arg'
  because variable arguments have the reference of inner function, where arg has the original reference of show function param

---
M web/org.openbravo.mobile.core/source/component/ob-menu.js
---