Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039809ModulesSAP Connectorpublic2018-12-14 14:102018-12-20 18:08
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039809: Improvements in SAP ECC FTP/SFTP communication
DescriptionTwo topics need to be addressed:

- Components related to FTP/SFTP communication should be moved to a separate module. The JCo (required by in the certification process) and the debug communication methods will remain in the SAP ECC Core module.
- When a file is imported, add support to archiving it, instead of deleting it, which is what is currently being done.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-14 14:10AugustoMauchNew Issue
2018-12-14 14:10AugustoMauchAssigned To => platform
2018-12-14 14:11AugustoMauchAssigned Toplatform => AugustoMauch
2018-12-14 14:11AugustoMauchCategoryExternal Integration Infrastructure => SAP Connector
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108696
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108697
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108698
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108699
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108700
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108701
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108702
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108703
2018-12-20 18:08hgbotCheckin
2018-12-20 18:08hgbotNote Added: 0108704

Notes
(0108696)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 895a26401183f8c20929d1a3fe99e1118e5504d3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Nov 15 17:51:36 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/895a26401183f8c20929d1a3fe99e1118e5504d3 [^]

Related with issue 39809: SAP communication is defined at client level

---
M src-db/database/sourcedata/AD_TABLE.xml
---
(0108697)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 34c4e6128028aaf255b0b49e61174b00dfdfba09
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 14 14:40:43 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/34c4e6128028aaf255b0b49e61174b00dfdfba09 [^]

Related with issue 39809: IdocSynchronizers created with dep injection

---
M src-db/database/model/tables/SAPECC_FTP_CONFIGURATION.xml
M src-db/database/model/tables/SAPECC_JCO_CONFIGURATION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src/org/openbravo/service/integration/sapecc/communication/IdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/debug/LocalFileSystemIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/ftp/FtpIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/ftp/IdocFTPClient.java
M src/org/openbravo/service/integration/sapecc/communication/ftp/ImportRequestInfoIterator.java
M src/org/openbravo/service/integration/sapecc/communication/jco/JCoIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/process/ImportSynchronizationProcess.java
M src/org/openbravo/service/integration/sapecc/process/SapEccExporterSynchronizableBusinessObjectExporter.java
A src/org/openbravo/service/integration/sapecc/communication/IdocSynchronizerStore.java
A src/org/openbravo/service/integration/sapecc/communication/SapCommunicationType.java
A src/org/openbravo/service/integration/sapecc/communication/SapCommunicationTypeSelector.java
R src/org/openbravo/service/integration/sapecc/communication/IdocSynchronizerFactory.java
---
(0108698)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 6efd2238600db53be4191aa7223b7b9dad67ac5d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 14 14:42:42 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/6efd2238600db53be4191aa7223b7b9dad67ac5d [^]

Related with issue 39809: Move FTP components to external module

All the components in charge of the communication between Openbravo and a SAP ECC server via FTP
have been moved to an external module.

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TAB.xml
M src-db/database/sourcedata/AD_TABLE.xml
R lib/runtime/commons-net-3.6.jar
R src-db/database/model/tables/SAPECC_FTP_CONFIGURATION.xml
R src/org/openbravo/service/integration/sapecc/communication/ftp/FtpIdocSynchronizer.java
R src/org/openbravo/service/integration/sapecc/communication/ftp/IdocFTPClient.java
R src/org/openbravo/service/integration/sapecc/communication/ftp/ImportRequestInfoIterator.java
---
(0108699)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: e1886c73499a53921fc4f73361f386ff96ffce62
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Nov 19 17:06:51 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/e1886c73499a53921fc4f73361f386ff96ffce62 [^]

Related with issue 39809: Use IOUtils.toInputStream instead of custom implementation

---
M src/org/openbravo/service/integration/sapecc/idoc/IdocUnwrapper.java
---
(0108700)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 939d42947f077b36223e3466b05abe00c697384c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 14 14:44:29 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/939d42947f077b36223e3466b05abe00c697384c [^]

Related with issue 39809: Creates instance of class properly to use DI

Creates an instance of IdocSynchronizerStore using WeldUtils.getInstanceFromStaticBeanManager, it
cannot directly inject it because instances of ImportSynchronizationProcess are created using its
constructor, so they are not initialized by weld.

---
M src/org/openbravo/service/integration/sapecc/process/ImportSynchronizationProcess.java
---
(0108701)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 4f0d06f5ae524687b19f7c2b1c06b738d99d713f
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 17 09:34:06 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/4f0d06f5ae524687b19f7c2b1c06b738d99d713f [^]

Related with issue 39809: Change API of IdocSynchronizer to export batches

Now instead of exporting a single iDoc, IdocSynchronizer opens the API to export several files at
the same time. This will be useful to improve the performance of some IdocSynchronizers, for
instances those that use the FTP or SFTP protocol.

---
M src/org/openbravo/service/integration/sapecc/communication/IdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/debug/LocalFileSystemIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/jco/JCoIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/process/SapEccExporterSynchronizableBusinessObjectExporter.java
---
(0108702)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: 09921925649bf488e1064fd03e9487db27f98ac9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Nov 20 17:38:37 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/09921925649bf488e1064fd03e9487db27f98ac9 [^]

Related with issue 39809: Adds idoc subfolder columns and post action type

The idoc subfolder columns have been added to obei_entity_mapping. They had been moved to the FTP
module, but are now placed back in the core module because can be used also by DEBUG synchronizer.

The same applies for the post_action_type column of the SAPECC_COMMUNICATION table.

---
M src-db/database/model/modifiedTables/OBEI_ENTITY_MAPPING.xml
M src-db/database/model/tables/SAPECC_COMMUNICATION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/service/integration/sapecc/process/SapEccExporterSynchronizableBusinessObjectExporter.java
---
(0108703)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: ef3f1f9c43d307a3cfc740c260b2d1602b986f29
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 17 09:44:58 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/ef3f1f9c43d307a3cfc740c260b2d1602b986f29 [^]

Related with issue 39809: Debug idoc sync supports archiving

---
M src/org/openbravo/service/integration/sapecc/communication/debug/LocalFileSystemIdocSynchronizer.java
M src/org/openbravo/service/integration/sapecc/communication/debug/LocalFileSystemImportRequestInfoIterator.java
---
(0108704)
hgbot   
2018-12-20 18:08   
Repository: erp/pmods/org.openbravo.service.integration.sapecc
Changeset: e75d98483a2bf6dc58e894118950f3b2c22bd4c6
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Dec 17 09:51:27 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.integration.sapecc/rev/e75d98483a2bf6dc58e894118950f3b2c22bd4c6 [^]

Related with issue 39809: Use Paths.get to build paths more robustly

The current way of building paths was not robust, because could fail due to the absence of slashes
at the beginning and on the and of its definition in the application dictionary.

Now Paths.get is used, which is more robusts and builds the paths properly regardless of if the
subpaths have leading/trailing slashes.

---
M src/org/openbravo/service/integration/sapecc/communication/debug/LocalFileSystemImportRequestInfoIterator.java
M src/org/openbravo/service/integration/sapecc/process/SapEccExporterSynchronizableBusinessObjectExporter.java
---