Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039808ModulesWarehouse Pickingpublic2018-12-14 13:082019-01-03 15:13
Reporterngarcia 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0039808: Wrong description in Warehouse picking list if more than one sales order is grouped
DescriptionWrong description in Warehouse picking list if more than one sales order is grouped
Steps To ReproduceAs group admin role:
   Apply module's dataset
   Set Enable Stock Reservations preference to Y
   Log out and log in

   Create a sales order for a business partner
   Add a product with stock to it and book it
   Create a new sales order for a different business partner
   Add a product with stock to it and book it
   Select the two sales orders and Generate Picking List:
      Picking List Type: Direct Picking List to Customer
      Grouping Criteria: Group by business partner
   Check two picking list have been created and the second one includes the description of the first one
   Create a sales order for a business partner
   Add a product with stock to it and book it
   Create a new sales order for a different organization
   Add a product with stock to it and book it
   Select the two sales orders and Generate Picking List:
      Picking List Type: Direct Picking List to Customer
      Grouping Criteria: Group by organization
   Check two picking list have been created and the second one includes the description of the first one
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040164 closed Triage Omni WMS Wrong description in Warehouse picking list if more than one sales order is grouped and there is not stock of one of them 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-14 13:08ngarciaNew Issue
2018-12-14 13:08ngarciaAssigned To => Triage Finance
2018-12-14 13:08ngarciaResolution time => 1546556400
2018-12-14 13:08ngarciaIssue Monitored: ngarcia
2018-12-14 13:08ngarciaIssue End Monitor: ngarcia
2018-12-14 13:08ngarciaIssue Monitored: networkb
2018-12-14 13:26SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-12-19 12:20AtulOpenbravoStatusnew => scheduled
2019-01-03 11:48AtulOpenbravoNote Added: 0108810
2019-01-03 15:10hgbotCheckin
2019-01-03 15:10hgbotNote Added: 0108814
2019-01-03 15:10hgbotStatusscheduled => resolved
2019-01-03 15:10hgbotResolutionopen => fixed
2019-01-03 15:10hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/a6491bb41302b970ab24894d489a6dcc646344aa [^]
2019-01-03 15:13SandrahuguetReview Assigned To => Sandrahuguet
2019-01-03 15:13SandrahuguetNote Added: 0108815
2019-01-03 15:13SandrahuguetStatusresolved => closed
2019-02-06 17:22ngarciaRelationship addedrelated to 0040164

Notes
(0108810)
AtulOpenbravo   
2019-01-03 11:48   
- Login as F&B International Group Admin role:
   Apply module's dataset
   Set Enable Stock Reservations preference to Y
   Log out and log in

- Create a sales order for a business partner "Hoteles Buenas Noches, S.A." in organization "F&B España, S.A"
- Add a product with stock "Vino Blanco 0,75L" to it and book it
- Create a new sales order for a different business partner "Restaurantes Luna Llena, S.A." in organization "F&B España, S.A"
- Add a product with stock "Vino Blanco 0,75L" to it and book it
- Select the two sales orders and Generate Picking List:
      Picking List Type: Direct Picking List to Customer
      Grouping Criteria: Group by business partner
- Check two picking list have been created and they includes the description of the respective orders.
- Create a sales order for a business partner "Hoteles Buenas Noches, S.A." in organization "F&B España - Región Norte".
- Add a product with stock "Vino Blanco 0,75L" to it and book it
- Create a new sales order for a business partner "Hoteles Buenas Noches, S.A." in a different organization "F&B España - Región Sur"
- Add a product with stock "Cola 0,5L" to it and book it
- Select the two sales orders and Generate Picking List:
      Picking List Type: Direct Picking List to Customer
      Grouping Criteria: Group by organization
- Check two picking list have been created and they includes proper description of the respective orders.

- Cancel all the Warehouse Picking List created.
- Select all four sales orders and Generate Picking List:
      Picking List Type: Direct Picking List to Customer
      Grouping Criteria: Group by organization
- Realize that three warehouse picking list are created. one each for "F&B España - Región Norte", "F&B España - Región Sur" and "F&B España, S.A" organization. Norte Region and Sur Region have descriptions of respective order. F&B Espana, S. A have description of two orders that were created in it.
(0108814)
hgbot   
2019-01-03 15:10   
Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: a6491bb41302b970ab24894d489a6dcc646344aa
Author: Atul Gaware -u <atul.gaware <at> openbraco.com>
Date: Thu Jan 03 16:20:21 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/a6491bb41302b970ab24894d489a6dcc646344aa [^]

Fixes Issue 0039808: Wrong description in Warehouse picking list
if more than one sales order is grouped

In loop, if the picking list is not created previously, then
reset description as blank, picking list object stored in hash
Map does not have description information hence reloading of object
is needed, secondly a flush is needed in case description is
set to picking list object so that it can be fetched.

---
M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java
---
(0108815)
Sandrahuguet   
2019-01-03 15:13   
Code review + testing OK