Openbravo Issue Tracking System - Modules
View Issue Details
0039806ModulesExternal Data Integrationpublic2018-12-14 12:532019-01-08 09:38
AugustoMauch 
AugustoMauch 
normalminorhave not tried
closedfixed 
5
 
 
caristu
0039806: Execute (optionally) import entries of EDL request that have the same search key in the same thread
Import entries of some EDL processes should be executed in the same thread if they have the same search key to guarantee that they are executed in the order they were created.

Allow to define this per EDL Process, and update EDLImportEntryProcessor to ensure that import entries that have the same search key are executed in the same thread for those processes.
-
No tags attached.
Issue History
2018-12-14 12:53AugustoMauchNew Issue
2018-12-14 12:53AugustoMauchAssigned To => platform
2018-12-20 18:02hgbotCheckin
2018-12-20 18:02hgbotNote Added: 0108694
2018-12-20 18:02hgbotStatusnew => resolved
2018-12-20 18:02hgbotResolutionopen => fixed
2018-12-20 18:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e97f473a4b5a165b6c49e6f6d5db4304c045327d [^]
2018-12-21 12:34caristuAssigned Toplatform => AugustoMauch
2018-12-21 12:34caristuReview Assigned To => caristu
2018-12-21 12:53hgbotCheckin
2018-12-21 12:53hgbotNote Added: 0108719
2018-12-21 13:51hgbotCheckin
2018-12-21 13:51hgbotNote Added: 0108723
2018-12-21 13:51hgbotCheckin
2018-12-21 13:51hgbotNote Added: 0108724
2019-01-08 09:38caristuStatusresolved => closed

Notes
(0108694)
hgbot   
2018-12-20 18:02   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: e97f473a4b5a165b6c49e6f6d5db4304c045327d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 14 13:42:52 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e97f473a4b5a165b6c49e6f6d5db4304c045327d [^]

Fixes bug 39806:ImportEntries with same searchK can be executed in same thread

Each EDL Process can define whether import entries with the same search key must be executed in
the same thread, ensuring that they are executed in its creation order.

---
M src-db/database/model/tables/OBEDL_PROCESS.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0108719)
hgbot   
2018-12-21 12:53   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: c16609f16c5add8c06d01c7f04aadd1a74b0990c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 21 12:53:17 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/c16609f16c5add8c06d01c7f04aadd1a74b0990c [^]

Related with issue 39806: Applies code review comments

- synchronized keyword is removed, it is no needed because the method was invoked by a single
thread process
- improves log message
- extracts string constant

---
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
---
(0108723)
hgbot   
2018-12-21 13:51   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: 86c02fc1321e1f45cee2751ea5daa3619fc20a6a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 14 13:56:38 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/86c02fc1321e1f45cee2751ea5daa3619fc20a6a [^]

Related with bug 39806: Single thread per search key limitation can be skipped

It is possible to skip the limitation that forces EDL import requests that use the same searchKey
to be executed in the same thread. This limitation is applied on some EDL processes to ensure that
import entries that use the same search key are executed in its creation order.

Sometimes it makes sense to skip the limitation, for instance in initial loads, where there is a
guarantee that there is only one record per imported entry.

---
M src-db/database/model/modifiedTables/AD_PROCESS_REQUEST.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBEDL_PROCESS.xml
M src/org/openbravo/service/external/integration/process/EdlRequestCreator.java
M src/org/openbravo/service/external/integration/process/ExternalSynchronizationProcess.java
---
(0108724)
hgbot   
2018-12-21 13:51   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: 210fc71fdba7684ccb16131dd6614c00732c433b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Dec 19 09:20:59 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/210fc71fdba7684ccb16131dd6614c00732c433b [^]

Related with issue 39806: Add missing field group

---
A src-db/database/sourcedata/AD_FIELDGROUP.xml
---