Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039805Openbravo ERP09. Financial managementpublic2018-12-14 12:102018-12-26 19:20
Reporteranderaranguren 
Assigned ToAtulOpenbravo 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039805: Cannot add new record in Modify Payment Plan from Purchase Invoice window when Total Outstanding field is not shown in grid
DescriptionCannot add new record in Modify Payment Plan from Purchase Invoice window when Total Outstanding field is not shown in grid view
Steps To Reproduce-Display Modify Payment Plan button from Purchase Invoice in Window,tabs and fields as System admin.
-And uncheck Show in Grid View of Total Outstanding field from Purchase Invoice header.
-Go to Purchase Invoice window select a record and pres Modify Payment Plan
-Try to Add New record and realize that nothing happens and an error is showing in the console.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng ModifyPaymentPlanAddNew.png (248,453) 2018-12-14 12:10
https://issues.openbravo.com/file_download.php?file_id=12436&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-12-14 12:10anderarangurenNew Issue
2018-12-14 12:10anderarangurenAssigned To => Triage Finance
2018-12-14 12:10anderarangurenFile Added: ModifyPaymentPlanAddNew.png
2018-12-14 12:10anderarangurenModules => Core
2018-12-14 12:10anderarangurenResolution time => 1546556400
2018-12-14 12:10anderarangurenTriggers an Emergency Pack => No
2018-12-14 13:27SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-12-18 05:09AtulOpenbravoStatusnew => scheduled
2018-12-18 06:39AtulOpenbravoNote Added: 0108659
2018-12-19 16:49jfrancesIssue Monitored: jfrances
2018-12-19 18:54SandrahuguetNote Edited: 0108659bug_revision_view_page.php?bugnote_id=0108659#r18070
2018-12-20 09:04hgbotCheckin
2018-12-20 09:04hgbotNote Added: 0108681
2018-12-20 09:04hgbotStatusscheduled => resolved
2018-12-20 09:04hgbotResolutionopen => fixed
2018-12-20 09:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0dc6820e006cc871aa1ed521625dca27c22bc85c [^]
2018-12-20 09:05SandrahuguetReview Assigned To => Sandrahuguet
2018-12-20 09:05SandrahuguetNote Added: 0108682
2018-12-20 09:05SandrahuguetStatusresolved => closed
2018-12-20 09:05SandrahuguetFixed in Version => 3.0PR19Q1
2018-12-20 21:30hudsonbotCheckin
2018-12-20 21:30hudsonbotNote Added: 0108708
2018-12-26 13:37SandrahuguetNote Added: 0108740
2018-12-26 13:37SandrahuguetStatusclosed => new
2018-12-26 13:37SandrahuguetResolutionfixed => open
2018-12-26 13:37SandrahuguetFixed in Version3.0PR19Q1 =>
2018-12-26 15:04hgbotCheckin
2018-12-26 15:04hgbotNote Added: 0108745
2018-12-26 15:06SandrahuguetStatusnew => scheduled
2018-12-26 15:06SandrahuguetStatusscheduled => resolved
2018-12-26 15:06SandrahuguetResolutionopen => fixed
2018-12-26 15:06SandrahuguetNote Added: 0108746
2018-12-26 15:06SandrahuguetStatusresolved => closed
2018-12-26 15:06SandrahuguetFixed in Version => 3.0PR19Q1
2018-12-26 19:20hudsonbotCheckin
2018-12-26 19:20hudsonbotNote Added: 0108757

Notes
(0108659)
AtulOpenbravo   
2018-12-18 06:39   
(edited on: 2018-12-19 18:54)
Test Plan
- Login as System admin.
- Display Modify Payment Plan button from Purchase Invoice/Payment Plan tab in Window,tabs and fields
- Uncheck Show in Grid View of Total Outstanding field from Purchase Invoice header.

- Go to Purchase Invoice window select a record (which is completed and is not yet paid).

- Go to Payment Plan window and select record and click Modify Payment Plan.
- Try to Add New record and realize that new record is created.

- Cancel new record, click on Paid Amount field in grid record. Check that no error is found in browser console. Prior to this fix error was shown Uncaught BigDecimal(), Not a Number, undefined.
(0108681)
hgbot   
2018-12-20 09:04   
Repository: erp/devel/pi
Changeset: 0dc6820e006cc871aa1ed521625dca27c22bc85c
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Dec 18 10:48:18 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/0dc6820e006cc871aa1ed521625dca27c22bc85c [^]

Fixes Issue 39805:Cannot add new record in Modify Payment Plan
from Purchase Invoice window when Total Outstanding field is
not shown in grid

** get value for outstanding amount from parent window's active
view context information.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0108682)
Sandrahuguet   
2018-12-20 09:05   
Code review + testing OK
(0108708)
hudsonbot   
2018-12-20 21:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/32784e66f6df [^]
Maturity status: Test
(0108740)
Sandrahuguet   
2018-12-26 13:37   
reopened because fix is not working using in Format.xml decimal separator ","
(0108745)
hgbot   
2018-12-26 15:04   
Repository: erp/devel/pi
Changeset: 068b3a6490439ec19196232fe127e0d1fe531e1e
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Dec 26 13:40:46 2018 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/068b3a6490439ec19196232fe127e0d1fe531e1e [^]

related to issue 39805 set proper parameters in getContextInfo

set proper parameters in getContextInfo, because it use to do operations.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0108746)
Sandrahuguet   
2018-12-26 15:06   
Code review + testing ok
(0108757)
hudsonbot   
2018-12-26 19:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/669070b8a1eb [^]
Maturity status: Test