Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039801Retail ModulesWeb POSpublic2018-09-25 17:482018-12-27 12:12
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q4.1Fixed in VersionRR18Q4.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket4459
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039801: Error using at the same time Cancel & Replace and Save Removed Ticket functionalities
DescriptionWhen Save Removed Ticket functionality is enabled, a receipt is created using Cancel and replace functionality, and a line is removed in the ticket, the ticket is stuck in Error While Importing window
Steps To Reproduce[BO]
. enable Web POS Save Removed Tickets functionality

[POS]
. create new ticket T1
. add new product P1
. complete ticket -> ticket is synced in BO
. load ticket T1 with Open Receipt functionality
. click in Cancel and Replace option -> new ticket is created T1-1
. add new product P2
. delete product P2
. delete ticket T1-1

[BO]
. go to Error While Importing window -> ticket T1-1 is in this window with error:
org.openbravo.base.exception.OBException: Error in OrderLoader: null
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:534)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:200)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:154)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:86)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:53)
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:59)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:367)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:288)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.NullPointerException
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:465)
    ... 12 more

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039352 closed ranjith_qualiantech_com Error using at the same time Cancel & Replace and Save Removed Ticket functionalities 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-13 17:58marvintmTypedefect => backport
2018-12-13 17:58marvintmTarget Version => RR18Q4.1
2018-12-14 11:09hgbotCheckin
2018-12-14 11:09hgbotNote Added: 0108605
2018-12-14 11:09hgbotStatusscheduled => resolved
2018-12-14 11:09hgbotResolutionopen => fixed
2018-12-14 11:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e81317f98de8f93ade73734f15864d98e11473f [^] => http://code.openbravo.com/retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal/rev/c88c22dcf8cbf5d78a2cc8704ff86de0a15036ee [^]
2018-12-14 11:09hgbotCheckin
2018-12-14 11:09hgbotNote Added: 0108606
2018-12-24 14:42marvintmStatusresolved => closed
2018-12-24 14:42marvintmFixed in Version => RR18Q4.1
2018-12-27 12:12hgbotCheckin
2018-12-27 12:12hgbotNote Added: 0108767

Notes
(0108605)
hgbot   
2018-12-14 11:09   
Repository: retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal
Changeset: c88c22dcf8cbf5d78a2cc8704ff86de0a15036ee
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 14 15:38:18 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal/rev/c88c22dcf8cbf5d78a2cc8704ff86de0a15036ee [^]

Fixed issue 39801 : Cashup ID should be updated for Cancelled Order from json data instead of cashup info

* JSON data should not be updated while savng record in OrderLoader
* JSON data Orderlines should not be updated with deletedLines
  because if any error occurs jsondata will be saved to dataentry for reprocess which may have duplicate records of deletedLine in lines data.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0108606)
hgbot   
2018-12-14 11:09   
Repository: retail/backports/3.0RR18Q4.1/pi-mobile
Changeset: 5d466fa17637ea1f9b8997e84c020448bac59dfe
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 14 15:38:26 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4.1/pi-mobile/rev/5d466fa17637ea1f9b8997e84c020448bac59dfe [^]

Verifies issue 39801 : Added Automated Test 'I39801_VerifyCancelReplaceWithSaveRemovePref'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39801_VerifyCancelReplaceWithSaveRemovePref.java
---
(0108767)
hgbot   
2018-12-27 12:12   
Repository: tools/automation/pi-mobile
Changeset: 5d466fa17637ea1f9b8997e84c020448bac59dfe
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Dec 14 15:38:26 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5d466fa17637ea1f9b8997e84c020448bac59dfe [^]

Verifies issue 39801 : Added Automated Test 'I39801_VerifyCancelReplaceWithSaveRemovePref'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cancelandreplace/I39801_VerifyCancelReplaceWithSaveRemovePref.java
---