Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0039796 | Retail Modules | Web POS | public | 2018-12-13 11:32 | 2018-12-24 08:50 |
|
| Reporter | pramodkumar | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR19Q1 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0039796: Reference OBPOS_payment.giftcard does not exist in module Web POS - 1.2.5501 |
| Description | In WebPOS, when using a role set to "manual", the method of payment gift card is grayed out and can not be used so the payment method is not active in pos.
The attachment shows the payment Bon d'achat is invisible.
|
| Steps To Reproduce | 1.Create a manual role and create a new user for it.
2.Access the pos the giftcard is disable. |
| Proposed Solution | The problem comes from the fact that the search key which should be used for the gift certificate payment method is not correct. Currently it is defined in the documentation as "OBPOS_payment.giftcard", and this is wrong because it belongs to the giftcard module, which has prefix GCNV.
So three changes need to be done:
- Documentation should be changed, to specify that the search key used should be "GCNV_payment.giftcard": http://wiki.openbravo.com/wiki/Retail:Gift_Cards/Gift_Certificates#POS_Terminal_Type [^]
- Gift cards module code should be changed to take this into account
- A modulescript should be added. This modulescript should update the OBPOS_APP_PAYMENT and OBPOS_PAYMENTMETHOD_TYPE "value" column to adjust existing records, changing existing 'OBPOS_payment.giftcard' to 'GCNV_payment.giftcard' |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  pos-screen.png (86,710) 2018-12-13 11:32
https://issues.openbravo.com/file_download.php?file_id=12432&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-12-13 11:32 | pramodkumar | New Issue | |
| 2018-12-13 11:32 | pramodkumar | Assigned To | => Retail |
| 2018-12-13 11:32 | pramodkumar | File Added: pos-screen.png | |
| 2018-12-13 11:32 | pramodkumar | Resolution time | => 1544655600 |
| 2018-12-13 11:32 | pramodkumar | Triggers an Emergency Pack | => No |
| 2018-12-13 15:06 | marvintm | Note Added: 0108587 | |
| 2018-12-13 15:06 | marvintm | Assigned To | Retail => pramodkumar |
| 2018-12-13 15:06 | marvintm | Status | new => feedback |
| 2018-12-14 14:26 | gorkaion | Note Added: 0108615 | |
| 2018-12-14 15:22 | marvintm | Resolution time | 1544655600 => 1545951600 |
| 2018-12-14 15:22 | marvintm | Assigned To | pramodkumar => Retail |
| 2018-12-14 15:22 | marvintm | Status | feedback => scheduled |
| 2018-12-14 15:22 | marvintm | Proposed Solution updated | |
| 2018-12-14 15:23 | marvintm | Type | design defect => defect |
| 2018-12-17 07:57 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2018-12-17 14:37 | hgbot | Checkin | |
| 2018-12-17 14:37 | hgbot | Note Added: 0108642 | |
| 2018-12-18 11:48 | ranjith_qualiantech_com | Status | scheduled => resolved |
| 2018-12-18 11:48 | ranjith_qualiantech_com | Resolution | open => fixed |
| 2018-12-24 08:48 | hgbot | Checkin | |
| 2018-12-24 08:48 | hgbot | Note Added: 0108726 | |
| 2018-12-24 08:50 | marvintm | Review Assigned To | => marvintm |
| 2018-12-24 08:50 | marvintm | Status | resolved => closed |
| 2018-12-24 08:50 | marvintm | Fixed in Version | => RR19Q1 |
|
Notes |
|
|
|
I don't understand multiple things about this issue:
- Is it really a design defect? shouldn't it be a defect?
- The payment method is supposed to be disabled if the role is manual, unless the preference for the payment method is defined for this role. Was this preference defined?
Could you explain the problem better? As of now, we just don't know what is wrong, and what needs to be fixed |
|
|
|
|
|
|
|
(0108642)
|
|
hgbot
|
|
2018-12-17 14:37
|
|
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: d09cac70c16aa08d275c30c28bdd5571ad96e422
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Dec 17 19:06:41 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/d09cac70c16aa08d275c30c28bdd5571ad96e422 [^]
Related to issue 39796 : Gift Card Payment Method and Payment Type Value has been renamed with Module DB prefix
* Updated all js files to use newly updated Payment Type Value
* Added Module script to update Payment Method and Payment Type Value with Module DB prefix
---
M src/org/openbravo/retail/giftcards/AutomaticDepositInitialValidations.java
M src/org/openbravo/retail/giftcards/hooks/GiftCardHookUtils.java
M src/org/openbravo/retail/giftcards/hooks/PreOrderLoaderHook.java
M web/org.openbravo.retail.giftcards/js/components/GiftCardCertificate.js
M web/org.openbravo.retail.giftcards/js/components/GiftCardMenu.js
M web/org.openbravo.retail.giftcards/js/hooks/AddButtonToCashManagementHook.js
M web/org.openbravo.retail.giftcards/js/hooks/PreReversePaymentHook.js
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
M web/org.openbravo.retail.giftcards/js/hooks/preremovepaymenthook.js
M web/org.openbravo.retail.giftcards/js/hooks/printGiftCardPrePrintHook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
A build/classes/org/openbravo/retail/giftcards/modulescript/UpdateGiftCardPaymentMethodPrefix.class
A src-util/modulescript/src/org/openbravo/retail/giftcards/modulescript/UpdateGiftCardPaymentMethodPrefix.java
---
|
|
|
|
(0108726)
|
|
hgbot
|
|
2018-12-24 08:48
|
|
|