Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039772Openbravo ERP00. Application dictionarypublic2018-12-10 13:072018-12-28 17:07
Reporterjoniturralde93 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR19Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerGold
Web browser
ModulesCore
Support ticket6786
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039772: Price includes Tax flag can lead to errors (verified return)
DescriptionIf you complete a ticket with Price includes Tax unchecked in Price List and you check it afterwards, then you try to verified return that ticket, the prices change.

This is related to a Gold Customer which, by mistake, unchecked this flag and some tickets were completed meanwhile. Now they can't return these, since the price is not the same after checking the flag again.
Steps To Reproduce1. Log into https://livebuilds.openbravo.com/retail_pi_pgsql/ [^]
2. Price List 'The White Valley Group Sale Price List', uncheck 'Price includes Tax'.
3. Go to POS Terminal, add some products and complete the ticket.
4. Check the flag again.
5.Refresh POS Terminal and 'Verified Returns': Open the previous ticket. The price changes.

In order to fix that ticket you have to uncheck the flag again and return the ticket, which can be problematic in a production environment.
Proposed SolutionPermanently disable flag after an order is done with that price list.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-10 13:07joniturralde93New Issue
2018-12-10 13:07joniturralde93Assigned To => Retail
2018-12-10 13:07joniturralde93OBNetwork customer => Gold
2018-12-10 13:07joniturralde93Support ticket => 6786
2018-12-10 13:07joniturralde93Resolution time => 1546210800
2018-12-10 13:07joniturralde93Triggers an Emergency Pack => No
2018-12-10 13:30jfrancesIssue Monitored: jfrances
2018-12-18 15:10rqueraltaAssigned ToRetail => rqueralta
2018-12-18 17:15joniturralde93ProjectRetail Modules => Openbravo ERP
2018-12-18 17:17joniturralde93Modules => Core
2018-12-18 17:17joniturralde93Assigned Torqueralta => Triage Finance
2018-12-18 17:17joniturralde93CategoryWeb POS => 00. Application dictionary
2018-12-18 17:18joniturralde93Proposed Solution updated
2018-12-19 13:00SandrahuguetAssigned ToTriage Finance => AtulOpenbravo
2018-12-20 10:30AtulOpenbravoStatusnew => scheduled
2018-12-21 03:51AtulOpenbravoNote Added: 0108713
2018-12-28 12:51hgbotCheckin
2018-12-28 12:51hgbotNote Added: 0108778
2018-12-28 12:51hgbotStatusscheduled => resolved
2018-12-28 12:51hgbotResolutionopen => fixed
2018-12-28 12:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/80dfa107feb9b958592953e3ac58ea132704c3e8 [^]
2018-12-28 12:51hgbotCheckin
2018-12-28 12:51hgbotNote Added: 0108779
2018-12-28 12:52SandrahuguetReview Assigned To => Sandrahuguet
2018-12-28 12:52SandrahuguetNote Added: 0108780
2018-12-28 12:52SandrahuguetStatusresolved => closed
2018-12-28 12:52SandrahuguetFixed in Version => 3.0PR19Q1
2018-12-28 17:07hudsonbotCheckin
2018-12-28 17:07hudsonbotNote Added: 0108785
2018-12-28 17:07hudsonbotCheckin
2018-12-28 17:07hudsonbotNote Added: 0108786

Notes
(0108713)
AtulOpenbravo   
2018-12-21 03:51   
- Login as F&B International Group Admin
- Navigate to Price List window
- Select "Tarifa de ventas"
- Try to set Price Includes Tax flag = Yes, Save Record.
- Error message is shown as:
"You cannot change the Price Includes Tax flag because the pricelist has been linked to transactional documents. See Linked Items for details."

- Create a new Price List in "F&B España, S.A" organization
- Set Price Includes Tax flag = No, Save Record.
- Try to set Price Includes Tax flag = Yes, Save Record.
- Price list is saved successfully.
- Use the above new price list in any of the following document.
  - Sales / Purchase Invoice Header
  - Sales / Purchase Order Header
  - Requistion / Requisition Line
- Save Record.
- Try to set Price Includes Tax flag = No, Save Record.
- Error message is shown as:
"You cannot change the Price Includes Tax flag because the pricelist has been linked to transactional documents. See Linked Items for details."
- Delete above documents created if any.
- Try to set Price Includes Tax flag = No, Save Record.
- Price list is saved successfully.
(0108778)
hgbot   
2018-12-28 12:51   
Repository: erp/devel/pi
Changeset: 80dfa107feb9b958592953e3ac58ea132704c3e8
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Dec 20 22:19:18 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/80dfa107feb9b958592953e3ac58ea132704c3e8 [^]

Fixes Issue 39772:Price includes Tax flag can lead to errors
(verified return)

Price Includes Tax flag in pricelist cannot be updated once
price list is being used in order or invoice in any status,
of any type.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A src-db/database/model/triggers/M_PRICELIST_TRG.xml
---
(0108779)
hgbot   
2018-12-28 12:51   
Repository: erp/devel/pi
Changeset: 713212c6b67f3ef544af9dcd4a37234479c9e04a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Thu Dec 20 23:39:02 2018 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/713212c6b67f3ef544af9dcd4a37234479c9e04a [^]

Related to Issue 39772:Price Includes Tax flag should not be
changed once pricelist is already used in transactional documents.

** Add Requisition and Requisition Line check for price list
before updating price includes tax flag.

---
M src-db/database/model/triggers/M_PRICELIST_TRG.xml
---
(0108780)
Sandrahuguet   
2018-12-28 12:52   
Code review + testing OK
(0108785)
hudsonbot   
2018-12-28 17:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/017b7152d4b2 [^]
Maturity status: Test
(0108786)
hudsonbot   
2018-12-28 17:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/017b7152d4b2 [^]
Maturity status: Test