Openbravo Issue Tracking System - Retail Modules
View Issue Details
0039760Retail ModulesWeb POSpublic2018-12-04 17:202018-12-11 15:27
aaroncalero 
ranjith_qualiantech_com 
highmajoralways
closedfixed 
5
 
 
migueldejuana
No
0039760: [Service by Tranche] WebPOS blocked after removing a ticket when Save Removed Tickets is configured
When the WebPOS Save Removed Tickets preference is configured, removing a ticket with a product and a service (configured with tranches) leaves the WebPOS in a blocked state.

When that ticket is removed, a calculateReceipt is fired (because of the Save Removed Tickets preference), and then on the calculatedReceipt event the Service Tranches logic tries to remove again the service, triggering a second calculateReceipt when it is blocked
In an environment with the standard Retail sampledata:
Login in backend as White Valley Group Admin.
Go to the Preference window and configure the 'Web POS Save Removed Tickets' preference.
Go to the Product window, find the 'Customize Coat' product, and on its Price Rule Version tab modify the existing record and define a Minimum of 50 and a Maximum of 150.

Login in webpos
Create a new ticket
Add the product Coat
When the related services are shown, add the Customize Coat service.
Try to delete the ticket.
The Service Removed popup will be shown (which is not correct)
Moreover, a "calculateGross execution is forbidden right now" error will be shown in the browser console.
Attached patch with the solution: the Service by Tranche logic to remove services will ignore lines that are already deleted.
No tags attached.
? Issue39760.export (1,049) 2018-12-04 17:30
https://issues.openbravo.com/file_download.php?file_id=12412&type=bug
Issue History
2018-12-04 17:20aaroncaleroNew Issue
2018-12-04 17:20aaroncaleroAssigned To => Retail
2018-12-04 17:20aaroncaleroResolution time => 1545087600
2018-12-04 17:20aaroncaleroTriggers an Emergency Pack => No
2018-12-04 17:30aaroncaleroFile Added: Issue39760.export
2018-12-06 14:09ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-12-06 14:10ranjith_qualiantech_comStatusnew => scheduled
2018-12-10 07:32hgbotCheckin
2018-12-10 07:32hgbotNote Added: 0108353
2018-12-10 07:32hgbotStatusscheduled => resolved
2018-12-10 07:32hgbotResolutionopen => fixed
2018-12-10 07:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c835aed8258fe2e051b1b30b7655132ff012f90c [^]
2018-12-10 11:58migueldejuanaReview Assigned To => migueldejuana
2018-12-10 11:58migueldejuanaNote Added: 0108357
2018-12-10 11:58migueldejuanaStatusresolved => closed
2018-12-11 15:27hgbotCheckin
2018-12-11 15:27hgbotNote Added: 0108395

Notes
(0108353)
hgbot   
2018-12-10 07:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c835aed8258fe2e051b1b30b7655132ff012f90c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Dec 10 12:02:20 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c835aed8258fe2e051b1b30b7655132ff012f90c [^]

Fixed issue 39760 : Service should not be validated while deleting ticket with Save Ticket Preference is enabled

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0108357)
migueldejuana   
2018-12-10 11:58   
Tested and reviewed
(0108395)
hgbot   
2018-12-11 15:27   
Repository: tools/automation/pi-mobile
Changeset: 543e80aa603da32e994fd82b61b7ae0afb886a26
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Dec 10 14:17:42 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/543e80aa603da32e994fd82b61b7ae0afb886a26 [^]

Related to issue 39760: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I39760_VerifyPOSWhenRemovingTicketWithSavedRemovedTicketsPref.java
---