Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039753Openbravo ERP09. Financial managementpublic2018-11-22 09:392018-12-12 16:33
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target Version3.0PR18Q4.1Fixed in Version3.0PR18Q4.1 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-03-11
Regression introduced in release3.0PR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/498699b38a5d0ddb368c9be379e25eb2732ee091 [^]
Triggers an Emergency PackNo
Summary0039753: Improve contention problems in fin_financial_account
DescriptionIn order to avoid concurrency problems when the current balance is calculated a lock was added in issue 35137. This lock is necessary, but is possible to reduce the lock and calculate the current balance at the end of the process.
Steps To Reproduce- In order to easily simulate the 2 transactions are processed at same time it is necessary to set a break-point just after execution of following code :

financialAccount.setCurrentBalance(financialAccount.getCurrentBalance().subtract(transaction.getDepositAmount()).add(transaction.getPaymentAmount()));

- Go to Payment In and create a payment:
  Organization: F&B España - Region Norte
  Received From: Alimentos y Supermercados, S.A
  Payment Method: Transferencia
  Deposit To: Cuenta de Banco - EUR
  Amount: 100
  In Add details - > Overpayment Action: Leave the credit to be used later
  Done and execution should be stopped in previous break-point

- Open "new incognito window" in Chrome and access
  Go to Payment In and create a new payment:
  Organization: F&B España - Region Norte
  Received From: Restaurantes Luna Llena, S.A.
  Payment Method: Transferencia
  Deposit To: Cuenta de Banco - EUR
  Amount: 200
  Click in add details, the popup does not open, save the header is locked
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039672 closed Sandrahuguet Improve contention problems in fin_financial_account 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-04 15:14SandrahuguetTypedefect => backport
2018-12-04 15:14SandrahuguetTarget Version3.0PR19Q2 => 3.0PR18Q4
2018-12-04 15:29SandrahuguetAssigned ToTriage Finance => Sandrahuguet
2018-12-05 13:19SandrahuguetReview Assigned To => vmromanos
2018-12-05 15:23hgbotCheckin
2018-12-05 15:23hgbotNote Added: 0108290
2018-12-05 15:23hgbotStatusscheduled => resolved
2018-12-05 15:23hgbotResolutionopen => fixed
2018-12-05 15:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/e6cdcf083b0d0282930aa6c4adc0e91c8ad1d489 [^]
2018-12-05 15:23hgbotCheckin
2018-12-05 15:23hgbotNote Added: 0108292
2018-12-05 17:52hgbotCheckin
2018-12-05 17:52hgbotNote Added: 0108305
2018-12-05 17:54SandrahuguetStatusresolved => new
2018-12-05 17:54SandrahuguetResolutionfixed => open
2018-12-07 11:29shuehnerTarget Version3.0PR18Q4 => 3.0PR18Q4.1
2018-12-11 17:24hgbotCheckin
2018-12-11 17:24hgbotNote Added: 0108406
2018-12-11 17:24hgbotStatusnew => resolved
2018-12-11 17:24hgbotResolutionopen => fixed
2018-12-11 17:24hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR18Q4/rev/e6cdcf083b0d0282930aa6c4adc0e91c8ad1d489 [^] => http://code.openbravo.com/erp/backports/3.0PR18Q4.1/rev/71014553054ccff7752630b91305ab706d32d325 [^]
2018-12-12 16:33vmromanosNote Added: 0108555
2018-12-12 16:33vmromanosStatusresolved => closed
2018-12-12 16:33vmromanosFixed in Version => 3.0PR18Q4.1

Notes
(0108290)
hgbot   
2018-12-05 15:23   
Repository: erp/backports/3.0PR18Q4
Changeset: e6cdcf083b0d0282930aa6c4adc0e91c8ad1d489
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Dec 05 12:58:36 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/e6cdcf083b0d0282930aa6c4adc0e91c8ad1d489 [^]

Fixed issue 39753 reduce lock and calculate the current balance at the end of the process

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0108292)
hgbot   
2018-12-05 15:23   
Repository: erp/backports/3.0PR18Q4
Changeset: 0ca8d4ff47098d0e29ae83e7d1342650c2c0fdfa
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Dec 05 15:17:53 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/0ca8d4ff47098d0e29ae83e7d1342650c2c0fdfa [^]

related to issue 39753 use lockForNoKeyUpdate instead of lockFinAccount

Use lockForNoKeyUpdate instead of use lockFinAccount in which a
"FOR UPDATE" is done and is too agressive.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0108305)
hgbot   
2018-12-05 17:52   
Repository: erp/backports/3.0PR18Q4
Changeset: 9f1554db0cc8d0c1c5d198e6a4f676a2859e2900
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Dec 05 17:52:24 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4/rev/9f1554db0cc8d0c1c5d198e6a4f676a2859e2900 [^]

related to issue 39753 backed out changeset 0ca8d4ff4709

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0108406)
hgbot   
2018-12-11 17:24   
Repository: erp/backports/3.0PR18Q4.1
Changeset: 71014553054ccff7752630b91305ab706d32d325
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Dec 11 17:18:05 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q4.1/rev/71014553054ccff7752630b91305ab706d32d325 [^]

fixed issue 39753 use the new method getObjectLockForNoKeyUpdate

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0108555)
vmromanos   
2018-12-12 16:33   
Code review OK