Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039747Retail ModulesWeb POSpublic2018-09-06 11:462018-12-27 10:27
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q3.4Fixed in VersionRR18Q3.4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039747: payment method has been deactivated when there is a cashup open, and sales were done in this payment method
DescriptionCurrently it's possible to disable a payment method for a Terminal, even if there is currently a cashup open, and sales were done for this payment method.

This will then lead to problems when trying to process the cashup.
Steps To Reproduce[POS]
. login
. do sales withi payment method "cash"

[BO]
. deactivate payment method "Cash" of this terminal

[POS]
- refresh web pos, and then do cashup
- notice the cashup went to errors while importing
Proposed SolutionIt should not be possible to disable the payment method of a terminal, if the terminal has an open cashup, and contains sales for this payment method.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039236 closed ranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-04 12:57marvintmTypedefect => backport
2018-12-04 12:57marvintmTarget Version => RR18Q3.4
2018-12-13 08:05hgbotCheckin
2018-12-13 08:05hgbotNote Added: 0108570
2018-12-13 08:16ranjith_qualiantech_comNote Added: 0108575
2018-12-13 08:17ranjith_qualiantech_comStatusscheduled => resolved
2018-12-13 08:17ranjith_qualiantech_comResolutionopen => fixed
2018-12-24 14:46marvintmReview Assigned To => marvintm
2018-12-24 14:46marvintmStatusresolved => closed
2018-12-24 14:46marvintmFixed in Version => RR18Q3.4
2018-12-27 10:27hgbotCheckin
2018-12-27 10:27hgbotNote Added: 0108764

Notes
(0108570)
hgbot   
2018-12-13 08:05   
Repository: retail/backports/3.0RR18Q3.4/pi-mobile
Changeset: a974317d56ca3f5b45b5163c5e2e414b0637706c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:16:58 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.4/pi-mobile/rev/a974317d56ca3f5b45b5163c5e2e414b0637706c [^]

Verifies issue 39747 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---
(0108575)
ranjith_qualiantech_com   
2018-12-13 08:16   
Repository: retail/backports/3.0RR18Q3.4/org.openbravo.retail.posterminal
Changeset: f94cacfba0785d5141725f49f139f5be183784da
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:15:15 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q3.4/org.openbravo.retail.posterminal/rev/f94cacfba0785d5141725f49f139f5be183784da [^] [^]

Fixed issue 39747 : Added Event Handler for Payment Method to check cashup is processed

* Added Event Handler for payment method while deactivating or removing it.
* Payment method can be deactivated or removed only when Cashup should be processed for all terminals

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java
(0108764)
hgbot   
2018-12-27 10:27   
Repository: tools/automation/pi-mobile
Changeset: a974317d56ca3f5b45b5163c5e2e414b0637706c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:16:58 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a974317d56ca3f5b45b5163c5e2e414b0637706c [^]

Verifies issue 39747 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---