Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0039746Retail ModulesWeb POSpublic2018-09-06 11:462018-12-27 12:12
Reportermalsasua 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q4.1Fixed in VersionRR18Q4.1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0039746: payment method has been deactivated when there is a cashup open, and sales were done in this payment method
DescriptionCurrently it's possible to disable a payment method for a Terminal, even if there is currently a cashup open, and sales were done for this payment method.

This will then lead to problems when trying to process the cashup.
Steps To Reproduce[POS]
. login
. do sales withi payment method "cash"

[BO]
. deactivate payment method "Cash" of this terminal

[POS]
- refresh web pos, and then do cashup
- notice the cashup went to errors while importing
Proposed SolutionIt should not be possible to disable the payment method of a terminal, if the terminal has an open cashup, and contains sales for this payment method.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0039236 closed ranjith_qualiantech_com payment method has been deactivated when there is a cashup open, and sales were done in this payment method 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-12-04 12:57marvintmTypedefect => backport
2018-12-04 12:57marvintmTarget Version => RR18Q4.1
2018-12-13 07:47hgbotCheckin
2018-12-13 07:47hgbotNote Added: 0108566
2018-12-13 07:47hgbotStatusscheduled => resolved
2018-12-13 07:47hgbotResolutionopen => fixed
2018-12-13 07:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/405b5ad065bf619565c26ec73d45eaf4d8bf34b8 [^] => http://code.openbravo.com/retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal/rev/9633d8833b3a6e85013b97234c33d7ace0942296 [^]
2018-12-13 07:47hgbotCheckin
2018-12-13 07:47hgbotNote Added: 0108568
2018-12-24 14:46marvintmReview Assigned To => marvintm
2018-12-24 14:46marvintmStatusresolved => closed
2018-12-24 14:46marvintmFixed in Version => RR18Q4.1
2018-12-27 12:12hgbotCheckin
2018-12-27 12:12hgbotNote Added: 0108766

Notes
(0108566)
hgbot   
2018-12-13 07:47   
Repository: retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal
Changeset: 9633d8833b3a6e85013b97234c33d7ace0942296
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:17:05 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4.1/org.openbravo.retail.posterminal/rev/9633d8833b3a6e85013b97234c33d7ace0942296 [^]

Fixed issue 39746 : Added Event Handler for Payment Method to check cashup is processed

* Added Event Handler for payment method while deactivating or removing it.
* Payment method can be deactivated or removed only when Cashup should be processed for all terminals

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/event/PaymentMethodTypeEventHandler.java
---
(0108568)
hgbot   
2018-12-13 07:47   
Repository: retail/backports/3.0RR18Q4.1/pi-mobile
Changeset: 28b72f4d4df6284130c667d7146b2cf308f5cbab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:15:09 2018 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR18Q4.1/pi-mobile/rev/28b72f4d4df6284130c667d7146b2cf308f5cbab [^]

Verifies issue 39746 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---
(0108766)
hgbot   
2018-12-27 12:12   
Repository: tools/automation/pi-mobile
Changeset: 28b72f4d4df6284130c667d7146b2cf308f5cbab
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 13 12:15:09 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/28b72f4d4df6284130c667d7146b2cf308f5cbab [^]

Verifies issue 39746 : Modified Test "I35320_VerifyLayawayButtonEnabled"

* Modified Test I35320_VerifyLayawayButtonEnabled, I34663_ExcludePaymentsNotActive
* Before deactivating the payment method, Cashup should be done

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I35320_VerifyLayawayButtonEnabled.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sampledata/I34663_ExcludePaymentsNotActive.java
---